[RFC] Move sidebars' integration code out of EvWindow and into EvSidebar
Right now, EvSidebar
is a simple GtkStack
, that gets dynamically filled from EvWindow
through ev_sidebar_add_page
. What this means, is that all the different sidebars (annotations, bookmarks, thumbnails...) are created and tracked by EvWindow
. However, that dynamic nature is not really necessary, since all the sidebars are always added, and then showed or not depending on the support of the document. Therefore, they can be moved to EvSidebar
, reducing the amount of code in EvWindow
and increasing the code encapsulation.
@gpoo would this make sense to you?
@crab2313, this is also tangentially related to the GTK4 move. Unfortunately, the GtkBuildable
interface for GtkPaned
is really limited in GTK3, and therefore moving to a template as a preparation step in GTK3 is not really feasible. Implementing this would help, but would also mean a lot of rebasing from you. So hopefully the GTK4 can be merged without these changes and this done afterwards. But if it still takes a while to get it merged, I guess it might happen :(