Skip to content

Fix crash on exit when tab sync enabled

Michael Catanzaro requested to merge mcatanzaro/sync-crash-on-exit into master

In f9e74d51 I added an assertion that causes Epiphany to crash on exit if the EphyShell global object has been leaked. This assertion is being triggered whenever Firefox Sync tab synchronization is enabled. It happens due to a circular reference. Break it.

This bug has existed since the Firefox Sync support was added. The assertion proves its value once again.

A better solution might be to make the EphyTabsCatalog a separate object instead of an interface implemented by EphyEmbedShell. I might or might not explore that in a follow-up commit, because EphyOpenTabsManager shouldn't have to know about implementation details of the EphyTabsCatalog.

Merge request reports