Session saving code's and WebKit's URI handling differ, preventing the session from being saved even if the offending page was loaded just fine
- Epiphany version: latest build from git
- WebKitGTK version: 2.41.6
- Distributor: N/A, but it works the same way for the Flathub flatpak too: I noticed this bug for at least a year, since I started working on !1053.
Steps to reproduce
Search https://packages.fedoraproject.org/search?query=%s in the URL entry. Now open some other websites or click some links in other already opened web pages.
Current behaviour
The session won't save, despite the typed URL being loaded just fine by the web view. This is because "%s" is not properly percent-encoded: WebKit does not seem to care while the GLib URI code used in the session saving code cares and refuse to save the session because it "does not seem reasonable" (session_seems_reasonable()
in ephy-session.c).
Expected behaviour
Any typed URL should probably always be percent-encoded properly, or at least replace invalid % encoding (e.g. %s) with %25 (the percent-encoding for the % character), that way everything handling the URIs work fine.
Edited by Vanadiae