Criticals when canceling download initiated by context menu action when "ask on download" setting is enabled
With the "ask on download" setting enabled, right click on an image and save as. Then cancel the filechooser that appears. Then cancel the "ask on download" prompt that appears next (but certainly should not). Crash:
epiphany:ERROR:../../../../Projects/epiphany/embed/ephy-download.c:360:ephy_download_cancel: assertion failed: (EPHY_IS_DOWNLOAD (download))
Bail out! epiphany:ERROR:../../../../Projects/epiphany/embed/ephy-download.c:360:ephy_download_cancel: assertion failed: (EPHY_IS_DOWNLOAD (download))
Backtrace:
#0 __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0)
at pthread_kill.c:44
#1 0x00007f82c0afcea3 in __pthread_kill_internal (signo=6, threadid=<optimized out>) at pthread_kill.c:78
#2 0x00007f82c0aaca16 in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26
#3 0x00007f82c0a9682f in __GI_abort () at abort.c:79
#4 0x00007f82c0ea5388 in g_assertion_message (domain=0x7f82c1c8fa36 "epiphany",
file=0x7f82c1c8f9c8 "../../../../Projects/epiphany/embed/ephy-download.c", line=360,
func=0x7f82c1c90030 <__func__.8> "ephy_download_cancel",
message=0x5cdb410 "assertion failed: (EPHY_IS_DOWNLOAD (download))")
at ../../../../Projects/glib/glib/gtestutils.c:3246
#5 0x00007f82c0ea540a in g_assertion_message_expr (domain=0x7f82c1c8fa36 "epiphany",
file=0x7f82c1c8f9c8 "../../../../Projects/epiphany/embed/ephy-download.c", line=360,
func=0x7f82c1c90030 <__func__.8> "ephy_download_cancel", expr=0x7f82c1c8fa3f "EPHY_IS_DOWNLOAD (download)")
at ../../../../Projects/glib/glib/gtestutils.c:3272
#6 0x00007f82c1c4a080 in ephy_download_cancel (download=0x183c8f0)
at ../../../../Projects/epiphany/embed/ephy-download.c:360
#7 0x00007f82c1c4af39 in filename_suggested_dialog_cb (dialog=0xcb48e0, response=GTK_RESPONSE_CANCEL, data=0x50fa960)
at ../../../../Projects/epiphany/embed/ephy-download.c:776
#8 0x00007f82c0f84764 in g_cclosure_marshal_VOID__INTv (closure=0x49ca5d0, return_value=0x0, instance=0xcb48e0,
args=0x7ffe204f87e8, marshal_data=0x0, n_params=1, param_types=0x293d8b0)
at ../../../../Projects/glib/gobject/gmarshal.c:596
#9 0x00007f82c0f80a99 in _g_closure_invoke_va (closure=0x49ca5d0, return_value=0x0, instance=0xcb48e0,
args=0x7ffe204f87e8, n_params=1, param_types=0x293d8b0) at ../../../../Projects/glib/gobject/gclosure.c:893
#10 0x00007f82c0f9e888 in g_signal_emit_valist (instance=0xcb48e0, signal_id=534, detail=0, var_args=0x7ffe204f87e8)
at ../../../../Projects/glib/gobject/gsignal.c:3407
#11 0x00007f82c0f9fb3a in g_signal_emit (instance=0xcb48e0, signal_id=534, detail=0)
at ../../../../Projects/glib/gobject/gsignal.c:3554
#12 0x00007f82c13ae546 in gtk_dialog_response (dialog=0xcb48e0, response_id=-6)
at ../../../../Projects/gtk+-3/gtk/gtkdialog.c:1234
#13 0x00007f82c13ac535 in action_widget_activated (widget=0x6c6e880, dialog=0xcb48e0)
at ../../../../Projects/gtk+-3/gtk/gtkdialog.c:320
#14 0x00007f82c0f84062 in g_cclosure_marshal_VOID__VOIDv (closure=0x27d1870, return_value=0x0, instance=0x6c6e880,
args=0x7ffe204f8ce8, marshal_data=0x0, n_params=0, param_types=0x0)
at ../../../../Projects/glib/gobject/gmarshal.c:165
#15 0x00007f82c0f80a99 in _g_closure_invoke_va (closure=0x27d1870, return_value=0x0, instance=0x6c6e880,
args=0x7ffe204f8ce8, n_params=0, param_types=0x0) at ../../../../Projects/glib/gobject/gclosure.c:893
#16 0x00007f82c0f9e888 in g_signal_emit_valist (instance=0x6c6e880, signal_id=301, detail=0, var_args=0x7ffe204f8ce8)
at ../../../../Projects/glib/gobject/gsignal.c:3407
#17 0x00007f82c0f9fb3a in g_signal_emit (instance=0x6c6e880, signal_id=301, detail=0)
at ../../../../Projects/glib/gobject/gsignal.c:3554
#18 0x00007f82c1305d60 in gtk_button_clicked (button=0x6c6e880) at ../../../../Projects/gtk+-3/gtk/gtkbutton.c:1541
#19 0x00007f82c1306889 in gtk_button_do_release (button=0x6c6e880, emit_clicked=1)
at ../../../../Projects/gtk+-3/gtk/gtkbutton.c:1845
#20 0x00007f82c1306c68 in gtk_real_button_released (button=0x6c6e880)
at ../../../../Projects/gtk+-3/gtk/gtkbutton.c:1963
#21 0x00007f82c0f84062 in g_cclosure_marshal_VOID__VOIDv (closure=0xc4fce0, return_value=0x0, instance=0x6c6e880,
args=0x7ffe204f9278, marshal_data=0x7f82c1306bfc <gtk_real_button_released>, n_params=0, param_types=0x0)
at ../../../../Projects/glib/gobject/gmarshal.c:165
#22 0x00007f82c0f80f46 in g_type_class_meta_marshalv (closure=0xc4fce0, return_value=0x0, instance=0x6c6e880,
args=0x7ffe204f9278, marshal_data=0x3f8, n_params=0, param_types=0x0)
at ../../../../Projects/glib/gobject/gclosure.c:1058
#23 0x00007f82c0f80a99 in _g_closure_invoke_va (closure=0xc4fce0, return_value=0x0, instance=0x6c6e880,
--Type <RET> for more, q to quit, c to continue without paging--c
args=0x7ffe204f9278, n_params=0, param_types=0x0) at ../../../../Projects/glib/gobject/gclosure.c:893
#24 0x00007f82c0f9e888 in g_signal_emit_valist (instance=0x6c6e880, signal_id=300, detail=0, var_args=0x7ffe204f9278) at ../../../../Projects/glib/gobject/gsignal.c:3407
#25 0x00007f82c0f9fb3a in g_signal_emit (instance=0x6c6e880, signal_id=300, detail=0) at ../../../../Projects/glib/gobject/gsignal.c:3554
#26 0x00007f82c1303760 in multipress_released_cb (gesture=0x19209c0, n_press=1, x=75, y=26, widget=0x6c6e880) at ../../../../Projects/gtk+-3/gtk/gtkbutton.c:666
#27 0x00007f82c12a85af in _gtk_marshal_VOID__INT_DOUBLE_DOUBLEv (closure=0x1858160, return_value=0x0, instance=0x19209c0, args=0x7ffe204f9798, marshal_data=0x0, n_params=3, param_types=0x958ba0) at gtk/gtkmarshalers.c:4804
#28 0x00007f82c0f80a99 in _g_closure_invoke_va (closure=0x1858160, return_value=0x0, instance=0x19209c0, args=0x7ffe204f9798, n_params=3, param_types=0x958ba0) at ../../../../Projects/glib/gobject/gclosure.c:893
#29 0x00007f82c0f9e888 in g_signal_emit_valist (instance=0x19209c0, signal_id=255, detail=0, var_args=0x7ffe204f9798) at ../../../../Projects/glib/gobject/gsignal.c:3407
#30 0x00007f82c0f9fb3a in g_signal_emit (instance=0x19209c0, signal_id=255, detail=0) at ../../../../Projects/glib/gobject/gsignal.c:3554
#31 0x00007f82c142c2b0 in gtk_gesture_multi_press_end (gesture=0x19209c0, sequence=0x0) at ../../../../Projects/gtk+-3/gtk/gtkgesturemultipress.c:287
#32 0x00007f82c0f859e2 in g_cclosure_marshal_VOID__BOXEDv (closure=0x9bf300, return_value=0x0, instance=0x19209c0, args=0x7ffe204f9d08, marshal_data=0x7f82c142c1de <gtk_gesture_multi_press_end>, n_params=1, param_types=0x9bf330) at ../../../../Projects/glib/gobject/gmarshal.c:1686
#33 0x00007f82c0f80f46 in g_type_class_meta_marshalv (closure=0x9bf300, return_value=0x0, instance=0x19209c0, args=0x7ffe204f9d08, marshal_data=0x108, n_params=1, param_types=0x9bf330) at ../../../../Projects/glib/gobject/gclosure.c:1058
#34 0x00007f82c0f80a99 in _g_closure_invoke_va (closure=0x9bf300, return_value=0x0, instance=0x19209c0, args=0x7ffe204f9d08, n_params=1, param_types=0x9bf330) at ../../../../Projects/glib/gobject/gclosure.c:893
#35 0x00007f82c0f9e888 in g_signal_emit_valist (instance=0x19209c0, signal_id=247, detail=0, var_args=0x7ffe204f9d08) at ../../../../Projects/glib/gobject/gsignal.c:3407
#36 0x00007f82c0f9fb3a in g_signal_emit (instance=0x19209c0, signal_id=247, detail=0) at ../../../../Projects/glib/gobject/gsignal.c:3554
#37 0x00007f82c1427337 in _gtk_gesture_set_recognized (gesture=0x19209c0, recognized=0, sequence=0x0) at ../../../../Projects/gtk+-3/gtk/gtkgesture.c:346
#38 0x00007f82c142744e in _gtk_gesture_check_recognized (gesture=0x19209c0, sequence=0x0) at ../../../../Projects/gtk+-3/gtk/gtkgesture.c:387
#39 0x00007f82c14280c5 in gtk_gesture_handle_event (controller=0x19209c0, event=0x3ddb350) at ../../../../Projects/gtk+-3/gtk/gtkgesture.c:784
#40 0x00007f82c142e478 in gtk_gesture_single_handle_event (controller=0x19209c0, event=0x3ddb350) at ../../../../Projects/gtk+-3/gtk/gtkgesturesingle.c:222
#41 0x00007f82c13d7a3d in gtk_event_controller_handle_event (controller=0x19209c0, event=0x3ddb350) at ../../../../Projects/gtk+-3/gtk/gtkeventcontroller.c:230
#42 0x00007f82c167f82b in _gtk_widget_run_controllers (widget=0x6c6e880, event=0x3ddb350, phase=GTK_PHASE_BUBBLE) at ../../../../Projects/gtk+-3/gtk/gtkwidget.c:7447
#43 0x00007f82c167f094 in gtk_widget_real_button_event (widget=0x6c6e880, event=0x3ddb350) at ../../../../Projects/gtk+-3/gtk/gtkwidget.c:7208
#44 0x00007f82c129fa9f in _gtk_marshal_BOOLEAN__BOXEDv (closure=0x8b9dd0, return_value=0x7ffe204fa270, instance=0x6c6e880, args=0x7ffe204fa408, marshal_data=0x7f82c167f06c <gtk_widget_real_button_event>, n_params=1, param_types=0x89dae0) at gtk/gtkmarshalers.c:130
#45 0x00007f82c0f80f46 in g_type_class_meta_marshalv (closure=0x8b9dd0, return_value=0x7ffe204fa270, instance=0x6c6e880, args=0x7ffe204fa408, marshal_data=0x188, n_params=1, param_types=0x89dae0) at ../../../../Projects/glib/gobject/gclosure.c:1058
#46 0x00007f82c0f80a99 in _g_closure_invoke_va (closure=0x8b9dd0, return_value=0x7ffe204fa270, instance=0x6c6e880, args=0x7ffe204fa408, n_params=1, param_types=0x89dae0) at ../../../../Projects/glib/gobject/gclosure.c:893
#47 0x00007f82c0f9e888 in g_signal_emit_valist (instance=0x6c6e880, signal_id=114, detail=0, var_args=0x7ffe204fa408) at ../../../../Projects/glib/gobject/gsignal.c:3407
#48 0x00007f82c0f9fb3a in g_signal_emit (instance=0x6c6e880, signal_id=114, detail=0) at ../../../../Projects/glib/gobject/gsignal.c:3554
#49 0x00007f82c16802bf in gtk_widget_event_internal (widget=0x6c6e880, event=0x3ddb350) at ../../../../Projects/gtk+-3/gtk/gtkwidget.c:7812
#50 0x00007f82c167f67a in gtk_widget_event (widget=0x6c6e880, event=0x3ddb350) at ../../../../Projects/gtk+-3/gtk/gtkwidget.c:7382
#51 0x00007f82c14993dc in propagate_event_up (widget=0x6c6e880, event=0x3ddb350, topmost=0x0) at ../../../../Projects/gtk+-3/gtk/gtkmain.c:2588
#52 0x00007f82c14996c2 in propagate_event (widget=0x6c6e880, event=0x3ddb350, captured=0, topmost=0x0) at ../../../../Projects/gtk+-3/gtk/gtkmain.c:2691
#53 0x00007f82c14997a3 in gtk_propagate_event (widget=0x6c6e880, event=0x3ddb350) at ../../../../Projects/gtk+-3/gtk/gtkmain.c:2725
#54 0x00007f82c1498347 in gtk_main_do_event (event=0x3ddb350) at ../../../../Projects/gtk+-3/gtk/gtkmain.c:1921
#55 0x00007f82c0839d65 in _gdk_event_emit (event=0x3ddb350) at ../../../../Projects/gtk+-3/gdk/gdkevents.c:73
#56 0x00007f82c08843bc in gdk_event_source_dispatch (base=0x871ad0, callback=0x0, data=0x0) at ../../../../Projects/gtk+-3/gdk/wayland/gdkeventsource.c:124
#57 0x00007f82c0e7226d in g_main_dispatch (context=0x808420) at ../../../../Projects/glib/glib/gmain.c:3413
#58 0x00007f82c0e731c0 in g_main_context_dispatch (context=0x808420) at ../../../../Projects/glib/glib/gmain.c:4131
#59 0x00007f82c0e733ac in g_main_context_iterate (context=0x808420, block=1, dispatch=1, self=0x8004c0) at ../../../../Projects/glib/glib/gmain.c:4207
#60 0x00007f82c0e73470 in g_main_context_iteration (context=0x808420, may_block=1) at ../../../../Projects/glib/glib/gmain.c:4272
#61 0x00007f82c10eb85a in g_application_run (application=0x82a240, argc=1, argv=0x7ffe204fab08) at ../../../../Projects/glib/gio/gapplication.c:2569
#62 0x0000000000404bb7 in main (argc=1, argv=0x7ffe204fab08) at ../../../../Projects/epiphany/src/ephy-main.c:436