Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • Eye of GNOME Eye of GNOME
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 104
    • Issues 104
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 16
    • Merge requests 16
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • Eye of GNOMEEye of GNOME
  • Merge requests
  • !47

Fix selection when one image is in the gallery we rename it and add buttons for scrolling up and down.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Krifa75 requested to merge Ordissimo/eog:zoom-thumbnails into master Mar 09, 2020
  • Overview 0
  • Commits 78
  • Pipelines 24
  • Changes 41

When there are only one image in the gallery and we rename it, the image disappears.

The commit 6e2f1276 handle this case by adding the event G_FILE_MONITOR_EVENT_RENAMED in the monitors.

Without this event, the monitor delete it first, which that make the selection disappears, and after create it but without selecting it.

Also, at the call of the insertion the row is still empty so we cannot select the image.

Concerning the commit 6a4c67e9, I saw when we change the position of the gallery to left or right, there are no buttons anymore.

This feature add this buttons. It seems GTK_TEXT_DIR_LTR and GTK_TEXT_DIR_RTL works well too for scrolling up and down.

Please see the commit for more details.

Edited Oct 19, 2020 by Krifa75
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: zoom-thumbnails