Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • Eye of GNOME Eye of GNOME
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 104
    • Issues 104
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 16
    • Merge requests 16
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • Eye of GNOMEEye of GNOME
  • Merge requests
  • !39

EogScrollView: Guard against attempting to create a surface using an invalid size

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Michael Webster requested to merge miketwebster/eog:size-xerror into master Jan 06, 2020
  • Overview 4
  • Commits 1
  • Pipelines 2
  • Changes 1

Return an empty surface if this happens, and log a warning.

trace: gdb.log

demo jpeg: test.jpg

This might not be the best way to handle this, but it seemed the simplest - let me know if you want it done differently, or just disregard the patch, as I mainly just wanted to point out the issue. I'm not sure whether any sort of user notification would be warranted here or not.

Edited Feb 09, 2020 by Felix Riemann
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: size-xerror