Skip to content

misplaced parenthesis causes incorrect bezier tolerance test

John Robertson requested to merge ergohack/dia:bezier-curve-parenthesies into master

Debugging I saw that the " > tolerance" was inside the fabs() function instead of outside of it.
Effectively: fabs( first - (boolean)(last > tolerance)), which will most always be true.
Correcting the parenthesis, puts the test correctly fabs( first - last ) > tolerance, which will actually test the length above or below the "tolerance".

Edited by John Robertson

Merge request reports

Loading