properties dialog creates empty undo actions when no properties are changed
Submitted by Sameer D. Sahasrabuddhe
Assigned to Sameer D. Sahasrabuddhe
Link to original bug (#488269)
Description
Please describe the problem: The properties dialog has three buttons: Close, Apply and OK. Their behaviour can cause empty Change objects in the Undo stack, when no properties are changed between subsequent button-presses. This is because the function that handles the response to this dialog does not check whether any properties have actually been changed.
- If you don't change any property and press "Apply" or "OK", the dialog still creates an empty action on the undo stack.
- If you change some properties and press "Apply" followed by "OK", the undo stack is updated twice, where the effect of the "OK" button-press is empty.
- If you press "Apply" multiple times, it updates the undo stack every time, although only the first attempt is the only one that could have caused any change in properties.
Steps to reproduce:
Actual results:
Expected results:
Does this happen every time?
Other information:
Version: CVS head