Tests fail if compiled with G_DISABLE_ASSERT
Looks like test suite is a bit useless on building release/prod binaries:
/usr/bin/make check-local make[2]: Entering directory '/home/tkloczko/rpmbuild/BUILD/cheese-3.31.90' MALLOC_CHECK_=2 MALLOC_PERTURB_=$((${RANDOM:-256} % 256)) /usr/bin/gtester --verbose tests/test-libcheese tests/test-libcheese-gtk TEST: tests/test-libcheese... (pid=28277) /libcheese/cameradevicemonitor/create: OK /libcheese/effect/create: OK /libcheese/fileutil/new_media_filename: OK /libcheese/fileutil/photo_path: OK /libcheese/fileutil/video_path: OK /libcheese/videoformat/create: OK PASS: tests/test-libcheese TEST: tests/test-libcheese-gtk... (pid=28333) Tests were compiled with G_DISABLE_ASSERT and are likely no-ops. Aborting. FAIL: tests/test-libcheese-gtk
BTW using g_assert(). Note from glib source code from glib/gtestutil.c:
* Note that g_assert() should not be used in unit tests, since it is a no-op * when compiling with `G_DISABLE_ASSERT`. Use g_assert() in production code, * and g_assert_true() in unit tests.
Edited by Daniel Boles