Skip to content

Let provider plugin decide whether to automatically hang up secondary calls

Evangelos Ribeiro Tzaras requested to merge devrtz/calls:wip/dummy-calls into master

Revert "manager: hang up secondary calls"

This reverts commit 94345e09 and moves that functionality to the ModemManager plugin.

Fixes #290 (closed)

This will allow a) playing around with multiple calls using the dummy provider b) the SIP plugin to deal with multiple calls

I've tested this with the devices I have at hand:

  • L5 running PureOS: Rejecting the secondary call will tear down the first call - this is fixed in newer MM. But since we're currently autorejecting anyway I'd say this is an improvement even without newer MM because the user at least has the option of letting it ring indefinitely (which uses the "quiet" feedbackd profile, so that should be unintrusive).

  • PP running Mobian: Rejecting the secondary call does not kill the first call, however trying to accept a call does also not work: CallsMMCall[28822]: WARNING: Error accepting ModemManager call to +491XXXXXXXXX': GDBus.Error:org.freedesktop.ModemManager1.Error.Core.Failed: This call was not ringing, cannot accept`

Merge request reports