Skip to content

rework ringer to allow silencing

The main motivation for this refactor was to easily allow silencing a ringing call.

Furthermore it should fix #339 (closed), although that is hard to test as I've never encountered the issue myself. Also I would've expected this issue to also show up with phosh as a DBus consumer (and not necessarily only when hanging up, possibly also when answering a call).

So in short I hope reworking the ringer helps alleviate issues related to ringing:

Furthermore the ringer should be covered with some testing (increasing code coverage by a whooping 3% :p ).

Edited by Evangelos Ribeiro Tzaras

Merge request reports