Remove unused code path from atspi_register_device_event_listener() down
From a chat today (this is a reminder for myself for what to do next week):
It turns out that impl_get_device_event_listeners()
iterates through controller->key_listeners
, but calls append_mouse_listener()
for each of them. I thought, no problem, maybe it's just a cut&paste error because it should iterate through controller->mouse_listeners
instead.
But then I thought, how come this was never caught? who calls that method? It's from atk-adaptor/bridge.c
. So then I thought, okay, who registers device event listeners, which if I'm reading correctly are mouse event listeners?
But atspi_register_device_event_listener()
is not called anywhere. pyatspi2 even has self.device_event_register = None
in registry.py
.
Look at mouse_review.py in orca and atspi_event_listener_register instead.
I think we can remove everything from atspi_register_device_event_listener()
down.