Consider deprecating the popup-menu role
We have a popup menu role with the following definition:
* @ATSPI_ROLE_POPUP_MENU: A temporary window that is usually used to offer the
* user a list of choices, and then hides when the user selects one of those
* choices.
We also have a menu role with the following definition:
* @ATSPI_ROLE_MENU: An object usually found inside a menu bar that contains a
* list of actions the user can choose from.
Until recently, I had been unaware of the former because everyone uses the latter -- except, it turns out, Qt, which uses it even for menus that are in a menu bar. See orca#443.
Orca already has logic to handle popup-menus with the "menu" role (e.g. context/right-click menus). And that logic is not particular cumbersome. So unless there's a good reason to keep the AT-SPI popup-menu role around, I propose we deprecate it and update the definition of the "menu" role to remove mention of menu bars. Menus are menus. Period.