Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • NetworkManager-openvpn NetworkManager-openvpn
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 40
    • Issues 40
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 3
    • Merge requests 3
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • NetworkManager-openvpnNetworkManager-openvpn
  • Merge requests
  • !65

service: fix automatically adding "cipher" to "data-ciphers""

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Thomas Haller requested to merge th/cipher2 into main Nov 29, 2022
  • Overview 4
  • Commits 1
  • Pipelines 3
  • Changes 1

First, the "data-ciphers" in openvpn defaults (depending on version and compile time configuration) to "AES-256-GCM:AES-128-GCM" or "AES-256-GCM:AES-128-GCM:CHACHA20-POLY1305". So taking "cipher" and just set it as "--data-ciphers $CIPHER" is wrong. When doing this compat work, we will now set "--data-ciphers" to "X:AES-256-GCM:AES-128-GCM". This should work, and if it's not suitable to the user, they still can set "data-ciphers" explicitly.

Also, when we do the compat works, it's wrong to still set "--cipher" to whatever it was. Instead, only set "--data-ciphers" for 2.5 and newer.

#112 (closed)

Fixes: 020ab0c4 ('service: automatically add the "cipher" to the "data-ciphers"')


This is an alternative to !64 (merged)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: th/cipher2