Skip to content

Several cleanups related to search

Pablo Correa Gomez requested to merge cleanups-to-search into main

Unfortunately, within the simple cleanups one more complicated commit slipped:

shell: reorganize actions for PpsWindow

Before this commit, all the PpsWindow actions had the "win"
prefix. However, not all of them had global shortcuts in
PpsApplication. It turns out, many of these actions do not correspond
to the window, but to individual documents in the document view. For
now, these are actually the same. There is one document per Papers
process. In out work towards fixing that, we need to make sure that
the actions belong to each document. This should also simplify the
split between PpsWindow and PpsDocumentView that we are working
towards.

TODO:
- Actually move the shortcuts
- Move more actions

@crab2313 I guess this is part of what we talked related to the actions the other day. What do you think?

There's also one small behavior change, which is that now if there is one or no results, the find-next and find-previous buttons in the search bar are still sensitive. I'd say this is certainly not a huge deal, but maybe some people have opinions

@camelCaseNick in case you want to have a look at this, since you've touched parts of this code recently

Merge request reports