Move logic in PpsView related to the find job to PpsView, and stop PpsWindow from passing things around
This would require moving PpsSearchContext
to libview
, which should include properly documenting the class. The main goal is to stop passing the PpsFindJob
in the finished
signal of the context, and make it possible for PpsWindow
to only be in charge of calling "_set_search_context" in the init, and that's it. Then everything else would work on top
@camelCaseNick words' related to it:
The remaining signals in PpsWindow are only manipulating the view, so if that had a _set_search_context
as well, the window wouldn't have any business in passing around search context states – as it should be. (It would only remain setting the search term in the find action.)
But then, PpsView's logic around the find job would need to be moved to the search context, as well, to actually remove the job from the signal. The view is the only remaining job user.