Tests failing on Debian Linux
I have a few problems running the tests of libcroco 0.6.13 on Debian Linux 9.
First problem is that two shell scripts are not working because /bin/sh
on Debian links to dash
instead of bash
:
executing test-prop-ident.sh > tests/test-outputs/test-prop-ident.sh.out ...
./tests/test-prop-ident.sh: 3: .: global-test-vars.sh: not found
done
executing test-several-media.sh > tests/test-outputs/test-several-media.sh.out ...
./tests/test-several-media.sh: 3: .: global-test-vars.sh: not found
done
This can be fixed by using . ./global-test-vars.sh
instead of . global-test-vars.sh
in these two scripts. In other shell scripts this was already done.
Second problem are actual test output differences:
diff -ur '--exclude=*CVS*' '--exclude=*cvs*' '--exclude=Makefile*' '--exclude=.arch-ids' ./tests/test-output-refs/test2.1.css.out tests/test-outputs/test2.1.css.out
--- ./tests/test-output-refs/test2.1.css.out 2019-04-06 18:37:03.000000000 +0200
+++ tests/test-outputs/test2.1.css.out 2019-06-20 20:20:42.725511357 +0200
@@ -9,7 +9,7 @@
***************
property
-prop1: "String"
+prop1: "<83>tring"
***************
***************
diff -ur '--exclude=*CVS*' '--exclude=*cvs*' '--exclude=Makefile*' '--exclude=.arch-ids' ./tests/test-output-refs/test2.2.css.out tests/test-outputs/test2.2.css.out
--- ./tests/test-output-refs/test2.2.css.out 2019-04-06 18:37:03.000000000 +0200
+++ tests/test-outputs/test2.2.css.out 2019-06-20 20:20:42.729511312 +0200
@@ -1694,7 +1694,7 @@
***************
property
-line-height: 1.300em
+line-height: 1.3em
***************
***************
@@ -1784,7 +1784,7 @@
***************
property
-margin-left: 1.250em
+margin-left: 1.25em
***************
***************
diff -ur '--exclude=*CVS*' '--exclude=*cvs*' '--exclude=Makefile*' '--exclude=.arch-ids' ./tests/test-output-refs/test4.1.css.out tests/test-outputs/test4.1.css.out
--- ./tests/test-output-refs/test4.1.css.out 2019-04-06 18:37:03.000000000 +0200
+++ tests/test-outputs/test4.1.css.out 2019-06-20 20:20:42.745511135 +0200
@@ -32,14 +32,14 @@
h1.rubrique_info {
color : #990033;
margin : 0px 0px 0px 0px;
- padding : 0.400em;
+ padding : 0.40000000000000002em;
border : 0px;
font-size : 12px
}
h1.connexe {
font-size : 12px;
- padding : 0.900em;
+ padding : 0.90000000000000002em;
margin : 0px 0px 0px 0px;
color : #990033
}
@@ -229,8 +229,8 @@
div.leftbox ul {
list-style-type : square;
margin-bottom : 10px;
- margin-left : 0.300em;
- padding-left : 0.200em
+ margin-left : 0.29999999999999999em;
+ padding-left : 0.20000000000000001em
}
div.leftbox li {
@@ -384,7 +384,7 @@
margin-bottom : 10px;
background-color : #cacaca;
font-size : 12px;
- line-height : 1.300em
+ line-height : 1.3em
}
p.commentsbody {
@@ -405,7 +405,7 @@
ul.commentsul {
list-style-type : none;
margin-bottom : 10px;
- margin-left : 1.250em;
+ margin-left : 1.25em;
padding-left : 0em;
border-left : 1px solid black
}
Most of them look harmless because the same numbers are written in different forms. But this first difference with the "String" looks more serious.
Third problem: Test failures do not affect the return code of make which is kinda bad when running the tests in automatic builds.