Meta-contact class removals and rearrangements
@pwithnall
Submitted by Philip Withnall Link to original bug (#625969)
Description
This can be a meta-bug for tracking which of Empathy's classes need to be removed or majorly changed as a result of the meta-contacts work.
Below are some of my thoughts on various classes. Many of them are the result of only a few minutes' thought, so might not be optimal.
- EmpathyContact:
Currently a thin(ish) wrapper for FolksPersona. It should eventually disappear, but that requires capabilities and location support in libfolks.
- EmpathyContactList
Should perhaps change into an interface for Individuals, rather than contacts.
- EmpathyContactManager
Has been superceded by EmpathyIndividualManager. Should die.
- EmpathySubscriptionDialog
Should be changed to allow linking of the new subscription to existing Individuals.
- EmpathyContactInformationDialog
Has been superceded by EmpathyIndividualInformationDialog in this branch: http://git.collabora.co.uk/?p=user/pwith/empathy;a=shortlog;h=refs/heads/merging-ui-rebase3. Once that's merged, the EmpathyContactInformationDialog should die.
- EmpathyContactEditDialog
Should be replaced by a dialogue which allows editing of the whole Individual.
- EmpathyContactPersonalDialog
Should be replaced by a dialogue which shows the aggregated personal information of the whole Individual.
- EmpathyNewContactDialog
Should be changed to allow linking of the new contact to existing Individuals.
- EmpathyContactListStore
Should be stripped down and turned into an EmpathyPersonaStore, which lists the Personas for a given Individual. I can't think of any use-cases where we'd want the list of all Personas from all Individuals, but there are some cases where we'd want the Personas from a single Individual; such as in the linking dialogue, and when choosing a Persona to chat with or call.
- EmpathyContactListView
Similarly, this should be stripped down (e.g. groups support removed) into an EmpathyPersonaView.
- EmpathyContactMenu
I can't think of any cases where this would be necessary. It's been superceded by EmpathyIndividualMenu, and should be removed.
- EmpathyContactSelector
Should probably be replaced by an EmpathyIndividualSelector, although it's only used in the nautilus-sendto plugin at the moment, so might still need a way to select a Persona from an Individual in order to send files to the correct Persona.
- EmpathyContactSelectorDialog
Similarly, this should probably be replaced by an EmpathyIndividualSelectorDialog, which might need to allow selecting Personas out of Individuals.
- EmpathyContactWidget
This is being superceded by an EmpathyIndividualWidget as part of my work on the linking dialogue. The EmpathyIndividualWidget should allow the display of all the details of the Personas comprising the Individual, so the EmpathyContactWidget should eventually die.
Version: 2.31.x