Hi, the gnome-directory-thumbnailer no longer compiles on GLib 2.61.2 or later (as on my Ubuntu 20.04) because of deprecation warnings that are treated as errors. I attached my suggested fix for that. For me, it compiles again and seems to work. Please have a close look at the modifications. (I am not an experienced GLib programmer) EDIT: updated proposed patch: main.c.diff
Stefan Sichler (89ad7b14) at 25 Feb 16:54
GDateTime* can be NULL and must be unref'd instead of freed
... and 1 more commit
Wait: I was wrong. It compiles again with this change, but it doesn't work. I assume the the timestamp is now incompatible to the gnome desktop thumbnail factory. Investigating... EDIT: The problem was caused by freeing the GDateTime instead of unrefing it. -> Problem solved. Now it works!
I managed to solve the problem by switching from https to ssh.
Since GLib 2.61.2, GTimeVal
is deprecated.
This change replaces it by GDateTime
and fixes issue #7
Note that GTimeVal
was deprecated due to the year 2038 problem of 32bit Unix timestamps (time_t
or tv_sec member of GTimeVal
).
In contrast, GDateTimes
can represent identical longer total timespans on both 32bit and 64bit platforms and can always be converted to/from 64bit Unix timestamps, represented as gint64
.
However, the Gnome Desktop Thumbnailer API still uses time_t
which may still be 32bit on some platforms.
So, although this change now fixes this issue on 64bit platforms having GLib >= 2.62, compiling this code on 32bit platforms may still at least cause compiler warnings.
Fixes: #7
Stefan Sichler (0cc481cf) at 25 Feb 00:05
replace deprecated (GLib>=2.61.2) GTimeVal by GDateTime
If you could turn it into a merge request
No, I can't. Whenever I try to push my changes to my fork in GitLab via https using git push
I get an error: unable to access 'https://gitlab.gnome.org/stsichler/gnome-directory-thumbnailer.git/': The requested URL returned error: 418
error 418 is 'I'm a teapot'.
I'm stopping here.
Hi, the gnome-directory-thumbnailer no longer compiles on GLib 2.61.2 or later (as on my Ubuntu 20.04) because of deprecation warnings that are treated as errors. I attached my suggested fix for that. For me, it compiles again and seems to work. Please have a close look at the modifications. (I am not an experienced GLib programmer) EDIT: updated proposed patch: main.c.diff