1. 01 Apr, 2013 1 commit
  2. 07 Mar, 2013 1 commit
  3. 13 Jan, 2013 1 commit
  4. 30 Nov, 2012 1 commit
  5. 29 Nov, 2012 1 commit
  6. 15 Nov, 2012 1 commit
  7. 10 Apr, 2012 2 commits
    • Will Thompson's avatar
      GDBusMessage: do not align for grandchildren of empty arrays. · 113f4abb
      Will Thompson authored
      D-Bus arrays are serialized as follows:
      
      1. align to a 4-byte boundary (for the length)
      2. uint32: the length of the serialized body in bytes
      3. padding for the alignment of the body type (not included in the length)
      4. the body.
      
      Note that 3. is a no-op unless the body type is an 8-byte aligned type
      (uint64, int64, double, struct, dict_entry), since you are always on a
      4-byte boundary from aligning and writing the length.
      
      So, an empty aax (that is, an array containing zero arrays of int64)
      is serialized as follows:
      
      1. align to a 4-byte boundary
      2. length of the contents of this (empty) array, in bytes (0)
      3. align to a 4-byte boundary (the child array's alignment requirement)
      4. there is no body.
      
      But previously, GDBus would recurse in step three to align not just for
      the type of the child array, but for the nonexistent child array's
      contents. This only affects the algorithm when the grandchild type has
      8-byte alignment and the reader happened to not already be on an 8-byte
      boundary, in which case 4 bytes were spuriously skipped.
      
      https://bugzilla.gnome.org/show_bug.cgi?id=673612Signed-off-by: default avatarDavid Zeuthen <davidz@redhat.com>
      113f4abb
    • Will Thompson's avatar
      e28d3ef9
  8. 05 Apr, 2012 1 commit
  9. 31 Mar, 2012 1 commit
  10. 11 Jan, 2012 1 commit
  11. 21 Oct, 2011 1 commit
    • Allison Karlitskaya's avatar
      GDBusMessage: fix leak of GError · 9c07e7dc
      Allison Karlitskaya authored
      As part of the deserialisation process of a zero-length array in the
      DBus wire format, parse_value_from_blob() recursively calls itself with
      the expectation of failing (as can be seen by the assert immediately
      following).
      
      It passes &local_error to this always-failing call and then fails to
      free it (indeed, to use it at all).  The result is that the GError is
      leaked.
      
      Fix it by passing in NULL instead, so that the GError is never created
      in the first place.
      
      https://bugzilla.gnome.org/show_bug.cgi?id=662411
      9c07e7dc
  12. 27 Aug, 2011 2 commits
  13. 14 Jun, 2011 1 commit
  14. 09 Jun, 2011 1 commit
  15. 27 Apr, 2011 1 commit
  16. 08 Apr, 2011 1 commit
  17. 29 Jan, 2011 1 commit
  18. 12 Nov, 2010 2 commits
  19. 09 Nov, 2010 1 commit
  20. 24 Sep, 2010 1 commit
  21. 09 Sep, 2010 2 commits
  22. 04 Sep, 2010 1 commit
  23. 30 Aug, 2010 1 commit
  24. 28 Aug, 2010 1 commit
  25. 22 Aug, 2010 1 commit
  26. 19 Aug, 2010 1 commit
  27. 17 Aug, 2010 1 commit
  28. 04 Aug, 2010 4 commits
  29. 20 Jul, 2010 1 commit
    • David Zeuthen's avatar
      GDBus: Add support for D-Bus type 'h' (ie. G_VARIANT_TYPE_HANDLE) · 2be167f5
      David Zeuthen authored
      This allows sending and receiving D-Bus messages with instances of the
      'h' D-Bus type. Unlike libdbus-1's dbus_message_iter_get_basic()
      method, g_variant_get_handle() does not return a duplicated unix file
      descriptor (that must be closed with close(2)) - instead, it returns
      an index that can be used to get/dup the file descriptor from a
      GUnixFDList object that can be obtained from the GDBusMessage object.
      Signed-off-by: default avatarDavid Zeuthen <davidz@redhat.com>
      2be167f5
  30. 15 Jul, 2010 1 commit
  31. 14 Jul, 2010 1 commit
  32. 07 Jul, 2010 2 commits