Skip to content
  • Ross Lagerwall's avatar
    gio: Prevent hang when finalizing GThreadedSocketService · 9a6e01ea
    Ross Lagerwall authored and Dan Winship's avatar Dan Winship committed
    If all users of a GThreadedSocketService release their references to the
    service while a connection thread is running, the thread function will
    release the last reference to the service which causes the finalize to
    deadlock waiting for all threads to finish (because it's called from the
    thread function).
    
    To fix this, don't wait for all threads to finish in the service's
    finalize method.  Since the threads hold a reference to the service,
    finalize should only be called when all threads are finished running (or
    have unrefed the service and are about to finish).
    
    https://bugzilla.gnome.org/show_bug.cgi?id=712570
    9a6e01ea