GitLab

If Bluetooth is not available, then it might stall until the requests
times out.  So we do not lose anything by assuming no Bluetooth availability.
If Bluetooth is indeed available, we have a small window in which we
assume Bluetooth is not available while it actually is. But that time
window is relatively small. The requests completes nearly instantly
in a normal setup.

This seems to build a Fedora package:
https://copr.fedorainfracloud.org/coprs/muelli/gnome-keysign/build/759276/

I happily accept patches to make the package better.

Do not show keys which miss the primary key ("offline keys")

pgpdupm shows:

Old: Secret Key Packet(tag 5)(277 bytes)
	Ver 4 - new
	Public key creation time - Tue Feb 13 11:53:57 CET 2018
	Pub alg - RSA Encrypt or Sign(pub 1)
	RSA n(2048 bits) - ...
	RSA e(17 bits) - ...
	Sym alg - Plaintext or unencrypted data(sym 0)
	GnuPG gnu-dummy (s2k 1001)
Old: User ID Packet(tag 13)(16 bytes)

That is, there is no "d" (nor "p" nor "q") which we would need in order
to do anything meaningful with the private key.

Debian recommends placing the master key offline. That requires the
master key to be present for signing other keys.
This change filters those keys whose master key is not present.
In the future we could make our UI a bit nicer by showing the key
somehow in a disabled fashion. We could offer a hint that the user needs
to provide their master key.  But we cannot do it just right now,
because we need to drop monkeysign support first.

`bus.get_object` is a blocking call that in rare cases can take a long
time to complete leading to a very long startup time.
Doing this check with a deferred thread solves this problem

Otherwise they might be opened as ascii, leading to a UnicodeDecodeError.

Even if this bug github.com/hughsie/appstream-glib#209 should have been
resolved, it seems that for us it still gives problems.
Until it is sorted out, we simply use the `.desktop` suffix also in the
id tag.

We work around this bug:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=884900

It's been reported and patched here:
https://lists.gnupg.org/pipermail/gnupg-devel/2018-February/033458.html

There is a small script to reproduce here:
https://lists.gnupg.org/pipermail/gnupg-devel/2018-March/033564.html

When the user does not provide arguments the error message is not really
telling much.  This change intends to make the error message more clear
and instruct the user what to do to make it work.

Defered failurein discover.py was causing "Unhandled error in
Deferred", chained addCallback() and addErrback() method to  handle
sucess and failure.

Also added success_callback and failure_callback in Discover class to
log debug messages and handle the sucess result and failure response.

Fixes https://github.com/gnome-keysign/gnome-keysign/issues/42

We get this error when pybluez is not installed.

I think we need twisted now for the Bluetooth functionality.

The flatpak version currently suffers from an issue in Pipewire.  Let's
leave a public note so that people know where to complain to.

It doesn't seem to make much sense to have this in order to fix the SuSE
build bot, but we can try, at least...

This is an attempt at updating the README a little bit.

I removed the reference to Monkeysign, because it does, too, use
xdg-email when requested.
The list of features already lists "Internet connection", knowing that
we will have Magic Wormhole support soon.

This is inspired by
https://github.com/gnome-keysign/gnome-keysign/issues/30

util: fix TypeError when we try to sign with Bluetooth

If we use Bluetooth as the transfer method the signing process will fail
with the following trace:

Traceback (most recent call last):
  File "/tmp/gnome-keysign/keysign/receive.py", line 155, in on_sign_key_confirmed
    sign_keydata_and_send(keydata))
  File "/tmp/gnome-keysign/keysign/util.py", line 127, in sign_keydata_and_send
    for uid, encrypted_key in list(sign_keydata_and_encrypt(keydata, error_cb)):
  File "/tmp/gnome-keysign/keysign/gpgmeh.py", line 406, in sign_keydata_and_encrypt
    ctx.op_import(minimise_key(keydata))
  File "/tmp/gnome-keysign/keysign/gpgmeh.py", line 380, in minimise_key
    ctx.op_import(keydata)
  File "/usr/lib/python2.7/site-packages/gpg/core.py", line 132, in _funcwrap
    result = func(slf.wrapped, *args)
TypeError: arg 2: expected gpg.Data, file, or an object implementing the buffer protocol, got unicode

To prevent this error we simply try to encode keydata before the import.

So that we can use older agents on the host.