Commit 708b5afc authored by Tristan Van Berkom's avatar Tristan Van Berkom
Browse files

Fix broken hash table maintenence in glade_widget_remove_property() (bug


	* gladeui/glade-widget.c: Fix broken hash table maintenence in 
	glade_widget_remove_property() (bug 575885).


svn path=/trunk/; revision=2177
parent 8f288134
......@@ -2,7 +2,10 @@
* gladeui/glade-command.c: Fix win32 crasher (bug 575206) again (seems
I missed it was klass->name that was null, fixed it so it would never
be null, and added g_assert() where the crash was
be null, and added g_assert() where the crash was.
* gladeui/glade-widget.c: Fix broken hash table maintenence in
glade_widget_remove_property() (bug 575885).
2009-03-21 Tristan Van Berkom <tvb@gnome.org>
......
......@@ -622,9 +622,14 @@ glade_widget_remove_property (GladeWidget *widget,
g_return_if_fail (GLADE_IS_WIDGET (widget));
g_return_if_fail (id_property);
/* XXX FIXME: currently we arent calling this on packing properties,
* but doing so could cause crashes because the hash table is not
* managed properly
*/
if ((prop = glade_widget_get_property (widget, id_property)) != NULL)
{
widget->properties = g_list_remove (widget->properties, prop);
g_hash_table_remove (widget->props_hash, prop->klass->id);
g_object_unref (prop);
}
else
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment