GitLab

Rafael Fontenelle authored Sep 11, 2019 and Administrator committed Sep 11, 2019

(cherry picked from commit 6c261d55)

Veerasamy Sevagen authored Sep 11, 2019 and Robert Ancell committed Sep 11, 2019

The issue was that sometimes the icon would show an error but we would not know what it is.

Fixes #468

Ting-Wei Lan authored Aug 29, 2019 and Georges Basile Stavracas Neto committed Sep 10, 2019

On FreeBSD, the default full name of a user is 'User &'. The '&'
character included in the name is expected to be replaced with the login
name when it is displayed on the user interface. However, it seems that
AccountsService doesn't know it. It just returns 'User &' to the caller,
and it causes the markup to be broken in the user panel.

Ting-Wei Lan authored Aug 29, 2019 and Georges Basile Stavracas Neto committed Sep 10, 2019

FreeBSD has no standalone 'usermod' command. Most user and group
management functions are provided as subcommands of 'pw' tool.

Ting-Wei Lan authored Aug 29, 2019 and Georges Basile Stavracas Neto committed Sep 10, 2019

Otherwise, it causes warnings to be shown on the terminal when it is
used and quickly leads to a crash.

Ting-Wei Lan authored Aug 29, 2019 and Georges Basile Stavracas Neto committed Sep 10, 2019

Otherwise, the compiler may treat WIFEXITED and WEXITSTATUS as implicit
declarations of functions and cause linking to fail.

Florian Müllner authored Jun 15, 2019 and Georges Basile Stavracas Neto committed Sep 10, 2019

Mutter supports the 'Above_Tab' fake keysym that refers to the key
that is physically located above the tab key. It is used in the default
shortcut of the "Switch windows of an application" action.

As gtk_accelerator_parse() doesn't recognize the keysym, we display
the shortcut incorrectly as "disabled", and it is not taken into account
for conflict resolution.

Address this by translating binding that contains the 'Above_Tab' string
to bindings where the string is replaced with each possible keysym that
corresponds to the fixed keycode of KEY_GRAVE + 8.

GNOME/gnome-control-center#581

Georges Basile Stavracas Neto authored Sep 09, 2019 and Benjamin Berg committed Sep 10, 2019

Replace the custom and deprecated CC_DISPLAY_*_GET_PRIVATE by
the automatically generated cc_display_*_get_instance_private
functions.

Robert Ancell authored Nov 23, 2018 and Robert Ancell committed Sep 10, 2019

It is removed in GTK+ 4

Carlos Garnacho authored Apr 24, 2019 and Robert Ancell committed Sep 09, 2019

And add markers for those. We only allow a total of 7 fixed pressure curve
values, so make the UI clear about it.

Closes: GNOME/gnome-control-center#483

This is useful for 2 cases:
- Tablet-input-driven setups where it makes sense to be able to quickly
  reach other monitors with the tablet.
- (Hopefully a minority) Cases where our display mapping heuristics go
  wrong and tablet gets assigned to a wrong monitor.

Closes: GNOME/gnome-control-center#239

Jonathan Kang authored Feb 20, 2019 and Robert Ancell committed Sep 09, 2019

Previously, when you open the connection editor dialog for each
connection, no matter whether you've made any changes or not, the
"Apply" button became sensetive, which is not what we expected.

Fix that by removing the unnecessary call to password_storage_changed()
while constructing the security tab.

Due to an API bug in GNOME Online Accounts, the asynchronous
goa_provider_get_all method doesn't accept a GCancellable argument. This makes
it difficult to cancel an ongoing call when the CcGoaPanel gets destroyed.

This was hacked around by taking a reference on the panel for the duration of
the call. Instead of cancelling a pending call on destruction, it would keep the
panel alive until the call was over.

The hack does not consider the case get_all_providers_cb is called while the
panel is still being initialized. E.g. this happen when create the panel passing
the paramenters "add <provider>" because the constuct properties are set just
after cc_goa_panel_init returns and because goa_provider_add_account will result
in a call to g_main_context_iterate (caused by gtk_dialog_run).

In order to work around this we can call goa_provider_get_all in _constructed()
after all construct properties have been set.

GNOME/gnome-control-center#401

Adrien Plazas authored Jan 27, 2019 and Robert Ancell committed Sep 09, 2019

This factorizes the row creation a bit and normalizes the margins and
spacing, reducing the required width. This also makes labels like row
titles and descriptions ellipsizable so the rows can reach narrower
widths.

Adrien Plazas authored Jan 27, 2019 and Robert Ancell committed Sep 09, 2019

This allows the window to reach narrower sizes.