Pranjay Pathak (c3e06e81) at 27 Apr 11:45
feat: Enforce GNOME commit guidelines
Sure if the gifs are not needed then we should close this MR.
But regarding the MR 39!(it added the old code).
collapsable-search was using "display: none/block" property causing it to shift other elements around it whenever clicked, that's why I changed the component in MR 30.
MR 39! resolved the duplicate issue but the component was still the old one, but no worries on rebase issue. I will just add the missing changes in new MR.
Pranjay Pathak (aa8cd0ad) at 13 Apr 15:54
added Gifs of 'search-input' and 'collapsable-search-input'
@cwunder can I start working on the tables, are the mockups ok (except the color-shades)?
I have taken the color from the color-pallete (shade-200 of respective colors), but there are just too many shades, thats why I was thinking to specify some standard color shades in the pallet, we were discussing the same issue in here
danger, warning ,info etc, are some standard colors required at many places (other then alerts)
yes, but not by changing their class name but only adding the name in the docs (for specific shades)
maybe, adding a color-theme section in the docs/preflight/color with [name - color shade]
Hey, what do you guys thinking of adding some standard theme colors in the library coz I also encountered the color template for alert, info..etc in mockups of tables, I think we should standardise some color-templates for that.(Something like this)
hello @Chenriksen @cwunder, the evaluation of tables is complete and I've also added the mockups for review .
Sure, I'll document the mockups ASAP :)
I think issues in !37 (closed) and !38 (closed) are due to some rebase issue in them or some previous MR, not sure? but currently, the search-input section of docs is mixed up with 2 types of code, the Component is of old code (we had when using Hugo)
but in its code snippet, I am seeing the new code (merged in MR after Jekyll was added).
the collapsable-search component is an old one but its code snippet is new. IDK how that happened maybe some glitch while rebasing?
Pranjay Pathak (9ea816c9) at 03 Apr 17:50
moved 'favicon.ico' to documents
Pranjay Pathak (24329e19) at 03 Apr 17:46
moved favicon to assets and added its location in '_config.yml'