ChangeLog 1.85 MB
Newer Older
1 2 3 4 5 6
2004-03-03  Michael Natterer  <mitch@gimp.org>

	* app/widgets/gimpcolormapeditor.c (gimp_colormap_editor_class_init):
	GDK_TYPE_MODIFIER_TYPE are flags, not enum values, use the
	right marshaller for the "selected" signal.

7 8 9 10 11 12
2004-03-03  Michael Natterer  <mitch@gimp.org>

	* app/widgets/gimppreviewrendererimagefile.[ch]: moved the
	(disabled) ENABLE_FILE_SYSTEM_ICONS from the .c to the .h file and
	#ifdef the "gpointer file_system" member with it.

13 14 15 16 17 18 19 20
2004-03-03  Simon Budig  <simon@gimp.org>

	* app/vectors/gimpvectors.c: fixed offset handling. Vectors
	objects always have 0,0 as offsets and image->width,
	image->height as their dimensions.

	Fixes bug #135994.

21 22 23 24 25 26 27 28 29 30 31 32 33 34
2004-03-03  Michael Natterer  <mitch@gimp.org>

	* libgimpthumb/gimpthumb-utils.[ch] (gimp_thumb_file_test):
	return the "errno" of a failed stat() call.

	* libgimpthumb/gimpthumbnail.[ch]: added member
	"image_not_found_errno" which contains the errno as returned by
	gimp_thumb_file_test() if thumbnail->image_state is
	GIMP_THUMB_STATE_NOT_FOUND.

	* app/core/gimpimagefile.c (gimp_imagefile_get_desc_string): display
	the real error as specified by thumbnail->image_not_found_errno
	instead of just "Could not open".

35 36 37 38 39 40 41 42 43 44
2004-03-03  Michael Natterer  <mitch@gimp.org>

	* app/widgets/Makefile.am
	* app/widgets/widgets-types.h
	* app/widgets/gimppreviewrendererimagefile.[ch]: added new preview
	renderer class (has some disabled code from my GtkFileChooser tree
	and behaves exactly as the default implementation).

	* app/widgets/gimppreviewrenderer-utils.c: use it for GimpImagefiles.

45 46 47 48 49
2004-03-02  Manish Singh  <yosh@gimp.org>

	* plug-ins/pygimp/gimpfu.py: Disable PF_*ARRAY for now. Addresses
	#122049.

50 51 52 53 54 55
2004-03-02  Michael Natterer  <mitch@gimp.org>

	* app/tools/gimpeditselectiontool.c
	* app/widgets/gimplayertreeview.c: compress undo steps only
	if the redo stack is empty.

56 57 58 59 60 61
2004-03-02  Pedro Gimeno  <pggimeno@wanadoo.es>

	* plug-ins/common/bumpmap.c (bumpmap): Fix handling of positive Y
	displacements of the bumpmap. Thanks to Joao S.O. Bueno for
	tracking this. Fixes bug #135866.

62 63 64 65 66 67
2004-03-01  Manish Singh  <yosh@gimp.org>

	* configure.in: define a gimp_stable symbol based on the version
	number (to complement gimp_unstable) and use it as a default for
	--enable-default-binary.

68 69 70 71
2004-03-01  Sven Neumann  <sven@gimp.org>

	* app/config/test-config.c: added simple test for gimp_config_diff().

72 73 74 75 76 77 78 79 80 81 82 83 84
2004-03-01  Michael Natterer  <mitch@gimp.org>

	* app/widgets/gimpfiledialog.[ch] (gimp_file_dialog_set_uri):
	new function which configures the dialog to load an image.

	* app/gui/file-open-dialog.c: use it. Don't use file-dialog-utils
	any more and allow setting the uri of an already visible file open
	dialog.

	* app/gui/file-dialog-utils.c: took the file open menu entries out
	of that insane logic that makes the menus insensitive while any
	file dialog is open.

85 86 87 88 89 90 91 92 93 94
2004-03-01  Michael Natterer  <mitch@gimp.org>

	* app/widgets/gimpfiledialog.[ch] (gimp_file_dialog_set_image): 
	new function which configures the dialog to save an image.

	* app/gui/file-save-dialog.c: use it.

	* app/gui/file-open-dialog.c
	* app/gui/file-save-dialog.c: removed useless #inlcudes.

95 96 97 98 99 100 101 102
2004-03-01  Michael Natterer  <mitch@gimp.org>

	* app/widgets/gimpfiledialog.[ch] (gimp_file_dialog_new): added
	unused "GSList *file_procs" parameter.

	* app/gui/file-open-dialog.c: pass gimp->load_procs.
	* app/gui/file-save-dialog.c: pass gimp->save_procs.

103 104 105 106 107
2004-02-29  Sven Neumann  <sven@gimp.org>

	* app/tools/gimpblendoptions.c: changed the upper limit for the
	supersampling depth from 10 to 6 (as a workaround for bug #133266).

108 109 110 111 112 113
2004-02-29  Sven Neumann  <sven@gimp.org>

	* libgimpwidgets/gimpunitmenu.c (gimp_unit_menu_create_selection):
	no need to connect to "destroy", GTK_DIALOG_DESTROY_WITH_PARENT
	does this for us already.

114 115 116 117 118 119 120 121 122 123
2004-02-28  Sven Neumann  <sven@gimp.org>

	* libgimpwidgets/gimpdialog.c: removed the call to
	gtk_widget_get_toplevel() again.
	Implement the GTK_DIALOG_DESTROY_WITH_PARENT behaviour in a way
	that works for GimpDialog.

	* app/gui/resolution-calibrate-dialog.c: pass the toplevel window
	to gimp_dialog_new ().
	
Michael Natterer's avatar
Michael Natterer committed
124 125 126 127 128 129 130 131
2004-02-28  Michael Natterer  <mitch@gimp.org>

	* app/widgets/gimpcellrendererviewable.c: some general cleanup.

	(gimp_cell_renderer_viewable_set_property): ref the new renderer
	before unrefing the old one. Fixes potential crash when setting
	the same renderer again.

132 133 134 135 136 137
2004-02-28  Michael Natterer  <mitch@gimp.org>

	* app/core/gimplayer.c (gimp_layer_apply_mask): when deleting the
	mask, use "Delete Layer Mask" instead of "Apply Layer Mask" as
	undo description.

Sven Neumann's avatar
Sven Neumann committed
138 139 140 141 142 143 144 145 146 147
2004-02-28  Sven Neumann  <sven@gimp.org>

	* libgimpwidgets/gimpdialog.c (gimp_dialog_new_valist): if the
	parent widget is not a GtkWindow, use gtk_widget_get_toplevel()
	to get a pointer to the window the widget lives in.

	* app/gui/resolution-calibrate-dialog.c: don't make the dialog
	modal. It was a bad idea to do that, leading to problems spotted
	by Pedro Gimeno (bug #135630).

148 149 150 151
2004-02-27  Michael Natterer  <mitch@gimp.org>

	* libgimpwidgets/gimpfileentry.c: removed useless #includes.

152 153 154 155 156 157 158
2004-02-27  Michael Natterer  <mitch@gimp.org>

	* app/gui/file-dialog-utils.c
	* app/widgets/gimpfiledialog.c
	* libgimpwidgets/gimpfileentry.[ch]: some irrelevant micro changes
	to make that patch smaller.

159 160 161 162 163 164
2004-02-27  Michael Natterer  <mitch@gimp.org>

	* app/gui/file-open-dialog.c
	* app/gui/file-save-dialog.c: merged some small fixes/changes
	from my HEAD tree so the file chooser patch becomes smaller.

165 166 167 168 169
2004-02-27  Sven Neumann  <sven@gimp.org>

	* app/core/gimpimagefile.c (gimp_imagefile_save_thumb): peek the
	image to make sure that mtime and filesize are written correctly.

170 171 172 173 174 175
2004-02-27  Michael Natterer  <mitch@gimp.org>

	* app/gui/file-open-dialog.c: removed the thumbnail box.

	* app/widgets/gimpfiledialog.c: and added it here.

176 177 178 179 180
2004-02-27  Michael Natterer  <mitch@gimp.org>

	* app/gui/file-dialog-utils.[ch]: renamed parameters and removed
	useless #includes.

181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214
2004-02-27  Michael Natterer  <mitch@gimp.org>

	* app/widgets/Makefile.am
	* app/widgets/widgets-types.h
	* app/widgets/gimpfiledialog.[ch]: new widget swallowing most
	of file-dialog-utils.[ch]'s functionality.

	* app/widgets/widgets-types.h: added "gpointer callback_data" to
	GimpItemFactorySetupFunc so the setup_funcs can create items in
	the same context as the item factory's default items.

	* app/widgets/gimpmenufactory.c (gimp_menu_factory_menu_new):
	pass "callback_data" to setup_func().

	* app/gui/file-open-menu.[ch]
	* app/gui/file-save-menu.[ch]: use the passed callback_data
	when creating the menus and attach the file_proc to the
	menu items using g_object_set_data().

	* app/gui/file-commands.[ch]: merged separate file type callbacks
	for open and save dialogs into one callback which simply
	calls gimp_file_dialog_set_file_proc().

	* app/gui/file-dialog-utils.[ch]: removed file_dialog_new()
	and file_dialog_set_proc().

	* app/gui/file-open-dialog.[ch]
	* app/gui/file-save-dialog.[ch]: use the new widget and removed
	global variables except the dialog pointer itself.

	* app/gui/image-menu.[ch]
	* app/gui/tool-options-menu.[ch]
	* app/gui/toolbox-menu.[ch]: changed accordingly.

215 216 217 218
2004-02-26  Sven Neumann  <sven@gimp.org>

	* INSTALL: improved help on missing libraries at run-time.

219 220 221 222 223 224 225 226 227
2004-02-26  Michael Natterer  <mitch@gimp.org>

	* app/gui/file-dialog-utils.[ch] (file_dialog_hide): changed
	return value from gboolean to void because the function is no
	longer used as "delete_event" callback.

	* app/gui/file-open-dialog.c
	* app/gui/file-save-dialog.c: removed unused #includes.

Michael Natterer's avatar
Michael Natterer committed
228 229 230 231 232 233 234 235
2004-02-26  Michael Natterer  <mitch@gimp.org>

	* app/file/file-open.c (file_open_image): added missing cast.

	* app/widgets/gimperrorconsole.[ch]
	* app/widgets/gimptexteditor.[ch]: renamed members so my file
	chooser patch becomes smaller ;)

236 237 238 239 240 241
2004-02-26  Pedro Gimeno  <pggimeno@wanadoo.es>

	* app/file/file-open.c (file_open_image): Applied a fix by
	Michael Natterer addressing a problem with the preview in the
	open images list when loading a file.

242 243 244 245
2004-02-26  Michael Natterer  <mitch@gimp.org>

	* app/widgets/gimpthumbbox.[ch]: renamed some members, cleanup.

246 247 248 249 250 251 252 253 254 255
2004-02-26  Sven Neumann  <sven@gimp.org>

	* app/display/gimpprogress.c (gimp_progress_end): check
	display->shell before using it. It might be NULL if the function
	is being called from gimp_exit().

	* app/app_procs.c (app_exit_after_callback): added back the call
	to exit() but only for stable releases. See my comments in the
	code to understand the reasons.

256 257 258 259 260 261 262 263 264
2004-02-26  Michael Natterer  <mitch@gimp.org>

	* app/widgets/Makefile.am
	* app/widgets/widgets-types.h
	* app/widgets/gimpthumbbox.[ch]: new widget ripped out of the file
	open dialog.

	* app/gui/file-open-dialog.c: use it.

Sven Neumann's avatar
Sven Neumann committed
265 266 267 268
2004-02-26  Sven Neumann  <sven@gimp.org>

	* libgimpthumb/gimpthumbnail.c: fixed my fixes.

Sven Neumann's avatar
Sven Neumann committed
269 270 271 272 273 274 275 276
2004-02-25  Sven Neumann  <sven@gimp.org>

	* libgimpthumb/gimpthumbnail.c (gimp_thumbnail_load_thumb): never
	return a failed pixbuf.

	(gimp_thumbnail_save_failure) (gimp_thumbnail_save_thumb): set the
	thumb_state when saving a thumbnail.

277 278 279 280 281 282 283 284 285 286 287 288 289 290 291
2004-02-25  Michael Natterer  <mitch@gimp.org>

	Changed libgimpthumb API in a way that will make GtkFileChooser
	integration possible without doing major hacks:

	* libgimpthumb/gimpthumb-enums.h: added GimpThumbFileType enum
	and extended GimpThumbState enum.

	* libgimpthumb/gimpthumb-utils.[ch]: return GimpThumbFileType
	instead of gboolean from gimp_thumb_file_test().

	* libgimpthumb/gimpthumbnail.c
	* app/core/gimpimagefile.c: changed accordingly (the icons
	used for REMOTE, FOLDER and SPECIAL need to be changed).

Michael Natterer's avatar
Michael Natterer committed
292 293 294 295 296 297 298
2004-02-25  Michael Natterer  <mitch@gimp.org>

	* app/tools/gimpimagemaptool.c: cleanup.

	* app/tools/gimplevelstool.c (gimp_levels_tool_dialog): added 2px
	spacing between the pick buttons and their entries.

299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319
2004-02-25  Michael Natterer  <mitch@gimp.org>

	* app/tools/gimpimagemaptool.[ch]: moved "shell_desc" from
	GimpImageMapTool to GimpImageMapToolClass and added
	"load_dialog_title" and "save_dialog_title". Create the
	load/save buttons in gimp_image_map_tool_initialize() and
	remember them in the GimpImageMapTool struct. Moved the
	whole load/save button/dialog logic into private functions.

	* app/tools/gimpcurvestool.c
	* app/tools/gimplevelstool.c: changed accordingly, removed
	load/save callbacks, inlined the load/save functions into
	GimpImageMapTool's virtual function implementations.

	* app/tools/gimpbrightnesscontrasttool.c
	* app/tools/gimpcolorbalancetool.c
	* app/tools/gimpcolorizetool.c
	* app/tools/gimphuesaturationtool.c
	* app/tools/gimpposterizetool.c
	* app/tools/gimpthresholdtool.c: changed accordingly.

320 321 322 323 324
2004-02-25  Sven Neumann  <sven@gimp.org>

	* app/tools/gimpcurvestool.[ch]
	* app/tools/gimplevelstool.h: removed obsoleted variables.

325 326 327 328 329 330 331 332 333 334
2004-02-25  Sven Neumann  <sven@gimp.org>

	* app/tools/gimpcurvestool.[ch]
	* app/tools/gimpimagemapoptions.[ch]
	* app/tools/gimpimagemaptool.[ch]
	* app/tools/gimplevelstool.[ch]: moved the settings file dialog
	that was duplicated in the curves and levels tools to the
	GimpImageMapTool class. Store the last used filename in the
	GimpImageMapOptions (proper fix for bug #135059).

335 336 337 338 339 340 341 342 343 344
2004-02-24  Dave Neary  <bolsh@gimp.org>

	* app/tools/gimpcurvestool.c: Revert to 1.2 behaviour of hiding
	rather than destroying the curves load/save dialog. This makes 
	the last selected curve be selected when the dialog is 
	re-opened, and fixes bug #135059.

	Also append G_DIR_SEPARATOR_S to the end of the filename we 
	build while creating the dialog, rather than ".".

345 346 347 348 349 350
2004-02-24  Michael Natterer  <mitch@gimp.org>

	* libgimpwidgets/gimpfileentry.[ch]: renamed member
	"file_selection" to "file_dialog" because the former refers to the
	currently used implementation, while the latter is neutral.

351 352 353 354
2004-02-23  Adam Weinberger  <adamw@FreeBSD.org>

	* configure.in: added "en_CA" (Canadian English) to ALL_LINGUAS.

355 356 357 358 359 360 361 362
2004-02-23  Michael Natterer  <mitch@gimp.org>

	* app/core/core-types.h: added #defines for GimpCoords' default
	pressure, tilt and wheel values.

	* app/display/gimpdisplayshell-callbacks.c
	* app/paint/gimppaintcore-stroke.c
	* app/text/gimptext-vectors.c
363
	* app/vectors/gimpvectors-compat.c
364 365 366 367 368
	* tools/pdbgen/pdb/paint_tools.pdb: use them. Fixes lots more
	buggy default values for tilt (in fact all of them were wrong).

	* app/pdb/paint_tools_cmds.c: regenerated.

369 370 371 372 373 374 375
2004-02-23  Simon Budig  <simon@gimp.org>

	* app/display/gimpdisplayshell-callbacks.c: corrected the
	value ranges and default values for GDK_AXIS_XTILT and
	GDK_AXIS_YTILT. Now the ink-tool behaves sane with a mouse
	again  :)

376 377 378 379 380
2004-02-23  Simon Budig  <simon@gimp.org>

	* app/tools/gimpinktool-blob.c: don't access the array before
	checking if the index is within the valid bounds...

381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405
2004-02-23  Michael Natterer  <mitch@gimp.org>

	* app/core/gimpimage-snap.[ch]: return the snapped coordinates as
	gdouble, not gint because we must not round the unsnapped axis
	if only one axis snapped.

	* app/display/gimpdisplayshell.[ch] (gimp_display_shell_snap_coords):
	changed accordingly. Added boolean return value indicating "snapped".

	* app/display/gimpdisplayshell-cursor.[ch]
	(gimp_display_shell_update_cursor): take both display_x and _x and
	(possibly snapped) image_x and _y. Use the snapped values for the
	statusbar and the unsnapped ones for updating the info_window.

	* app/display/gimpdisplayshell-callbacks.c
	(gimp_display_shell_canvas_tool_events): applied modified patch
	from Simon Budig which moves guide/grid snapping out of the
	button_press/motion/button_release handlers and *always* snaps
	the image_coords if the active_tool wants them to be snapped.
	Makes sure that e.g. the brush preview is drawn at the right
	place and fixes bug #134284.

	Also pass both display_coords and image_coords to
	gimp_display_shell_update_cursor().

406 407 408 409 410
2004-02-23  Simon Budig  <simon@gimp.org>

	* app/core/gimp.[ch]: removed unused member "standard_context"
	from the Gimp struct.

411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429
2004-02-22  Sven Neumann  <sven@gimp.org>

	Let all GimpImageMap tools remember the state of the preview toggle
	(bug #135059):

	* app/tools/Makefile.am
	* app/tools/gimpimagemapoptions.[ch]
	* app/tools/tools-types.h: added new GimpToolOptions class to hold
	the preview setting.

	* app/tools/gimpbrightnesscontrasttool.c
	* app/tools/gimpcolorbalancetool.c
	* app/tools/gimpcolorizetool.c
	* app/tools/gimpcoloroptions.[ch]
	* app/tools/gimphuesaturationtool.c
	* app/tools/gimpimagemaptool.[ch]
	* app/tools/gimpposterizetool.c
	* app/tools/tools-types.h: use the new class.

430 431 432 433 434
2004-02-21  Manish Singh  <yosh@gimp.org>

	* app/widgets/gimpenummenu.c (gimp_enum_stock_box_set_child_padding):
	Add GTK_MISC cast for bin->child.

435 436 437 438 439 440 441 442 443 444
2004-02-21  Simon Budig  <simon@gimp.org>

	* app/tools/gimpdrawtool.[ch]: added "use_offsets" parameter
	to gimp_draw_tool_draw_boundary() for consistency.

	* app/tools/gimpeditselectiontool.c: Changed accordingly.

	* app/tools/gimppainttool.c: when drawing straight lines draw
	the brush preview at the end of the line.

445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467
2004-02-20  Sven Neumann  <sven@gimp.org>

	* app/tools/gimplevelstool.[ch]: put the color bars into an event
	box and draw the sliders on the event box window.

	* app/widgets/gimpcolorbar.[ch]: removed support for input events
	which is no longer needed. For consistency, renamed "channel"
	property to "histogram-channel".

	* app/widgets/gimphistogrambox.c: changed accordingly.

	* app/widgets/gimpenummenu.[ch]: added new function
	gimp_enum_stock_box_set_child_padding().

	* app/tools/gimpcurvestool.c: let the graph widget expand with the
	dialog plus some other dialog tweaks.

	* app/widgets/gimphistogrameditor.c: let the channel menu shrink
	as in the other dialogs.

	* libgimpwidgets/gimpcolorselect.c (gimp_color_select_image_fill):
	allocate temporary buffer on the stack.

468 469 470 471 472
2004-02-20  Manish Singh  <yosh@gimp.org>

	* plug-ins/common/pygimp/plug-ins/sphere.py: Moved to the Test menu,
	to clarify its station in life.

473 474 475 476 477 478 479 480 481
2004-02-20  Manish Singh  <yosh@gimp.org>

	* plug-ins/common/pygimp/gimpfu.py: Do some simple validation on the
	GUI input. Arrays are still kinda hokey though. Based on Dave Neary's
	patch, addresses bug #122049.

	* plug-ins/common/pygimp/plug-ins/sphere.py: Make sure radius is at
	least 1. Thanks to Florian Traverse for noticing. (Also in #122049)

482 483 484 485 486 487 488 489 490 491 492 493
2004-02-20  Simon Budig  <simon@gimp.org>

	* plug-ins/common/lic.c: fixed crash when the effect image
	is smaller than the target drawable. Major code overhaul (not
	yet fully completed), removed global variables, removed
	micro-functions that itself just invoke micro-functions, use
	more libgimpcolor functions.

	Slightly improved the algorithm by adding small random
	distorsions to the effect image. This avoids artefacts in plain
	areas.

494 495 496 497 498 499 500 501 502 503 504 505
2004-02-19  Sven Neumann  <sven@gimp.org>

	* app/widgets/Makefile.am
	* app/widgets/widgets-types.h
	* app/widgets/gimpcolorbar.[ch]: added new widget GimpColorBar.

	* app/tools/gimpcurvestool.c
	* app/tools/gimplevelstool.c
	* app/widgets/gimphistogrambox.[ch]: use GimpColorBar widgets.

	* app/widgets/gimpcolorframe.[ch]: fixed typos.

506 507 508 509 510 511 512 513 514 515
2004-02-19  Michael Natterer  <mitch@gimp.org>

	* themes/Default/images/Makefile.am
	* themes/Default/images/stock-display-filter-16.png
	* themes/Default/images/stock-display-filter-24.png
	* libgimpwidgets/gimpstock.[ch]: added Jimmac's glasses.

	* app/display/gimpdisplayshell-filter-dialog.c
	* app/gui/image-menu.c: and use them.

516 517 518 519 520 521
2004-02-19  Michael Natterer  <mitch@gimp.org>

	* app/widgets/gimpdasheditor.[ch]: removed static variables, don't
	use GIMP_CONFIG_INSTALL_PROP_FOO() for non-config classes,
	trailing whitespace, cleanup.

522 523 524 525 526 527 528
2004-02-19  Simon Budig  <simon@gimp.org>

	* plug-ins/common/lic.c: fixed gimp_dialog_new invocation.
	Also fixed a blatant error in the algorithm (GimpRGB has a 
	range from 0..1 for each component...) and now the plugin
	actually does something useful.

529 530 531 532 533
2004-02-19  Sven Neumann  <sven@gimp.org>

	* app/tools/gimpcurvestool.c (gimp_curves_tool_dialog): follow
	some of the levels tool dialog changes for consistency.

534 535 536 537 538 539 540 541
2004-02-19  Michael Natterer  <mitch@gimp.org>

	* app/core/gimpimage-qmask.c (gimp_image_get_qmask): new function
	which returns the image's QMask.

	* app/core/gimpimage.c (gimp_image_channel_name_changed)
	* app/gui/qmask-commands.c (qmask_query_response): use it.

542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558
2004-02-19  Michael Natterer  <mitch@gimp.org>

	* app/core/gimp.[ch]: added new signal "buffer_changed" and new
	function gimp_set_global_buffer() which emits it when the global
	buffer changes.

	* app/core/gimp-edit.c (gimp_edit_extract): use it instead
	of fiddling with gimp->global_buffer manually.

	* app/gui/image-menu.c: connect to "buffer_changed" and set the
	"Paste" menu entries sensitive. Fixes bug #134752.

	(image_menu_update): changed accordingly. Also changed a lot of
	buggy SET_SENSITIVE() lines which made menu items which work fine
	on any drawable insensitive when there were no layers (instead
	of no drawable).

559
	* app/gui/edit-commands.c: added new macro return_if_no_drawable()
560 561 562 563 564 565 566
	and use it instead of return_if_no_image() so we don't run
	into assertions if there is no active drawable.

	(cut,copy_named_buffer_callback): unfortunately had to introduce
	two new translated messages about not being able to cut/copy when
	there is no active drawable.

567 568 569 570 571 572 573 574 575 576 577
2004-02-19  Michael Natterer  <mitch@gimp.org>

	* app/config/gimpconfig-serialize.c
	(gimp_config_serialize_property)
	* app/config/gimpconfig-deserialize.c
	(gimp_config_deserialize_property): Reverted my last "cleanup" and
	put the "obsolete" check for the exact owner class of the property
	back. It appears that if a subclass does *not* implement
	GimpConfigInterface *itself*, it still inherits
	serialize_property()/deserialize_property().

578 579 580 581 582
2004-02-19  Sven Neumann  <sven@gimp.org>

	* app/tools/gimplevelstool.c: more dialog tweaking, fixed
	positioning of slider triangles.

583 584 585 586 587 588 589
2004-02-19  Sven Neumann  <sven@gimp.org>

	* app/tools/gimplevelstool.c (gimp_levels_tool_dialog): applied
	patch from Dave Neary that removes gray point pickers for
	individual channels (bug #125303). Let the levels widgets expand
	with the dialog.

590 591 592 593 594 595 596 597 598 599
2004-02-18  Simon Budig  <simon@gimp.org>

	* app/config/gimpguiconfig.[ch]
	* app/config/gimprc-blurbs.h: Added new GUI option: snapping distance

	* app/gui/preferences-dialog.c: add a preferences widget

	* app/tools/gimpmovetool.c
	* app/display/gimpdisplayshell.c: use it for snapping.

600 601 602 603 604 605 606 607 608 609
2004-02-18  Simon Budig  <simon@gimp.org>

	* app/display/gimpdisplayshell.c
	* app/tools/gimpmovetool.c: Adjusted snapping distance
	to 8 pixels, probably should be a preferences option.

	* app/tools/gimppainttool.c: Do not center the start and end
	of a straight line to the center of an image-pixel unless
	the brush mode is GIMP_BRUSH_HARD. Fixes bug #134410.

610 611
2004-02-18  Sven Neumann  <sven@gimp.org>

612 613 614 615
	* app/base/tile-cache.c
	* app/base/tile-private.h
	* app/base/tile.[ch]: removed trailing whitespace, added some
	newlines, let tile_is_valid() return a gboolean instead of a gint.
616 617 618 619 620 621 622

	* app/core/gimpimage-projection.c
	* app/core/gimpimage-undo-push.c
	* app/paint/gimppaintcore.c
	* app/tools/gimpinktool.c: use the return value from tile_is_valid()
	as a boolean.

623 624 625 626 627 628 629
2004-02-18  Sven Neumann  <sven@gimp.org>

	* app/base/tile.h: exchanged TILEROWHINT_UNKNOWN and
	TILEROWHINT_BROKEN so that TILEROWHINT_UNKNOWN becomes 0. This
	allows to use calloc() to allocate and initialize the rowhint
	array.

Sven Neumann's avatar
Sven Neumann committed
630 631
	* app/base/tile.c (tile_sanitize_rowhints): reimplemented by a
	call to g_new0().
632 633 634 635

	* app/base/tile-manager.c (tile_manager_get): use g_memdup() to
	duplicate the rowhints when creating a tile copy.

Michael Natterer's avatar
Michael Natterer committed
636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673
2004-02-18  Michael Natterer  <mitch@gimp.org>

	Some code review:

	* app/config/gimpconfig-deserialize.c
	* app/config/gimpconfig-serialize.c: removed obsolete code which
	made sure serialize_property()/deserialize_property() are only
	called for properties of the correct class. We do it the right way
	for quite a while now and clear the inherited function pointers in
	gimp_config_iface_base_init().

	* app/config/gimprc.c (gimp_rc_dispose): don't forget to chain up.

	* app/base/gimplut.c
	* app/base/lut-funcs.c
	* app/config/gimpconfig-deserialize.c
	* app/config/gimpconfig-serialize.c
	* app/config/gimpconfig-types.c
	* app/config/gimprc.c
	* app/core/gimp-modules.c
	* app/core/gimpbrush.c
	* app/core/gimpcontainer.c
	* app/core/gimpdocumentlist.c
	* app/core/gimpitem.c
	* app/gui/about-dialog.c
	* app/gui/color-notebook.c
	* app/gui/gui.c
	* app/gui/tips-dialog.c
	* app/paint/gimppaintcore.c
	* app/paint-funcs/paint-funcs.c
	* app/widgets/gimpcolorpanel.c
	* app/widgets/gimpcontainergridview.c
	* app/widgets/gimpcontainermenuimpl.c
	* app/widgets/gimpselectioneditor.c: removed I/O includes from
	files which don't use lowlevel APIs any more. Also removes
	a whole bunch of G_OS_WIN32 special casing. Removed trailing
	whitespace. Misc tiny cleanups.

674 675 676 677 678 679
2004-02-18  Michael Natterer  <mitch@gimp.org>

	* app/display/gimpdisplayshell-handlers.c
	(gimp_display_shell_disconnect): disconnect from the correct
	config objects. Fixes bug #134694.

680 681 682 683 684 685 686 687
2004-02-17  Sven Neumann  <sven@gimp.org>

	* app/widgets/gimpeditor.c (gimp_editor_add_stock_box): cannot
	gtk_widget_destroy() a floating widget, sink it instead.

	* libgimpwidgets/gimppatheditor.c (gimp_path_editor_set_path):
	plugged a small memleak.

688 689 690 691 692 693 694 695
2004-02-17  Pedro Gimeno  <pggimeno@wanadoo.es>

	* plug-ins/pagecurl/pagecurl.c: Corrected the pairing of
	gimp_drawable_get/gimp_drawable_detach and other cleanups.
	(do_curl_effect): Fixed a bug spotted by Simon Budig: uninitialized
	data could be exposed when applying the effect to non-rectangular
	selections.

696 697 698 699 700 701
2004-02-17  Michael Natterer  <mitch@gimp.org>

	* app/core/gimpviewable.c (gimp_viewable_calc_preview_size): argh,
	take the resolution into account if "dot_for_dot" is FALSE, not
	TRUE.

702 703 704 705 706 707
2004-02-17  Sven Neumann  <sven@gimp.org>

	* app/core/gimpimage-scale.c (gimp_image_scale_check): exclude the
	size of the undo stacks so that the memory size is comparable with
	the value displayed in the "New Image" dialog. Fixes bug #134512.

708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730
2004-02-17  Sven Neumann  <sven@gimp.org>

	* libgimpbase/gimpprotocol.[ch]: changed wm_name to app_name in
	the GimpConfig struct; increased GIMP_PROTOCOL_VERSION.

	* app/plug-in/plug-in-run.c (plug_in_run): pass the return value
	of g_get_application_name() to the plug-ins.

	* libgimp/gimp.[ch]: removed function gimp_wm_name(). Set the
	plug-in's application name if an app_name is passed in the config
	message.

	* libgimp/gimpui.c: removed usage of gimp_wm_name(); it was wrong
	to do it this way and caused all plug-ins claim to be the gimp-1.3
	executable in their error messages.

	* libgimp/gimp.def: removed symbol gimp_wm_name.

	* configure.in: reset gimp_binary_age and gimp_interface_age.

	* app/core/gimpimage.c (gimp_image_name_changed): removed unused
	variable.

731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748
2004-02-17  Michael Natterer  <mitch@gimp.org>

	Make sure each GimpItem emits "removed" when it is removed from
	the image so dialogs have a chance to close themselves:

	* app/core/gimplayer.c (gimp_layer_apply_mask): emit "removed"
	from the mask.

	(gimp_layer_removed): new function which emits "removed" from
	the layer's mask when the layer gets removed from the image.

	* app/core/gimpimage.c (gimp_image_dispose): emit "removed"
	from all layers, channels and vectors.

	* app/gui/layers-commands.c (layers_scale_layer_query)
	(layers_resize_layer_query): removed recently added connections to
	"removed" because GimpViewableDialog does this automatically.

749 750 751 752 753 754 755 756 757
2004-02-16  Michael Natterer  <mitch@gimp.org>

	* libgimp/gimptile.[ch] (_gimp_tile_cache_flush_drawable): new
	inernal function which removes all tiles from a given drawable
	from the cache.

	* libgimp/gimpdrawable.c (gimp_drawable_detach): call the new
	function before freeing the tiles. Fixes bug #134562.

758 759 760 761 762
2004-02-16  Michael Natterer  <mitch@gimp.org>

	* libgimp/gimppixelrgn.c: cleaned up a bit: added missing
	g_return_if_fail()s, iterate lists using for() loops, indentation.

763 764 765 766 767 768 769
2004-02-16  Sven Neumann  <sven@gimp.org>

	* libgimp/gimptile.c (gimp_tile_cache_insert): partly rewritten.
	Instead of removing the list element from the hash table, freeing
	it, allocating a new one and inserting it again, simply move it to
	the end of the list without touching the hash table at all.

770 771 772 773 774 775
2004-02-16  Sven Neumann  <sven@gimp.org>

	* app/config/gimpxmlparser.c (gimp_xml_parser_parse_io_channel):
	set the GIOChannel encoding to NULL here instead of doing it in
	gimp_xml_parser_parse_file().

776 777 778 779 780 781
2004-02-16  Sven Neumann  <sven@gimp.org>

	* plug-ins/gfig/gfig.c (gfig_response): set the Undo button
	insensitive, not the whole dialog (bug #134419). Also start the
	dialog with the Undo button set insensitive.

782 783 784 785 786 787
2004-02-16  Sven Neumann  <sven@gimp.org>

	* app/tools/gimpcroptool.c (crop_info_create): use limits from
	libgimpbase instead of arbitrary numbers. Don't allow a crop width
	or height smaller than 1 (or GIMP_MIN_IMAGE_SIZE actually).

788 789 790 791 792
2004-02-16  Sven Neumann  <sven@gimp.org>

	* app/display/gimpcanvas.c (gimp_canvas_gc_new): fixed my last
	change here; of course only the guide GCs need a stipple pattern.

793 794 795
2004-02-16  Sven Neumann  <sven@gimp.org>

	* app/config/gimpxmlparser.c (gimp_xml_parser_parse_io_channel):
796
	unset the GIOChannel's encoding before trying to locate and parse
797 798
	the XML header.

799 800 801 802 803 804 805 806 807 808 809 810 811
2004-02-15  Michael Natterer  <mitch@gimp.org>

	* libgimp/gimpdrawable.c (gimp_drawable_get): warn and return NULL
	instead of a meaningless struct for invalid drawable_IDs. Will
	make buggy plug-ins crash earlier and more reliably.

	Replaced all if(drawable) by g_return_if_fail(drawable != NULL)

	* libgimp/gimptile.c (gimp_tile_ref): replaced if(tile)
	by g_return_if_fail(tile != NULL)

	(gimp_tile_unref): g_return_if_fail(tile->ref_count > 0)

812 813 814 815 816
2004-02-15  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/gif.c: only call gimp_ui_init() when being run
	in interactively. Should fix bug #134423.

817 818 819 820 821 822 823 824 825
2004-02-15  Michael Natterer  <mitch@gimp.org>

	* app/core/gimpdata.c (gimp_data_init): using
	FOO_GET_CLASS(instance) in a GInstanceInitFunc doesn't work
	because during instance init, the object's class is always set to
	be the class of the currently called init function. Use the second
	parameter of GInstanceInitFunc instead, which is the instance's
	real class. Fixes bug #134274.

826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866
2004-02-14  Michael Natterer  <mitch@gimp.org>

	Fixed lots of QuickMask brokenness by letting the image adjust
	its qmask_state automatically:

	* app/core/gimpimage-qmask.h: #define GIMP_IMAGE_QMASK_NAME "Qmask".
	Use the define in all files below.

	* app/core/gimpimage.[ch]: split gimp_image_drawable_add,_remove()
	into separate handlers for layers and channels. Added a
	"name_changed" handler for all channels. In the channel "add",
	"remove" and "name_changed" handlers, check if it was a channel
	named "Qmask" that was added, removed or renamed and call
	gimp_image_set_qmask_state() accordingly.

	* app/core/core-enums.[ch]
	* app/core/gimpimage-undo-push.[ch]
	* app/core/gimpundo.c: removed all Qmask undo code because the image
	does the right thing without undo interaction now.

	* app/core/gimpimage-qmask.c (gimp_image_set_qmask_state): set
	gimage->qmask_state early so we can return early when called
	recursively. Removed calls to gimp_image_undo_push_image_qmask().
	Returned "removed" callback (it was utterly broken the way it was
	implemented).

	* app/display/gimpdisplayshell-callbacks.c
	(gimp_display_shell_qmask_toggled): check if the image's
	qmask state needs to be changed before changing it.

	* app/xcf/xcf-load.c (xcf_load_channel): removed code which
	recognized the qmask. GimpImage does this automatically now.

	* app/gui/qmask-commands.c: cleanup.

	* app/widgets/gimpimagedock.c (gimp_image_dock_constructor):
	destroy the "/Select/By Color" and "/Select/Toggle QuickMask" menu
	items.

	* app/widgets/image-menu.c (image_menu_update): changed accordingly.

867 868 869 870 871 872
2004-02-13  Manish Singh  <yosh@gimp.org>

	* plug-ins/common/psd.c (load_image): Initialize dest to NULL,
	make it so the temp variable use for PANOTOOLS_FIX is only declared
	when it is enabled.

873 874 875 876 877 878 879 880 881
2004-02-13  Manish Singh  <yosh@gimp.org>

	* app/base/temp-buf.c (temp_buf_get_memsize)
	* core/gimpviewable.c (gimp_viewable_get_memsize): Add some casts
	to gsize for ints to prevent overflows.

	* app/base/tile-manager.c (tile_manager_get_memsize): Same as above,
	except cast to gint64.

882 883 884 885 886 887 888
2004-02-13  Simon Budig  <simon@gimp.org>

	* app/core/gimpimage-guides.[ch]: make a similar fix as in my
	last commit for snapping the guides.
	
	* app/tools/gimpmovetool.c: use the fixed version.

889 890 891 892 893 894 895 896 897 898
2004-02-13  Simon Budig  <simon@gimp.org>

	* app/core/gimpimage-snap.[ch]: make the snapping width a
	parameter of the snapping functions.

	* app/display/gimpdisplayshell.c: make sure that the snapping
	width always is 5 pixels in the view coordinates.

	Fixes bug #134285

899 900 901 902 903
2004-02-13  Michael Natterer  <mitch@gimp.org>

	* app/core/gimp-units.c (gimp_units_init, _exit): removed
	redundant g_return_if_fail()s.

904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931
2004-02-13  Michael Natterer  <mitch@gimp.org>

	Fixed GimpData's default "writable" and "deletable" behaviour:

	* app/core/gimpdata.c (gimp_data_init): default to writable and
	deletable == TRUE (something that has no filename was never loaded
	from disk and can't be undeletable or read-only).
	Fixes bug #134274.

	* app/core/gimpdata.[ch]: added new function
	gimp_data_make_internal() which frees the filename and sets the
	data's flags accordingly.

	* app/core/gimp-gradients.c (gimp_gradients_add_gradient)
	* app/core/gimpbrush.c (gimp_brush_get_standard)
	* app/core/gimpgradient.c (gimp_gradient_get_standard)
	* app/core/gimppalette.c (gimp_palette_get_standard)
	* app/core/gimppattern.c (gimp_pattern_get_standard): use the
	new function for internal data objects.

	* app/core/gimpdata.c (gimp_data_save, gimp_data_delete_from_disk)
	* app/core/gimpdatafactory.c (gimp_data_factory_save_single):
	bail out with g_return_if_fail() is the data is not writable
	or deletable.

	* app/widgets/gimpdataeditor.c
	* app/widgets/gimpdatafactoryview.c: changed accordingly.

932 933 934 935 936
2004-02-12  Sven Neumann  <sven@gimp.org>

	* app/display/gimpcanvas.c (gimp_canvas_gc_new): use
	GDK_CAP_NOT_LAST as the cap_style for all canvas drawing.

937 938 939 940 941 942 943 944 945 946
2004-02-12  Adam D. Moss  <adam@gimp.org>

	* plug-ins/common/psd.c:
	- Disable one of the PanoTools fixes by default, since it causes
          regressions in some ordinary PSD file loading.
	- Fix a twisted utf8-obsessive bug diagnosed by Piotr Krysiuk
	- Fix another one...
	- Fix from Daniel Rogers: GIMP crashes on 0x0 layers, so we skip them.
	- Also try to avoid 0-sized drawables (including channels)

947 948 949 950 951 952 953 954
2004-02-12  Michael Natterer  <mitch@gimp.org>

	* app/core/gimpimage-convert.c (gimp_image_convert): call
	gimp_image_colormap_changed() after installing the colormap.

	* app/tools/gimphistogramoptions.h: fixed typedef of
	GimpHistogramOptionsClass.

955 956 957 958 959 960 961 962 963
2004-02-12  Michael Natterer  <mitch@gimp.org>

	* app/widgets/gimphistogramview.c (gimp_histogram_view_button_press):
	ignore double clicks so we don't grab the pointer away from the
	curves dialog. Fixes bug #132356.

	* app/tools/gimpcurvestool.c (curves_graph_events): ignore button
	press and release events from all buttons except the first one.

964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986
2004-02-12  Michael Natterer  <mitch@gimp.org>

	Make sure that non-indexed images never have a colormap.
	Fixes bug #121033.

	* app/core/gimpimage-colormap.c (gimp_image_set_colormap): set
	image->cmap to NULL when called with a NULL colormap.

	* app/core/gimpimage-undo-push.c: made colormap undo/redo aware
	of NULL colormaps.

	* app/core/gimpimage-convert.c (gimp_image_convert): remove the
	colormap using gimp_image_set_colormap() instead of freeing it
	manually.

	* app/widgets/gimpcolormapeditor.c: always check if the image
	is INDEXED *and* has a colormap before accessing the colormap.

	(need this new check because the fixed behaviour of colormap undo
	produces undo groups which, when being popped, make the image have
	no colormap while still being INDEXED in the small time frame
	between the emission of "colormap_changed" and "mode_changed").

987 988 989 990 991 992
2004-02-12  Sven Neumann  <sven@gimp.org>

	* app/tools/gimptexttool.[ch]: derive the text tool from GimpTool
	directly. Doesn't look like we are going to use draw_tool
	functionality for 2.0.

993 994 995 996 997 998 999 1000
2004-02-11  Sven Neumann  <sven@gimp.org>

	* app/display/gimpdisplayshell-dnd.c
	(gimp_display_shell_bucket_fill): when dropping a color on a text
	layer, change the text color. This is a quick hack; we should make
	filling a drawable a virtual method that can be overridden by the
	text layer.

Sven Neumann's avatar
Sven Neumann committed
1001 1002 1003 1004
2004-02-11  Sven Neumann  <sven@gimp.org>

	* configure.in (GIMP_DESKTOP_ICON): fixed icon names.

1005 1006 1007 1008 1009
2004-02-11  Sven Neumann  <sven@gimp.org>

	* app/tools/gimptexttool.c: repaired broken text tool logic
	(bug #124969).

1010 1011 1012 1013 1014 1015 1016 1017
2004-02-11  Sven Neumann  <sven@gimp.org>

	* app/plug-in/plug-ins.c (plug_ins_init)
	* app/plug-in/plug-in.c (plug_in_close): changed g_warning() to
	g_printerr() in a few places where the problem is not an error in
	GIMP but a misbehaving plug-in. Suppress some of this output in
	the stable branch.

1018 1019 1020 1021 1022
2004-02-10  Sven Neumann  <sven@gimp.org>

	* app/gui/preferences-dialog.c (prefs_dialog_new): removed "Default"
	prefix from "Navigation Preview Size" label again.

1023 1024 1025 1026 1027
2004-02-10  Henrik Brix Andersen  <brix@gimp.org>

	* app/gui/preferences-dialog.c (prefs_dialog_new): prefix preview
	size labels with "Default" to avoid misunderstandings.

1028 1029 1030 1031 1032 1033 1034 1035
2004-02-10  Sven Neumann  <sven@gimp.org>

	* themes/Default/images/Makefile.am (CORE_IMAGES): use the
	question stock icon instead of the warning one.

	* app/core/gimpviewable.c (gimp_viewable_get_dummy_preview):
	return a question icon as dummy preview.

1036 1037 1038 1039 1040 1041 1042 1043
2004-02-10  Sven Neumann  <sven@gimp.org>

	* themes/Default/images/Makefile.am: added a rule to create a
	header containing a warning pixbuf that we can use from the core.

	* app/base/temp-buf.c (temp_buf_new): rewritten an optimisation so
	that it works for any number of bytes per pixel.

1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063
2004-02-10  Michael Natterer  <mitch@gimp.org>

	* app/core/gimpviewable.[ch]: added new function
	gimp_viewable_get_dummy_preview() which currently returns a
	completely white and opaque TempBuf of the requested size.  Added
	this useless function because this is the place where to implement
	a nicer preview if someone volunteers.

	* tools/pdbgen/pdb/drawable.pdb
	* tools/pdbgen/pdb/image.pdb: use the new function if
	gimp->config->layer_previews is FALSE instead of returning no
	preview at all. Fixes bug #112012.

	Cleaned up the preview functions a bit and raised
	the limit for drawable previews from 128x128 to 256x256.

	* app/pdb/drawable_cmds.c
	* app/pdb/image_cmds.c
	* libgimp/gimpdrawable_pdb.c: regenerated.

1064 1065 1066 1067 1068 1069
2004-02-10  Sven Neumann  <sven@gimp.org>

	* configure.in: warn when gimpprint is older than version 4.2.6.
	It's probably too late to introduce a dependency on that version
	but we would like people to update in order to avoid bug #125283.

1070 1071 1072 1073 1074 1075
2004-02-10  Sven Neumann  <sven@gimp.org>

	* app/widgets/gimpcolorframe.c (gimp_color_frame_init): make the
	value labels selectable as suggested by Mariano Suárez-Alvarez in
	bug #133958.

1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088
2004-02-10  Sven Neumann  <sven@gimp.org>

	* configure.in: bumped version to 1.3.27 (interface_age 1,
	binary_age 1). Added GIMP_DESKTOP_ICON variable and set it
	depending on GIMP_UNSTABLE.

	* data/images/Makefile.am
	* data/images/wilber-devel-icon.png
	* data/images/wilber-icon.png: renamed the development icon and
	added one for the stable version.

	* data/misc/gimp.desktop.in.in: use @GIMP_DESKTOP_ICON@.

1089 1090 1091 1092 1093
2004-02-10  Sven Neumann  <sven@gimp.org>

	* app/tools/gimptexttool.c (gimp_text_tool_register): set
	GIMP_CONTEXT_FONT_MASK. Fixes bug #133067.

1094 1095 1096 1097 1098 1099 1100 1101
2004-02-09  Simon Budig  <simon@gimp.org>

	* plug-ins/script-fu/scripts/add-bevel.scm: Fixed Undo
	handling, make sure that the bumpmap is big enough to
	avoid artefacts.

	Fixes bug #130636.

1102 1103 1104 1105 1106 1107 1108
2004-02-09  Michael Natterer  <mitch@gimp.org>

	* app/gui/gui.c (gui_libs_init): added runtime check for
	fontconfig > 2.2.0 and abort with a dialog box telling the
	user to upgrade fontconfig if the requirement is not met.
	Fixes all bugs like #133818.

1109 1110 1111 1112 1113
2004-02-09  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/curve_bend.c: applied patch from Wolfgang Hofer
	that fixes bug #133244.

1114 1115 1116 1117 1118
2004-02-09  Sven Neumann  <sven@gimp.org>

	* app/Makefile.am: some updates to the gimp-console rules so that
	it fails less badly.

1119 1120 1121 1122 1123 1124 1125 1126 1127 1128
2004-02-09  Manish Singh  <yosh@gimp.org>

	* app/file/Makefile.am
	* app/paint/Makefile.am
	* app/text/Makefile.am
	* app/xcf/Makefile.am: changed GTK_CFLAGS to GDK_PIXBUF_CFLAGS, since
	we don't use any gtk/gdk functions here. This especially helps in the
	text directory, since it avoids problems on broken setups with old
	fontconfig stuff in the X11 directory lying around.

1129 1130 1131 1132 1133
2004-02-09  Sven Neumann  <sven@gimp.org>

	* plug-ins/script-fu/scripts/text-circle.scm: removed some workarounds
	for bugs in the GIMP 1.2 text functions that don't exist any longer.

1134 1135 1136 1137 1138 1139
2004-02-09  Sven Neumann  <sven@gimp.org>

	* app/core/gimpimage-undo-push.c (undo_pop_layer) (undo_push_layer)
	* app/paint-funcs/paint-funcs.c (scale_region): ifdef'ed out debug
	output.

1140 1141 1142 1143 1144 1145 1146 1147 1148 1149
2004-02-09  Sven Neumann  <sven@gimp.org>

	* app/core/gimpitem.[ch]: added progress callback pointers to
	gimp_item_scale() and its variants.

	* app/core/gimpchannel.c
	* app/core/gimpdrawable.c
	* app/core/gimpimage-scale.c
	* app/core/gimplayer.c
	* app/core/gimpselection.c
Sven Neumann's avatar
oops  
Sven Neumann committed
1150
	* app/gui/layers-commands.c
1151 1152 1153 1154 1155 1156
	* app/paint-funcs/paint-funcs.[ch]
	* app/vectors/gimpvectors.c
	* tools/pdbgen/pdb/layer.pdb: changed accordingly. Fixes bug #97999.

	* app/pdb/layer_cmds.c: regenerated.

1157 1158 1159 1160 1161 1162
2004-02-08  Sven Neumann  <sven@gimp.org>

	* app/tools/gimpiscissorstool.c (gimp_iscissors_tool_button_press): 
	don't activate the iscissors tool if it's already active
	(bug #132351).

1163 1164 1165 1166 1167 1168
2004-02-08  Sven Neumann  <sven@gimp.org>

	* app/tools/gimptexttool.c (gimp_text_tool_set_layer): implemented
	so that double-clicking a text layer now only activates the text
	tool but also set the layer's text on the tool options.

1169 1170 1171 1172 1173 1174 1175
2004-02-08  Sven Neumann  <sven@gimp.org>

	* app/tools/gimptoolcontrol.c (gimp_tool_control_activate)
	(gimp_tool_control_halt): put overly picky sanity checks into
	#ifdef GIMP_UNSTABLE ... #endif so we won't get these harmless
	tool warnings from the stable version (bug #121074).

1176 1177 1178 1179 1180
2004-02-08  Hans Breuer  <hans@breuer.org>

	* plug-ins/common/nova.c : access dest[alpha] only if (has_alpha);
	remove stray semicolon, fixes bug #132503	

1181 1182 1183 1184 1185 1186 1187 1188 1189 1190
2004-02-08  Sven Neumann  <sven@gimp.org>

	* app/plug-in/plug-in-rc.c (plug_in_rc_parse): return FALSE if the
	file wasn't found.

	* app/plug-in/plug-ins.c (plug_ins_init): don't output the error
	message from plug_in_rc_parse() if it failed for file not found.

	Fixes bug #133490.
	
Sven Neumann's avatar
Sven Neumann committed
1191 1192 1193 1194
2004-02-08  Sven Neumann  <sven@gimp.org>

	* libgimpwidgets/gimppickbutton.c: some code cleanup, no changes.

1195 1196 1197 1198 1199 1200 1201 1202
2004-02-08  Michael Natterer  <mitch@gimp.org>

	* tools/pdbgen/pdb/image.pdb (image_rotate): fixed typo:
	s/spacified/specified/. Spotted by Kevin Cozens.

	* app/pdb/image_cmds.c
	* libgimp/gimpimage_pdb.c: regenerated.

1203 1204 1205 1206 1207 1208 1209 1210
2004-02-08  DindinX  <david@dindinx.org>

	* plug-ins/common/tiff.c: applied a modified patch from Pablo
	d'Angelo, which add support for tiff layer names when the name is 7
	bits clean.

	Fixes bug #131044

1211 1212 1213 1214
2004-02-07  Manish Singh  <yosh@gimp.org>

	* configure.in: fix use of EXEEXT in tiff checks. Fixes bug #133763.

1215 1216 1217 1218 1219 1220
2004-02-07  Hans Breuer  <hans@breuer.org>

	* gimpdefs.msc : new file to keep common definitions for the msc build
	* **/makefile.msc : use common defintions, e.g. GIMP_VER
	* Makefile.am : add the former to EXTRA_DIST

1221 1222 1223 1224 1225 1226 1227 1228 1229
2004-02-07  Pedro Gimeno  <pggimeno@wanadoo.es>

	* app/core/gimpimage-convert.c (median_cut_pass2_no_dither_rgb):
	Corrected position for alpha_pix in the case of grayscale images
	with custom or mono palette and no dither. Fixes bug #133642.

	(median_cut_pass2_fixed_dither_rgb): Ditto for fixed dither
	(Positioned Color Dither).

1230 1231 1232 1233 1234 1235 1236 1237 1238
2004-02-07  Michael Natterer  <mitch@gimp.org>

	* app/display/gimpdisplayshell-draw.c
	(gimp_display_shell_draw_area): intersect the passed in area with
	the real area of the image in display coordinates and render the
	projection only if there actually is an intersection.
	Use gimp_rectangle_intersect() instead of handmade CLAMP()
	constructs. Fixes bug #113142.

1239 1240 1241 1242 1243 1244
2004-02-07  Sven Neumann  <sven@gimp.org>

	* app/plug-in/plug-in-shm.c (plug_in_shm_get_ID): don't
	g_return_if_fail() if gimp->plug_in_shm is NULL; return -1 instead.
	This allows to run gimp with --no-shm again.

1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263
2004-02-07  Michael Natterer  <mitch@gimp.org>

	* app/display/gimpdisplayshell.[ch]: removed all drawing functions.
	The file was still too large.

	* app/display/Makefile.am
	* app/display/gimpdisplayshell-draw.[ch]: new files containing
	the drawing functions.

	* app/display/gimpdisplayshell-callbacks.c
	* app/display/gimpdisplayshell-handlers.c
	* app/tools/gimpmovetool.c: changed #includes accordingly.

	* app/display/gimpdisplay-handlers.c
	(gimp_display_size_changed_handler): added some #if 0'ed code I'm
	not sure about. Actually, some of the handlers in this file could
	need the same code, so it could be abstracted as
	gimp_display_stop_draw() or something. Please have a look.

1264 1265 1266 1267 1268
2004-02-06  Sven Neumann  <sven@gimp.org>

	* libgimpwidgets/gimpcolorselect.c: let the color selector widget
	expand. Removes the ugly empty spaces and improves the color
	selection experience ;)
1269

1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280
2004-02-05  Michael Natterer  <mitch@gimp.org>

	* app/display/gimpdisplayshell.c (gimp_display_shell_mask_bounds):
	fixed integer/boolean confusion: s/0/FALSE/.

	(gimp_display_shell_draw_cursor): draw the cursor only if
	shell->have_cursor is TRUE.

	* app/display/gimpdisplayshell-callbacks.c
	(gimp_display_shell_canvas_expose): call the above unconditionally.

1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310
2004-02-05  Michael Natterer  <mitch@gimp.org>

	Disallow editing of data objects which have no save functionality.
	Also fixed the misassumption that "deletable" is always equal to
	"writable". Fixes bug #133456.

	* app/core/gimpdata.[ch]: added a "deletable" property which is
	always equal to "writable" except when the data class does not
	implement GimpData::save() (then deletable may be TRUE but
	writable is always FALSE).

	* app/gui/brushes-menu.c
	* app/gui/gradients-menu.c
	* app/gui/palettes-menu.c
	* app/gui/patterns-menu.c
	* app/widgets/gimpdatafactoryview.c: look at data->deletable when
	setting the sensitivity of the "Delete" buttons and menu items.

	* app/widgets/gimpdatafactoryview.c
	(gimp_data_factory_view_tree_name_edited): rename the data
	only if it's writable and restore the old name otherwise.

	* app/widgets/gimpdataeditor.c: no need to look at data->internal
	for figuring if the data is editable, data->editable is enough.

	All files above: s/writeable/writable/g

	* app/widgets/gimpbrusheditor.c (gimp_brush_editor_set_data):
	simplified.

1311 1312 1313 1314 1315 1316 1317 1318 1319
2004-02-05  Michael Natterer  <mitch@gimp.org>

	* tools/pdbgen/pdb/edit.pdb (edit_paste): don't call
	gimp_edit_paste() with a NULL buffer. Instead, return an execution
	error if there is no global buffer to paste. Fixes the warning
	triggered by bug #133244 (but not the bug itself of course).

	* app/pdb/edit_cmds.c: regenerated.

1320 1321 1322 1323 1324
2004-02-05  Sven Neumann  <sven@gimp.org>

	* plug-ins/imagemap/imap_main.c (dialog): quit the main loop when
	the dialog is destroyed. Fixes bug #133532.

1325 1326 1327 1328 1329 1330 1331
2004-02-05  DindinX  <david@dindinx.org>

	* plug-ins/script-fu/scripts/text-circle.scm: Fixes the layout of the
	rendered text.

	Fixes bug #131634

1332 1333 1334 1335 1336 1337 1338 1339
2004-02-05  Michael Natterer  <mitch@gimp.org>

	* app/core/gimpimage-crop.c: removed trailing whitespace.

	* app/gui/debug-commands.[ch]
	* app/gui/toolbox-menu.c: renamed ENABLE_DEBUG_ENTRIES to
	ENABLE_DEBUG_MENU and #define it to be equal to GIMP_UNSTABLE.

1340 1341 1342 1343 1344 1345 1346 1347 1348
2004-02-05  Michael Natterer  <mitch@gimp.org>

	* app/tools/gimprectselecttool.c
	(gimp_rect_select_tool_rect_select): don't try to CLAMP() the
	passed in rectangle to valid image/drawable coordinates manually
	when auto-shrinking the selection. Instead, use
	gimp_rectangle_intersect(). Also honor the active drawable's
	offsets. Fixes bug #133467.

1349 1350 1351 1352 1353 1354 1355 1356 1357
2004-02-05  Manish Singh  <yosh@gimp.org>

	* plug-ins/pygimp/pygimp-pdb.c (pygimp_param_from_tuple): Translate
	None to NULL when passing strings.

	* plug-ins/pygimp/gimpui.py: Pass None for brush, pattern, and
	gradient get_list so they work. Redo selection list to use a
	TreeView. Quickie solution for now, it could be much better.

1358 1359 1360 1361 1362
2004-02-04  Manish Singh  <yosh@gimp.org>

	* configure.in: Resurrected several autoconf substitutions relating
	to versions, so the .spec file can use them.

1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377
2004-02-05  Raphaël Quinet  <quinet@gamers.org>

	* configure.in: Added a conditional definition of the preprocessor
	symbol GIMP_UNSTABLE if the autoconf symbol GIMP_UNSTABLE is
	defined.

	* app/errors.c (gimp_errors_init): Replaced the #if test on
	GIMP_MINOR_VERSION modulo 2 by #ifdef GIMP_UNSTABLE.

	* app/composite/gimp-composite.c (gimp_composite_init): Print the
	init messages only in unstable versions.  Split the messages in
	two lines and mention "supported by gimp_composite" in order to
	give a hint that the availability of some features depends also on
	what code has been written.  Fixes bug #128825.

1378 1379 1380 1381 1382 1383 1384
2004-02-04  Sven Neumann  <sven@gimp.org>

	* app/core/gimpchannel.c
	* app/tools/gimptexttool.c
	* app/vectors/gimpvectors.c
	* app/widgets/gimpbufferview.c: removed double semicolons.

1385 1386 1387 1388
2004-02-04  Sven Neumann  <sven@gimp.org>

	* app/Makefile.am (dist-hook): create an unversioned gimprc manpage.

Sven Neumann's avatar
Sven Neumann committed
1389 1390 1391 1392
2004-02-04  Sven Neumann  <sven@gimp.org>

	* Made 2.0pre3 release.

1393 1394 1395 1396 1397
2004-02-04  Sven Neumann  <sven@gimp.org>

	* docs/Makefile.am (EXTRA_DIST): removed redundant entries that
	became invalid when the change to unversioned files was made.

1398 1399 1400 1401 1402 1403 1404 1405 1406
2004-02-04  Michael Natterer  <mitch@gimp.org>

	* app/display/gimpdisplayshell-render.c (struct RenderInfo)
	(render_image_accelerate_scaling): use gdouble instead of gfloat
	for x and y scale factors so gfloat's limited precision can't add
	up to off-by-one pixel errors. Fixes display artefacts (missing
	updates) at the bottom and right sides of updated areas at certain
	irrational zoom factors like 1:3.

1407 1408 1409 1410 1411
2004-02-04  Sven Neumann  <sven@gimp.org>

	* app/gui/image-menu.c (image_menu_entries): added percentages to
	the View->Zoom menu entries as suggested in bug #131563.

1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426
2004-02-04  Sven Neumann  <sven@gimp.org>

	* app/config/gimprc.[ch]: added the new function
	gimp_rc_set_unknown_token() to get autosave working for unknown
	gimprc tokens.
	
	* app/config/gimpconfig.c: indentation.

	* tools/pdbgen/pdb/gimprc.pdb: gimp->edit_config was used for a
	good reason, it's the one that's saved. Reverted a change I did
	about a month ago. Use gimp_rc_set_unknown_token() so unknown
	tokens get saved. This really fixes gimp_gimprc_set().

	* app/pdb/gimprc_cmds.c: regenerated.

1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441
2004-02-03  Manish Singh  <yosh@gimp.org>

	* configure.in: Allow generated files with versions.

	* gimp-2.0.pc.in
	* gimpthumb-2.0.pc.in
	* gimpui-2.0.pc.in
	* docs/gimp-1.3.1.in
	* docs/gimp-remote-1.3.1.in
	* docs/gimprc-1.3.5.in
	* docs/gimptool-2.0.1.in: renamed to unversioned files.

	I left gimptool-2.0.in alone since I didn't want to screw with
	other branches history. It'll be obsolete post-2.0 anyway.

1442 1443 1444 1445 1446
2004-02-03  Manish Singh  <yosh@gimp.org>

	* plug-ins/maze/maze_face.c (maze_dialog): remove unused variable
	randomize.

Manish Singh's avatar
Manish Singh committed
1447 1448 1449 1450
2004-02-03  Manish Singh  <yosh@gimp.org>

	* gimptool-2.0.in: use GIMP_API_VERSION.

Sven Neumann's avatar
Sven Neumann committed
1451 1452 1453 1454 1455
2004-02-03  Sven Neumann  <sven@gimp.org>

	* app/display/gimpdisplayshell-scale.c
	(gimp_display_shell_scale_dialog): improved dialog layout.

1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466
2004-02-03  Sven Neumann  <sven@gimp.org>

	* app/gui/image-menu.c (image_menu_set_zoom): don't mark weird
	format strings as translatable.

	* data/misc/gimp.desktop.in.in (_Name): use "The GIMP" without an
	"(unstable)" suffix. Should give translators the chance to update
	their translations before the final 2.0 release.

	* configure.in: removed now unused GIMP_VISIBLE_NAME variable.

1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477
2004-02-03  Michael Natterer  <mitch@gimp.org>

	* app/plug-in/plug-ins.c (plug_ins_init): use g_clear_error()
	instead of g_error_free() and re-use the same GError location for
	pluginrc parsing and writing.

	(plug_ins_proc_def_insert): when overriding a PlugInProcDef, don't
	take over the menu_path and menu_accel of the overridden proc
	because (a) it's just plain wrong and (b) we don't need to
	preserve the proc_defs' order any more (see below).

1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508
2004-02-03  Michael Natterer  <mitch@gimp.org>

	* app/plug-in/plug-in-proc.[ch]: added new function
	plug_in_proc_def_compare_menu_path() which is a GCompareDataFunc.
	(uses g_utf8_collate() on the translated menu paths).

	* app/plug-in/plug-ins.c (plug_ins_init): sort gimp->load_procs
	and gimp->save_procs using the new compare function above.
	Fixes bug #133180.

	(plug_ins_locale_domain)
	(plug_ins_help_domain): don't g_return_if_fail() on a NULL
	prog_name but return the default locale and help domains
	of the GIMP itself.

	(plug_ins_proc_def_insert): removed obsolete and broken (not
	locale and UTF-8 aware) code which tried to insert new plug-in
	menu entries in alphabetical order (was unused except for load
	and save procs).

	Unrelated:

	* app/plug-in/plug-in-proc.[ch]: added const qualifiers.

	* app/file/file-open.c
	* app/file/file-save.c
	* tools/pdbgen/pdb/fileops.pdb: changed accordingly (constify
	local variables).

	* app/pdb/fileops_cmds.c: regenerated.

1509 1510 1511 1512 1513 1514
2004-02-03  Michael Natterer  <mitch@gimp.org>

	* plug-ins/script-fu/scripts/*.scm: applied patch from Kevin
	Cozens <kcozens@interlog.com> which removes the use of deprecated
	constants in all scripts. Fixes bug #133270.

1515 1516 1517 1518 1519 1520
2004-02-03  Michael Natterer  <mitch@gimp.org>

	* plug-ins/script-fu/script-fu-scripts.c (script_fu_free_script): 
	call gimp_uninstall_temp_proc() with script->pdb_name, not
	script->script_name. Fixes bug #133280.

1521 1522 1523 1524 1525 1526 1527 1528 1529 1530
2004-02-02  DindinX  <david@dindinx.org>

	* app/display/gimpcanvas.c: gimp_canvas_draw_segments():
	  Do not call gdk_draw_segments() with more than 32000 segments at a
	  time, because XDrawSegments should never be called with more
	  segments than that. This should really be fixed at the gdk level,
	  though.

	This fixes bug #122026.

1531 1532 1533 1534 1535 1536 1537 1538 1539
2004-02-02  Sven Neumann  <sven@gimp.org>

	* libgimpthumb/gimpthumbnail.c (gimp_thumbnail_save_thumb): use
	the UTF-encoded URI in error messages, not the filename.

	* app/Makefile.am: use $(EXEEXT) for dist-hook binary dependency.
	
	* tools/gimp-remote.c: include <unistd.h> conditionally.

1540 1541 1542 1543 1544 1545 1546 1547
2004-02-02  Michael Natterer  <mitch@gimp.org>

	* app/widgets/gimpimagedock.c (gimp_image_dock_constructor):
	also destroy the <Image> factory's "Tools" submenu because menu
	shortcuts with no or <shift> modifier prevent this key to be
	entered in text entries. This really badly baldy cries for
	GTK+ 2.4's GtkActions...

1548 1549 1550 1551 1552 1553 1554 1555
2004-02-01  Michael Natterer  <mitch@gimp.org>

	* app/config/gimpconfig-path.c (gimp_config_path_expand_only):
	when calculating the length of the expanded path, add the length
	of the UTF-8 converted substitution, not its length in filesystem
	encoding. Finally enables GIMP2_DIRECTORY containing non-ascii
	chars (at least on linux). Should fix bug #130118.

1556 1557 1558 1559 1560 1561 1562 1563 1564 1565 1566 1567 1568 1569 1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588 1589 1590 1591 1592 1593 1594 1595 1596 1597 1598 1599
2004-02-01  Michael Natterer  <mitch@gimp.org>

	Disallow to rename the layer mask. Instead, always name the mask
	"<layer name> mask". Fixes bug #133112 along with some other
	unreported ones.

	* app/core/gimpitem.[ch]: added a boolean return value indicating
	success to GimpItem::rename().

	(gimp_item_real_rename): push an undo step only if the item is
	attached.

	* app/core/gimplayer.c (gimp_layer_rename): refuse renaming if
	the layer is a floating selection floated from a channel
	(renaming a layer's floating selection makes a new layer out
	of the floating selection).

	(gimp_layer_duplicate): use gimp_layer_add_mask() to attach the
	mask's duplicate. Fixes mask refcount brokenness for duplicated
	layer masks.

	(gimp_layer_name_changed): new function. Automatically renames the
	layer mask when the layer's name changes.

	* app/core/gimplayermask.c (gimp_layer_mask_rename): new function
	which refuses renaming.

	(gimp_layer_mask_name_changed): skip the unique name voodoo
	GimpItem does by not chaining up.

	(gimp_layer_mask_set_layer): change the mask's name whenever it is
	attached to a layer.

	* app/text/gimptextlayer.c (gimp_text_layer_rename): fiddle with
	text_layer->auto_rename only if renaming was successful.

	* app/widgets/gimpitemtreeview.c (gimp_item_tree_view_name_edited):
	restore the old name if renaming failed.

	* tools/pdbgen/pdb/drawable.pdb (set_name): return an execution
	error if renaming failed.

	* app/pdb/drawable_cmds.c: regenerated.

1600 1601 1602 1603 1604 1605
2004-02-01  Michael Natterer  <mitch@gimp.org>

	* app/xcf/xcf-load.c (xcf_load_layer): no need to set the layer
	mask's offsets, gimp_layer_add_mask() does this for us. Simplified
	mask property assignments.

1606 1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641
2004-02-01  Michael Natterer  <mitch@gimp.org>

	Reworked random seed handling once more:

	* libgimpwidgets/gimpwidgets.c (gimp_random_seed_new): make sure
	the displayed random seed value is always the one which will be
	used, whether "Randomize" is checked or not.

	* plug-ins/common/blur.c
	* plug-ins/common/plasma.c
	* plug-ins/common/randomize.c
	* plug-ins/common/sinus.c
	* plug-ins/common/snoise.c
	* plug-ins/maze/algorithms.c
	* plug-ins/maze/maze.c: if running interactively, always take
	the seed value produced by the gimp_random_seed widget and don't
	touch it because the widgets honors the "randomize" toggle
	correctly now.

	For noninteractive and last_vals runs, look at the "randomize"
	boolean and generate a seed if it is TRUE.

	Initialize the random number generators from the seed determined
	by either of the above ways and don't fiddle with it in the inner
	algorithms itself.

	* plug-ins/gflare/gflare.c (plugin_run): initialize the GRand
	from the seed unconditionally.

	(ed_make_page_sflare): no need to get the entry from the random
	seed widget to get its adjustment. Instead get the adjustment
	directly.

	(The random handling code of gflare looks somewhat broken, but
	that applies to the whole plug-in).

1642 1643 1644 1645 1646 1647 1648 1649
2004-02-01  Michael Natterer  <mitch@gimp.org>

	* app/plug-in/plug-ins.c (plug_ins_init): when removing a
	duplicate PDB procedure, also remove it from gimp->load_procs and
	gimp->save_procs.  Fixes bug #133099.

	Some general cleanup like moving variables to local scopes.

1650 1651 1652 1653 1654
2004-01-31  Manish Singh  <yosh@gimp.org>

	* plug-ins/common/tiff.c (tiff_warning): use G_VA_COPY for copying
	va_lists.

1655 1656 1657 1658 1659
2004-02-01  Simon Budig  <simon@gimp.org>

	* app/display/gimpdisplayshell-scale.c: initialize variable
	to avoid stupid compiler warning.

1660 1661 1662 1663 1664 1665 1666 1667 1668 1669 1670 1671 1672 1673 1674 1675 1676 1677 1678 1679 1680
2004-02-01  Dave Neary  <bolsh@gimp.org>

	* libgimpwidgets/gimpwidgets.c
	* libgimpwidgets/gimpwidgets.h: Modify random seed widget to 
	allow the user to specify that a seed should be chosen 
	randomly for them (useful to allow re-running random plug-ins 
	several times to get several different results).

	* plug-ins/common/blur.c
	* plug-ins/common/plasma.c
	* plug-ins/common/randomize.c
	* plug-ins/common/sinus.c
	* plug-ins/common/snoise.c
	* plug-ins/gflare/gflare.c
	* plug-ins/maze/algorithms.c
	* plug-ins/maze/maze.c
	* plug-ins/maze/maze.h
	* plug-ins/maze/maze_face.c: Changed appropriately.

	This fixes bug #129529.

1681 1682 1683 1684 1685 1686 1687 1688 1689 1690
2004-01-31  Raphaël Quinet  <quinet@gamers.org>

	* plug-ins/common/tiff.c (tiff_warning, tiff_error): Do not
	display the warning message about unknown tags for unregistered
	private tags (>= 32768).  Fixes bug #131975.  Do not display the
	error message about random access not supported for images using
	JPEG compression.  Fixes bug #132297.  It would be better to allow
	the user to customize which messages should be displayed or not,
	but this can be done in a future release.

1691 1692 1693 1694 1695 1696 1697 1698 1699 1700 1701 1702 1703 1704 1705 1706 1707 1708 1709 1710 1711 1712 1713 1714 1715 1716 1717 1718 1719 1720 1721 1722 1723 1724 1725 1726 1727
2004-01-31  Michael Natterer  <mitch@gimp.org>

	Use the global <Image> accel_group in all docks except the
	toolbox (the latter needs GTK+ 2.4's new menu features).
	Addresses bug #119878:

	* app/gui/buffers-commands.c
	* app/gui/channels-commands.c
	* app/gui/data-commands.c
	* app/gui/documents-commands.c
	* app/gui/drawable-commands.c
	* app/gui/edit-commands.c
	* app/gui/file-commands.c
	* app/gui/gradients-commands.c
	* app/gui/image-commands.c
	* app/gui/layers-commands.c
	* app/gui/plug-in-commands.c
	* app/gui/select-commands.c
	* app/gui/tool-options-commands.c
	* app/gui/tools-commands.c
	* app/gui/vectors-commands.c
	* app/gui/view-commands.c: changed the various return_if_no_foo()
	macros to also accept a GimpDock as user_data.

	* app/gui/image-menu.c (image_menu_update): don't update the
	display related menu items if they don't exist (see below).

	* app/gui/gui.c (gui_display_changed): simplified.

	* app/widgets/gimpimagedock.[ch]: create an "<Image>" item_factory
	and attach its accel_group to the dock. Destroy all display
	related menu items. Destroy the layer stack navigation items
	because their default shortcuts interfere with tree and grid view
	keybindings. Connect to "image_changed" of the dock's private
	context and to "flush" of the image container to update the
	item_factory's state.

1728 1729 1730 1731
2004-01-31  Michael Natterer  <mitch@gimp.org>

	* app/gui/dialogs.c: added some g_return_if_fail().

1732 1733 1734 1735 1736
2004-01-31  Michael Natterer  <mitch@gimp.org>

	* app/widgets/gimpdock.c (gimp_dock_constructor): g_assert() that
	we got the essential construct properties.

1737 1738 1739 1740 1741 1742 1743 1744 1745 1746 1747 1748 1749 1750 1751
2004-01-31  Michael Natterer  <mitch@gimp.org>

	* app/core/gimpimage-convert.[ch]: use gboolean instead of gint
	for "alpha_dither" and "remove_dups" in all public and private
	functions. Properly prototyped private functions. Minor cleanup.

	* app/gui/convert-dialog.c: pass FALSE instead of 0.

	* tools/pdbgen/pdb/convert.pdb: ditto. Also cleaned up a bit: use
	generated checks and documentation for enums, removed duplicate
	check for enum range (spotted by Kevin Cozens).

	* app/pdb/convert_cmds.c
	* libgimp/gimpconvert_pdb.c: regenerated.

1752 1753 1754 1755 1756 1757 1758 1759 1760 1761 1762 1763 1764 1765 1766 1767 1768 1769 1770
2004-01-31  Manish Singh  <yosh@gimp.org>

	* app/base/cpu-accel.c: Make the assembly PIC safe. Fixes #132999.

	* app/composite/Makefile.am
	* app/composite/gimp-composite-3dnow.c
	* app/composite/gimp-composite-mmx.c
	* app/composite/gimp-composite-sse.c
	* app/composite/gimp-composite-sse2.c: Disable code when compiling
	for PIC on ia32, since it'll barf things. These can be fixed later.

	* app/composite/gimp-composite-3dnow-test.c
	* app/composite/gimp-composite-mmx-installer.c
	* app/composite/gimp-composite-mmx-test.c
	* app/composite/gimp-composite-sse-installer.c
	* app/composite/gimp-composite-sse-test.c
	* app/composite/gimp-composite-sse2-installer.c
	* app/composite/gimp-composite-sse2-test.c: Regenerated.

Manish Singh's avatar
Manish Singh committed
1771 1772 1773 1774 1775 1776
2004-01-31  Manish Singh  <yosh@gimp.org>

	* configure.in: define ARCH_X86_64 globally.

	* app/base/cpu-accel.c: remove local definition.

1777 1778 1779 1780 1781 1782 1783 1784
2004-01-30  Michael Natterer  <mitch@gimp.org>

	* app/widgets/gimptooloptionseditor.[ch]: added the scrolled
	window to the GimpToolOptionsEditor struct.

	(gimp_tool_options_editor_tool_changed): set the active tool's
	help ID on the scrolled window. Fixes bug #132969.

1785 1786 1787 1788 1789
2004-01-30  Sven Neumann  <sven@gimp.org>

	* plug-ins/helpbrowser/dialog.c: map the Home button to
	"index.html" and removed the Index button for now.

Michael Natterer's avatar
Michael Natterer committed
1790 1791 1792 1793 1794 1795 1796 1797 1798 1799 1800
2004-01-30  Michael Natterer  <mitch@gimp.org>

	* plug-ins/rcm/rcm_dialog.c (rcm_dialog): fixed help ID.

	* plug-ins/rcm/rcm.[ch]
	* plug-ins/rcm/rcm_callback.[ch]
	* plug-ins/rcm/rcm_dialog.[ch]
	* plug-ins/rcm/rcm_gdk.[ch]
	* plug-ins/rcm/rcm_misc.[ch]: completely reindented, removed
	overly long /*---...---*/ comment lines, fixed spacing.

1801 1802 1803 1804 1805 1806
2004-01-30  Michael Schumacher <schumaml@cvs.gnome.org>

	* libgimpwidgets/gimpwidgets.def: added missing symbols.
	* README.win32: Sven fixed the EXEEXT problem in
	plug-ins/common. Updated README.win32 accordingly.	

1807 1808 1809 1810 1811 1812 1813 1814 1815 1816 1817 1818 1819 1820 1821 1822 1823 1824 1825 1826 1827 1828 1829 1830 1831 1832 1833 1834 1835 1836 1837 1838 1839 1840 1841 1842 1843
2004-01-29  Simon Budig  <simon@gimp.org>

	* app/display/gimpdisplayshell.[ch]: Store the zoom factor as
	float, not as a ratio.

	* app/display/gimpdisplayshell-scale.[ch]: change the API to
	expose the Float instead a weirdly encoded integer. Implement
	functions to get a ratio from the scale factor. Implement a set
	as presets as discussed on the mailinglist. Changed Zoom->Other
	dialog to enable entering a float.

	* app/display/gimpdisplayshell-title.c
	* app/display/gimpnavigationview.c
	* app/gui/image-menu.c
	* app/gui/info-window.c
	* app/tools/gimpmagnifytool.c: changed accordingly.

	* app/core/gimp.[ch]
	* app/display/gimpdisplay.[ch]
	* app/gui/gui-vtable.c
	* app/widgets/widgets-enums.h: Made the various display-creating
	functions accept a float for the scale. Introduce a new
	GimpZoomType: GIMP_ZOOM_TO. Generally adjust the API to use
	floats instead of weird integers.

	* app/core/gimp-edit.c
	* app/core/gimptemplate.c
	* app/display/gimpdisplayshell-callbacks.c
	* app/file/file-open.c
	* app/gui/image-commands.c
	* app/gui/view-commands.[ch]
	* tools/pdbgen/pdb/display.pdb
	* app/widgets/gimpimageview.c
	* app/widgets/gimptoolbox-dnd.c: changed accordingly

	* app/pdb/display_cmds.c: regenerated

1844 1845
	Fixes bug #131964 and makes bug #131563 easy to resolve.

1846 1847 1848 1849 1850 1851 1852 1853 1854 1855 1856 1857 1858 1859 1860 1861 1862 1863 1864 1865 1866 1867 1868 1869 1870 1871 1872
2004-01-29  Michael Natterer  <mitch@gimp.org>

	* app/core/gimpcontext.[ch]: removed the last artefact of context
	signal handling from 1.2:

	GimpContext used to connect to e.g. the current brush's
	"invalidate_preview" and "name_changed" signals and emitted
	"brush_changed" when the callback was invoked. This was needed to
	make 1.2 work, but is conceptually broken with the real model <->
	view approach implemented in the current code.
	This change also optimizes things quite a bit because lots of
	signal emissions are saved.

	Added utility function which finds a container's current object
	after a freeze/thaw.

	* app/widgets/gimpcontainerview.[ch]: added new virtual function
	GimpContainerView::rename_item(). Connect to "name_changed" of the
	corrent container's children and invoke rename_item() accordingly.

	* app/widgets/gimpcontainertreeview.[ch]: removed name_changed
	handler and implement GimpContainerView::rename_item().

	* app/widgets/gimpcontainergridview.c: ditto. the grid view was
	still relying on the removed GimpContext behaviour for updating
	the label showing the sleected item's name.

Michael Natterer's avatar
Michael Natterer committed
1873 1874 1875 1876 1877 1878 1879 1880 1881 1882 1883 1884 1885 1886 1887 1888 1889 1890 1891 1892 1893 1894
2004-01-29  Michael Natterer  <mitch@gimp.org>

	GimpData code review:

	* app/core/gimpdata.c (gimp_data_init): default to
	writable = FALSE and dirty = TRUE.

	* app/core/gimpbrushgenerated.[ch]: added "const gchar *name" to
	gimp_brush_generated_new().

	* app/core/gimpbrush.c
	* app/core/gimpbrushgenerated.c
	* app/core/gimpbrushpipe.c
	* app/core/gimpgradient.c
	* app/core/gimppalette.c
	* app/core/gimppattern.c: set all standard datas to clean and
	internal, check for g_path_is_absolute() in all load functions,
	pass the data's name as construct property to g_object_new()
	instead of calling gimp_object_set_name() after creation, fixed
	some UTF-8 handling, spacing, indentation, coding style, general
	cleanup.

1895 1896 1897 1898 1899 1900 1901
2004-01-29  Sven Neumann  <sven@gimp.org>

	* app/tools/gimpcurvestool.c
	* app/tools/gimpinkoptions.c
	* app/tools/gimplevelstool.c: removed explicit grabs. The pointer
	is already implicitely grabbed while the button is pressed.

1902 1903 1904 1905 1906 1907 1908 1909 1910 1911 1912 1913 1914 1915 1916 1917 1918 1919 1920 1921 1922 1923 1924 1925 1926 1927 1928 1929
2004-01-29  Michael Natterer  <mitch@gimp.org>

	* configure.in: reset binary age because of struct changes below.
	* m4macros/gimp-2.0.m4: require GIMP 1.3.26.

	* libgimpmodule/gimpmodule.h
	* libgimpmodule/gimpmoduledb.h
	* libgimpthumb/gimpthumbnail.h
	* libgimpwidgets/gimpbutton.h
	* libgimpwidgets/gimpchainbutton.h
	* libgimpwidgets/gimpcolorarea.h
	* libgimpwidgets/gimpcolorbutton.h
	* libgimpwidgets/gimpcolordisplay.h
	* libgimpwidgets/gimpcolordisplaystack.h
	* libgimpwidgets/gimpcolornotebook.h
	* libgimpwidgets/gimpcolorscale.h
	* libgimpwidgets/gimpcolorselection.h
	* libgimpwidgets/gimpcolorselector.h
	* libgimpwidgets/gimpdialog.h
	* libgimpwidgets/gimpfileentry.h
	* libgimpwidgets/gimpmemsizeentry.h
	* libgimpwidgets/gimpoffsetarea.h
	* libgimpwidgets/gimppickbutton.h
	* libgimpwidgets/gimppixmap.h
	* libgimpwidgets/gimpsizeentry.h
	* libgimpwidgets/gimpunitmenu.h: added 4 function pointers padding
	to all class structures.

1930 1931 1932 1933 1934 1935 1936 1937 1938 1939 1940 1941 1942 1943 1944 1945 1946 1947 1948 1949 1950 1951 1952 1953 1954 1955 1956 1957 1958 1959 1960 1961 1962 1963 1964 1965 1966 1967 1968 1969 1970 1971 1972 1973 1974 1975 1976 1977 1978 1979 1980 1981 1982 1983 1984 1985 1986 1987 1988 1989 1990 1991 1992 1993 1994 1995 1996 1997 1998 1999 2000 2001 2002 2003 2004
2004-01-28  Michael Natterer  <mitch@gimp.org>

	Added infrastructure to make sure we don't write to the global
	brush, pattern etc. directories. Needed to make this configurable
	because we can't rely on the global directories being read-only,
	having certain names or being otherwise detectable at runtime in a
	sane way. Fixes bug #132214.

	* libgimpbase/gimpdatafiles.[ch]: added "const gchar *dirname" to
	the GimpDataFileData struct so callbacks don't need to call
	g_path_get_dirname() for each file.

	* libgimpwidgets/gimpfileentry.c: made it work with non UTF-8
	encoded filenames.

	* libgimpwidgets/gimppatheditor.[ch]: ditto. Added GUI and API for
	setting/getting a second "writable_path". The widget makes sure
	that the writable_path is always a subset of the path.

	* app/config/gimpconfig-utils.[ch]: added new function
	gimp_config_build_writable_path().

	* app/config/gimpcoreconfig.[ch]: added separate properties for
	the writable brush, pattern, gradient, palette and font paths.

	* app/config/gimprc-blurbs.h: added (still empty) blurbs for the
	new properties.

	* app/core/gimpdata.[ch] (gimp_data_set_filename): added parameter
	"gboolean writable". Set data->writable to FALSE by default. If
	"writable" is passed as TRUE, still check if we can write to the
	file before setting data->writable to TRUE.

	(gimp_data_create_filename): changed "data_path" parameter to
	"dest_dir" and assume dest_dir is writable.

	(gimp_data_duplicate): set data->dirty to TRUE to make sure
	duplicated things will be saved.

	* app/core/gimpbrush.c
	* app/core/gimpbrushgenerated.c
	* app/core/gimpbrushpipe.c
	* app/core/gimpgradient.c
	* app/core/gimppalette.c
	* app/core/gimppattern.c: don't set the data's filename and don't
	touch data->dirty in the _load() functions because that's done by
	the data factory now. Don't touch data->dirty in the _duplicate()
	functions because that's done by gimp_data_duplicate() itself now.

	* app/core/gimpdatafactory.[ch] (gimp_data_factory_new): added
	"writable_property_name" and remember it.
	Added utility function gimp_data_factory_get_save_dir() which
	determines the directory to save new datas to.
	Added public function gimp_data_factory_data_save_single() which
	saves a single data object.
	Make sure new things get saved to the first writable directory
	as specified in preferences.

	* app/core/gimp.c (gimp_real_initialize): pass the writable_paths'
	property names to gimp_data_factory_new().

	* app/widgets/gimpdataeditor.c (gimp_data_editor_save_dirty): use
	gimp_data_factory_data_save_single() instead of implementing
	saving here.

	* app/widgets/gimppropwidgets.[ch] (gimp_prop_path_editor_new):
	added "const gchar *writable_property_name" parameter (can be
	NULL).

	Added the needed callbacks to handle the writable_path and made
	the path_editor and file_entry code aware of non UTF-8 filename
	encodings. Some general cleanup.

	* app/gui/preferences-dialog.c: changed accordingly.

2005 2006 2007 2008 2009 2010
2004-01-28  Sven Neumann  <sven@gimp.org>

	* configure.in: according to the automake docs, we need to add
	$(EXEEXT) explicitely for programs that are conditionally built
	using configure substitutions instead of automake conditionals.

2011 2012 2013 2014 2015
2004-01-28  Michael Natterer  <mitch@gimp.org>

	* app/config/gimpconfig-path.c (gimp_config_path_expand): return
	early if gimp_config_path_expand_only() fails.

2016 2017 2018 2019 2020 2021 2022
2004-01-28  Dave Neary  <bolsh@gimp.org>

	* plug-ins/common/tiff.c: Removed duplicate TIFF entry from save 
	dialog, and made the save handler point to the one that doesn't 
	pre-multiply by alpha. Reported on gimp-user by misfit-x. Also 
	changed default value to not destroy data on save.

2023 2024 2025 2026 2027
2004-01-28  Pedro Gimeno  <pggimeno@wanadoo.es>

	* plug-ins/script-fu/scripts/grid-system.scm: Fix typo that prevented
	using the inverse of the golden ratio (1/g) as a weight in the list.

2028 2029 2030 2031 2032 2033 2034 2035
2004-01-28  Michael Natterer  <mitch@gimp.org>

	* app/widgets/gimphelp-ids.h: updated help IDs for new/reordered
	pages in the prefs dialog.

	* app/gui/preferences-dialog.c (prefs_dialog_new): changed
	accordingly.

2036 2037 2038 2039 2040 2041
2004-01-28  Manish Singh  <yosh@gimp.org>

	* plug-ins/script-fu/siod-wrapper.c (marshall_proc_db_call): validate
	the types of the individual list members when passing parasites.
	Fixes #93806.

2042 2043 2044 2045 2046 2047
2004-01-27  Manish Singh  <yosh@gimp.org>

	* app/paint-funcs/paint-funcs.c: inlined rotate_pointers, changed
	prototypes and casts around so that we're compliant with C99 aliasing
	rules.

2048 2049 2050 2051 2052 2053 2054 2055
2004-01-27  Manish Singh  <yosh@gimp.org>

	* app/composite/gimp-composite-generic.c
	(gimp_composite_overlay_any_any_any_generic)
	* app/paint-funcs/paint-funcs-generic.h (overlay_pixels): use more
	than one temporary when stacking INT_MULTs, to avoid undefined
	values.

2056 2057 2058 2059 2060 2061
2004-01-27  Manish Singh  <yosh@gimp.org>

	* app/paint/gimppaintcore.c (gimp_paint_core_interpolate): Use a real
	GimpVector2 for vector operations, instead of stuffing everything
	into a GimpCoords. C99 aliasing fix.

Manish Singh's avatar
Manish Singh committed
2062 2063 2064 2065 2066 2067 2068
2004-01-27  Manish Singh  <yosh@gimp.org>

	* plug-ins/common/plugindetails.c: removed unused variable.

	* plug-ins/common/nlfilt.c: declare nlfiltRow as inline in the
	function definition as well.

2069 2070 2071 2072 2073 2074 2075 2076 2077 2078
2004-01-27  Manish Singh  <yosh@gimp.org>

	* configure.in: use AM_PATH_GIMPPRINT to get some additional
	sanity checks.

	* acinclude.m4: define AM_PATH_GIMPPRINT here, so we don't have
	add a new autogen dependency.

	* plug-ins/print/Makefile.am: Use GIMPPRINT_{CFLAGS,LIBS}

Simon Budig's avatar
Simon Budig committed
2079 2080 2081 2082 2083 2084 2085 2086 2087 2088 2089 2090
2004-01-28  Simon Budig  <simon@gimp.org>

	Argh, this is getting silly.

	* app/core/gimpscanconvert.c: Fix dumb bug I introduced
	while fixing bug #132036. Instead of always closing a
	polyline to the first point of the vpath close to the
	first point of the current polyline

	I'll close #132036 for the third time now, feel free to
	reopen it when bugs appear...

2091 2092 2093 2094 2095 2096
2004-01-27  Dave Neary  <bolsh@gimp.org>

	* plug-ins/common/tiff.c: Apply patch from Andrey Kiselev to 
	improve defaults when there is no photometric specified for 
	CCITT encoded tiffs. Closes bug #131902.

2097 2098 2099 2100 2101
2004-01-27  Michael Natterer  <mitch@gimp.org>

	* app/gui/layers-commands.c (layers_add_mask_query): use the
	new GIMP_STOCK_LAYER_MASK icon for "Add Layer Mask" dialog.

2102 2103 2104 2105 2106 2107 2108 2109
2004-01-27  Jakub Steiner <jimmac@ximian.com>

	* themes/Default/images/stock-channel-indexed-16.png
	* themes/Default/images/stock-channel-indexed-24.png
	* themes/Default/images/stock-channel-indexed-32.png
	* themes/Default/images/stock-channel-indexed-48.png: replacing
	  placeholders
	
2110 2111 2112 2113 2114 2115 2116 2117 2118 2119
2004-01-27  Michael Natterer  <mitch@gimp.org>

	Re-enabled filling the whole selection using the bucket fill
	tool. Fixes bug #132649.

	* app/tools/gimpbucketfilloptions.[ch]: added boolean property
	"fill-selection" and a GUI for it.

	* app/tools/gimpbucketfilltool.c: changed accordingly.

2120 2121 2122 2123 2124 2125
2004-01-27  Michael Natterer  <mitch@gimp.org>

	* app/gui/image-menu.c (image_menu_entries)
	* app/gui/layers-menu.c (layers_menu_entries): use the new
	GIMP_STOCK_LAYER_MASK icons for "Add Layer Mask".

2126 2127 2128 2129 2130 2131 2132 2133 2134 2135 2136 2137 2138 2139
2004-01-27  Michael Natterer  <mitch@gimp.org>

	* themes/Default/images/Makefile.am
	* themes/Default/images/stock-channel-indexed-16.png
	* themes/Default/images/stock-channel-indexed-24.png
	* themes/Default/images/stock-channel-indexed-32.png
	* themes/Default/images/stock-channel-indexed-48.png
	* libgimpwidgets/gimpstock.[ch]: added placeholders for an INDEXED
	channel icon (copied from the GRAY channel icon). To be replaced...

	* app/widgets/gimppreviewrendererimage.c: use
	GIMP_STOCK_CHANNEL_INDEXED instead of GIMP_STOCK_QUESTION for the
	indexed channel.

2140 2141 2142 2143 2144 2145
2004-01-27  Sven Neumann  <sven@gimp.org>

	* plug-ins/script-fu/scripts/comic-logo.scm: applied a patch from
	Pedro Gimeno to make the logo behave more like it used to in 1.2
	(bug #132493).

2146 2147 2148 2149 2150 2151 2152 2153 2154
2004-01-27  Michael Natterer  <mitch@gimp.org>

	* app/display/gimpdisplayshell-title.c
	(gimp_display_shell_format_title): added '%P' which expands to the
	PDB id of the active drawable. Moved local variables to local
	scopes where they are needed.

	* app/config/gimpconfig-dump.c: document it.

Michael Natterer's avatar
Michael Natterer committed
2155 2156 2157 2158 2159 2160 2161 2162
2004-01-27  Michael Natterer  <mitch@gimp.org>

	* app/display/gimpdisplayshell-dnd.c: some cleanup.

	(gimp_display_shell_bucket_fill): don't use the bucket fill
	options but behave like "Edit -> Fill" and fill with NORMAL/100%.
	Fixes bug #132596.

Manish Singh's avatar
Manish Singh committed
2163 2164 2165 2166
2004-01-26  Manish Singh  <yosh@gimp.org>

	* gimp-zip.in: use new versioning defines.

2167 2168 2169 2170 2171 2172 2173 2174 2175 2176 2177 2178 2179
2004-01-26  Manish Singh  <yosh@gimp.org>

	* configure.in: add m4_defines for gimp_unstable and gimp_full_name,
	and define a GIMP_VISIBLE_NAME based on that.

	* data/misc/Makefile.am
	* data/misc/gimp.applications.in
	* data/misc/gimp.keys.in: made these configured files, so they can 
	use GIMP_APP_VERSION and GIMP_VISIBLE_NAME.

	* data/misc/gimp.desktop.in.in: use GIMP_APP_VERSION and
	GIMP_VISIBLE_NAME.

2180 2181 2182 2183 2184 2185
2004-01-27  Jakub Steiner <jimmac@ximian.com>

	* themes/Default/images/stock-layer-mask-32.png
	* themes/Default/images/stock-layer-mask-48.png: replaced the
	  placeholders

2186 2187 2188 2189 2190 2191 2192 2193 2194 2195 2196 2197 2198 2199 2200
2004-01-27  Michael Natterer  <mitch@gimp.org>

	* themes/Default/images/Makefile.am
	* themes/Default/images/stock-layer-mask-16.png
	* themes/Default/images/stock-layer-mask-24.png
	* themes/Default/images/stock-layer-mask-32.png
	* themes/Default/images/stock-layer-mask-48.png
	* themes/Default/images/stock-selection-border-16.png
	* libgimpwidgets/gimpstock.[ch]: added forgotten layer mask and
	new "border selection" icons from Jimmac (-32 and -48 ones to be
	updated, they are currently copies of the channel icons).

	* app/core/gimplayermask.c (gimp_layer_mask_class_init)
	* app/gui/image-menu.c (image_menu_entries): use them.

2201 2202 2203 2204 2205 2206 2207 2208 2209 2210
2004-01-27  Sven Neumann  <sven@gimp.org>

	* plug-ins/gimpressionist/brush.c
	* plug-ins/gimpressionist/gimp.c
	* plug-ins/gimpressionist/gimpressionist.[ch]
	* plug-ins/gimpressionist/paper.c
	* plug-ins/gimpressionist/presets.c: fixed a crash (bug #132027),
	got rid of some possible buffer overflows and fixed platform issues
	like hardcoding '/' as the path separator.

2211 2212 2213 2214 2215 2216 2217 2218
2004-01-26  Michael Natterer  <mitch@gimp.org>

	* app/gui/image-menu.c (image_menu_entries): use
	GIMP_STOCK_FLOATING_SELECTION for "Select->Float".

	(image_menu_update): set "Layer->Merge Down" insensitive for the
	bottom layer.

2219 2220 2221 2222 2223 2224
2004-01-26  Simon Budig  <simon@gimp.org>

	* app/core/gimpscanconvert.c: use the modern libart way
	to uncross/rewind a libart SVP. This time really fixes
	bug #132036 (please test it though...).

2225 2226 2227 2228 2229
2004-01-26  Sven Neumann  <sven@gimp.org>

	* app/display/gimpdisplayshell-selection.c: don't draw the
	outbounds selection when the selection is hidden (bug #132595).

2230 2231 2232 2233 2234 2235 2236
2004-01-26  Sven Neumann  <sven@gimp.org>

	* app/text/gimptext-xlfd.c (gimp_text_font_size_from_xlfd):
	account for the fact that XLFD stores point sizes in decipoints.

	* app/text/gimptext-vectors.c: s/TEXT_DEBUG/GIMP_TEXT_DEBUG/

2237 2238 2239 2240 2241 2242 2243
2004-01-26  Sven Neumann  <sven@gimp.org>

	* app/tools/gimpcurvestool.c
	* app/widgets/gimphistogramview.c: use dark_gc instead of
	text_aa_gc to draw the histogram and curves grid lines. dark_gc is
	slightly lighter, looks better and fixes bug #132565.

2244 2245 2246 2247 2248 2249 2250 2251 2252 2253 2254 2255 2256 2257 2258 2259 2260 2261 2262 2263 2264 2265 2266 2267 2268 2269 2270 2271 2272
2004-01-26  Michael Natterer  <mitch@gimp.org>

	* app/core/gimpimage.[ch]: removed gimp_image_owns_item() again.

	* app/core/gimpitem.[ch]: instead, added new virtual function
	GimpItem::is_attached().

	* app/core/gimpchannel.c
	* app/core/gimplayer.c
	* app/core/gimplayermask.c
	* app/core/gimpselection.c
	* app/vectors/gimpvectors.c: implement it.

	* app/core/gimp-edit.c
	* app/core/gimpdrawable-transform.c
	* app/core/gimplayer-floating-sel.c
	* app/text/gimptext-compat.c
	* tools/pdbgen/pdb/edit.pdb
	* tools/pdbgen/pdb/floating_sel.pdb
	* tools/pdbgen/pdb/selection.pdb
	* tools/pdbgen/pdb/text_tool.pdb
	* tools/pdbgen/pdb/transform_tools.pdb_ changed accordingly.

	* app/pdb/edit_cmds.c
	* app/pdb/floating_sel_cmds.c
	* app/pdb/selection_cmds.c
	* app/pdb/text_tool_cmds.c
	* app/pdb/transform_tools_cmds.c: regenerated.

2273 2274 2275 2276 2277 2278 2279 2280 2281 2282 2283 2284 2285 2286 2287 2288 2289 2290 2291 2292 2293 2294 2295 2296 2297 2298 2299 2300 2301 2302 2303 2304 2305 2306 2307 2308 2309 2310 2311 2312 2313 2314 2315 2316 2317 2318 2319 2320 2321 2322 2323 2324 2325 2326 2327 2328 2329 2330 2331 2332 2333 2334 2335 2336 2337 2338 2339 2340
2004-01-26  Michael Natterer  <mitch@gimp.org>

	* plug-ins/script-fu/scripts/unsharp-mask.scm: add the layer to
	the image before pasting to it. Fixes bug #132504.

	Fixed the underlying problem: make it impossible to attach
	floating selections to drawables which are not currently part of
	the image's layer or channel stacks.
	Also cleaned up image <-> floating_sel interaction:

	* app/core/gimplayer-floating-sel.[ch] (floating_sel_attach):
	added assertion that the drawable is part of the image (see below).
	Don't call gimp_image_floating_selection_changed(), it's emitted
	by gimp_image_add_layer() now.

	(floating_sel_remove)
	(floating_sel_anchor): don't emit "floating_selection_changed",
	it's emitted by gimp_image_remove_layer() now.

	(floating_sel_anchor): removed the fix for bug #132162 because
	gimp_image_remove_layer() behaves correctly now (see below).

	Renamed floating_sel_reset() to floating_sel_activate_drawable().
	Added g_return_if_fail() all over the place.

	* app/core/gimpimage.[ch]: added new function gimp_image_owns_item()
	which return TRUE if the passed item is part of the image.

	(gimp_image_add_layer): emit "floating_selection_changed" here if
	needed.

	(gimp_image_remove_layer): emit "floating_selection_changed" if
	needed, don't try to activate a layer if we called
	floating_sel_activate_drawable().
	This is the real fix for bug #132162.

	* app/core/gimpimage-undo-push.c (undo_pop_layer): apply the same
	fixes as to gimp_image_add,remove_layer(). Don't call
	gimp_drawable_invalidate_preview() on the previously active layer
	because that's done by gimp_image_set_active_layer() now.

	* app/xcf/xcf-load.c: remember the "floating_sel_drawable" in the
	XcfInfo struct and attach it *after* all layers and channels are
	loaded to avoid attaching the floating selection to an
	out-of-image drawable.

	* app/core/gimp-edit.c (gimp_edit_paste)
	* app/core/gimpdrawable-transform.c (gimp_drawable_transform_affine,
	gimp_drawable_transform_flip, gimp_drawable_transform_rotate)
	* app/core/gimpselection.c (gimp_selection_float)
	* app/text/gimptext-compat.c (text_render): added checks for
	gimp_image_owns_item() in all functions which can produce
	floating selections.

	* tools/pdbgen/pdb/edit.pdb
	* tools/pdbgen/pdb/floating_sel.pdb
	* tools/pdbgen/pdb/selection.pdb
	* tools/pdbgen/pdb/text_tool.pdb
	* tools/pdbgen/pdb/transform_tools.pdb: added checks for
	gimp_item_owns_image() and return an execution error if invoked
	with a drawable which is not part of the image.

	* app/pdb/edit_cmds.c
	* app/pdb/floating_sel_cmds.c
	* app/pdb/selection_cmds.c
	* app/pdb/text_tool_cmds.c
	* app/pdb/transform_tools_cmds.c: regenerated.

2341 2342 2343 2344 2345 2346 2347 2348
2004-01-26  Michael Natterer  <mitch@gimp.org>

	* app/xcf/xcf-save.c (xcf_save_channel): store the correct offset
	of the floating selection's drawable. This bug has been around
	since 1.2 (!!!) and made it impossible to save images correctly
	where the floating selection's drawable was a channel or layer
	mask.

2349 2350 2351 2352 2353
2004-01-26  Sven Neumann  <sven@gimp.org>

	* autogen.sh: prefer automake-1.7 over 1.8 since there are issues
	with the latter.

2354 2355 2356 2357 2358 2359 2360 2361 2362 2363 2364 2365 2366 2367 2368
2004-01-26  Manish Singh  <yosh@gimp.org>

	* app/core/gimpdrawable-blend.c (gradient_fill_region): use memcpy
	instead of casted assignment for storing HSV values in rbd.fg/bg,
	for C99 aliasing compliance.

	* app/xcf/xcf-load.c (xcf_load_layer_mask): use a GimpChannel *
	explictly for xcf_load_channel_props, for the above reason.

	* app/xcf/xcf-save.c (xcf_save_prop): use a temporary guint32 for
	saving property types, for the above reason.

	* app/core/gimpparasitelist.c (gimp_parasite_list_deserialize): plug
	a memory leak, since data is copied on parasite creation.
	
2369 2370 2371 2372 2373 2374
2004-01-26  Simon Budig  <simon@gimp.org>

	* app/tools/gimpvectortool.c: do nothing in _button_press when
	the tool is in the VECTORS_FINISHED state.
	Fixes bug #132508.

2375 2376 2377 2378 2379 2380
2004-01-25  Manish Singh  <yosh@gimp.org>

	* plug-ins/common/postscript.c: use GSpawn instead of popen, -dBATCH,
	fixes #108659 for this plugin. Thanks to Peter Kirchgessner for the
	patch.

2381 2382 2383 2384
2004-01-25  Sven Neumann  <sven@gimp.org>

	* app/text/gimptextlayout.c (gimp_text_layout_position): fixed
	text positioning for fonts where glyphs extend the logical
Sven Neumann's avatar
Sven Neumann committed
2385
	rectangle (fixes bug #132495).
2386

Sven Neumann's avatar
Sven Neumann committed
2387 2388 2389 2390 2391 2392 2393 2394 2395 2396 2397 2398 2399 2400 2401 2402
2004-01-25  Sven Neumann  <sven@gimp.org>

	* app/gui/info-window.c (info_window_create): don't update the fields
	here...

	* app/gui/view-commands.c (view_info_window_cmd_callback): ... but
	here when the info window is connected to the display shell. Patch
	from Shlomi Fish; fixes bug #132329.

	* app/gui/info-window.c (info_window_update_extended): fixed update
	of info window in automatic mode. Bug #118084, patch by Shlomi Fish.

	* autogen.sh: check for automake-1.8 also.

	* HACKING: note that automake-1.8 should work as well.

2403 2404 2405 2406 2407 2408 2409 2410 2411 2412 2413 2414 2415
2004-01-24  Michael Natterer  <mitch@gimp.org>

	* tools/pdbgen/pdb/color.pdb (levels, curves): fiddle with the
	passed channel index only for GRAYA drawables, not for all GRAY
	drawables. Fixes bug #132322.

	* tools/pdbgen/pdb/color.pdb: regenerated.

	* app/tools/gimpcurvestool.[ch]
	* app/tools/gimplevelstool.[ch]: fixed the same bug here. It never
	occured because the "channel" field was accidentially initialized
	with the correct value and never changed after.

2416 2417 2418 2419 2420
2004-01-23  Simon Budig  <simon@gimp.org>

	* plug-ins/common/mosaic.c: properly use src_rgn.rowstride when
	initializing the target region. Fixes bug #132271.

2421 2422 2423 2424
2004-01-23  Manish Singh  <yosh@gimp.org>

	* configure.in: made the pygtk minimum version an m4 define as well.

2425 2426 2427 2428 2429 2430 2431 2432 2433 2434 2435 2436 2437 2438 2439 2440 2441
2004-01-23  Michael Natterer  <mitch@gimp.org>

	* app/app_procs.c
	* app/errors.c
	* app/main.c
	* app/config/gimpconfigwriter.c
	* app/core/gimpdata.c
	* app/core/gimpdatafactory.c
	* app/gui/user-install-dialog.c
	* app/plug-in/plug-ins.c
	* app/vectors/gimpvectors-import.c: some more gimp_filename_to_utf8().

	* libgimp/gimp.c
	* libgimpmodule/gimpmodule.c
	* libgimpmodule/gimpmoduledb.c: use it here, too, now that is in
	libgimpbase.

2442 2443 2444 2445
2004-01-23  Henrik Brix Andersen  <brix@gimp.org>

	* plug-ins/common/.cvsignore: s/ps/postscript/ to shut up cvs.

2446 2447 2448 2449 2450 2451
2004-01-22  Manish Singh  <yosh@gimp.org>

	* plug-ins/common/plugin-defs.pl
	* plug-ins/common/Makefile.am: renamed ps to postscript, so automake
	doesn't get confused.

2452 2453 2454 2455 2456
2004-01-22  Sven Neumann  <sven@gimp.org>

	* configure.in: libgimpmodule depends on gmodule-2.0 and gobject-2.0.
	Incorporate both into GMODULE_CFLAGS and GMODULE_LIBS.

2457 2458 2459 2460 2461 2462
2004-01-22  Sven Neumann  <sven@gimp.org>

	* debian/*: removed outdated and unmaintained debian package
	description. The debian package is well maintained without keeping
	these files in our CVS tree.

Ville Pätsi's avatar
Ville Pätsi committed
2463 2464 2465 2466
2004-01-22  Ville Pätsi  <drc@gimp.org>

	* gimp.spec.in: Added a depedency for libexif

2467 2468 2469 2470 2471 2472 2473 2474 2475 2476 2477 2478 2479 2480 2481 2482 2483 2484
2004-01-22  Michael Natterer  <mitch@gimp.org>

	* plug-ins/common/gbr.c
	* plug-ins/common/pat.c: store the brush/pattern's name in a
	parasite attached to the image. The parasite overrides the
	RUN_WITH_LAST_VALS logic if it exists. Consistently set the
	description as the layer's name, but ignore the layer's name
	when saving because it may have been modified by exporting.
	Fixes bug #131450.

	Misc. cleanup/fixes: Don't assume that strncpy() nul-terminates
	the buffer, use sizeof() instead of magic numbers, sanitize
	descriptions using gimp_any_to_utf8(), always use strncpy()
	instead of strcpy().

	* devel-docs/parasites.txt: document the "gimp-brush-name" and
	"gimp-pattern-name" parasites.

Tor Lillqvist's avatar
Tor Lillqvist committed
2485 2486 2487 2488
2004-01-22  Tor Lillqvist  <tml@iki.fi>

	* gimptool-win32.c.in (get_prefix): Use GIMP_APP_VERSION.

2489 2490 2491 2492 2493
2004-01-21  Manish Singh  <yosh@gimp.org>

	* m4macros/gimp-2.0.m4: quote AM_PATH_GIMP_2_O properly so automake
	1.8 won't whine at us.

2494 2495 2496 2497 2498 2499
2004-01-21  Manish Singh  <yosh@gimp.org>

	* configure.in
	* plug-ins/FractalExplorer/Makefile.am: renamed obnoxiously long
	fractalexplorer-examples directory to simply examples.

2500 2501 2502 2503 2504 2505 2506 2507 2508 2509 2510 2511 2512 2513 2514
2004-01-21  Manish Singh  <yosh@gimp.org>

	* configure.in: modernized, made a lot of things m4 macros, and made
	versioning a lot more finegrained, in anticipation for post-2.0.

	* autogen.sh: bumped up libtool and glib minimum requirements to match
	reality.

	* gimp-2.0.pc.in
	* gimpthumb-2.0.pc.in
	* gimpui-2.0.pc.in: adapted to new versioning variables, and bring
	in RT_LIBS when needed.

	* */*/Makefile.am: adapted to new versioning variables.

2515 2516 2517 2518 2519 2520 2521
2004-01-22  Michael Natterer  <mitch@gimp.org>

	* app/core/gimplayer-floating-sel.c (floating_sel_anchor):
	explicitly activate the drawable the floating selection was
	attached to (function was relying on implicit voodoo that
	happened 1.2). Fixes bug #132162.

2522 2523 2524 2525 2526 2527 2528 2529 2530 2531 2532 2533 2534 2535 2536 2537 2538 2539 2540 2541 2542 2543
2004-01-22  Michael Natterer  <mitch@gimp.org>

	* app/core/gimpitem.[ch]: added "gboolean use_default_values"
	to GimpItem::stroke().

	* app/core/gimpselection.c: changed accordingly.

	* app/core/gimpchannel.c
	* app/vectors/gimpvectors.c: if use_default_values is TRUE, don't
	use the GimpPaintOptions passed in the GimpPaintInfo, but create a
	new one.

	* app/gui/stroke-dialog.c: pass FALSE so the values as set in the
	tool options are used.

	* tools/pdbgen/pdb/edit.pdb
	* tools/pdbgen/pdb/paths.pdb: pass TRUE so tool options settings
	don't affect PDB stroke calls. Fixes part 2 of bug #132145.

	* app/pdb/edit_cmds.c
	* app/pdb/paths_cmds.c: regenerated.

2544 2545 2546 2547 2548 2549 2550 2551 2552
2004-01-22  Simon Budig  <simon@gimp.org>

	* app/gui/dialogs-commands.c: replaced the indexed palette in
	the default "Layers, Channels, Paths"-Dock (as created by the
	menu in the toolbox) with the Undo History, since the indexed
	palette is pretty useless most of the time and the new setup
	at least matches the upper half of the dockable that comes up
	after a new user starts the Gimp the first time.

2553 2554 2555 2556 2557
2004-01-21  Michael Natterer  <mitch@gimp.org>

	* app/gui/dialogs-commands.c: show the image menu in newly created
	layers, channels & paths docks.

2558 2559 2560 2561 2562 2563 2564 2565 2566 2567 2568 2569 2570 2571 2572 2573 2574 2575 2576 2577 2578 2579 2580 2581 2582 2583 2584 2585 2586 2587
2004-01-21  Michael Natterer  <mitch@gimp.org>

	* app/tools/gimptool.[ch]: added boolean return value to
	GimpTool::initialize(). Returning FALSE means the tool could not
	be initialized and doesn't want to receive button events.
	Return TRUE from the default implementation.

	* app/tools/tool_manager.[ch]: added boolean return value to
	tool_manager_initialize_active(). Don't set the tool's display or
	drawable if initialize() returns FALSE.

	* app/display/gimpdisplayshell-callbacks.c: don't send button
	events to the tool if initialize() returns FALSE.

	* app/tools/gimpbrightnesscontrasttool.c
	* app/tools/gimpcolorbalancetool.c
	* app/tools/gimpcolorizetool.c
	* app/tools/gimpcurvestool.c
	* app/tools/gimphuesaturationtool.c
	* app/tools/gimplevelstool.c
	* app/tools/gimpposterizetool.c
	* app/tools/gimpthresholdtool.c: return FALSE for NULL and indexed
	drawables.

	* app/tools/gimpimagemaptool.c: always return TRUE because our
	subclasses already checked if the active drawable is OK.

	* app/tools/gimptransformtool.c: return FALSE for layers with
	masks. Fixes bug #132089. Some random cleanups.

2588 2589 2590 2591 2592 2593 2594
2004-01-21  DindinX  <david@dindinx.org>

	* plug-ins/common/plugindetails.c: correctly resize both panels of the
	GTK_PANED. This fixes bugs #132032.

	This plug-ins still needs work.

2595 2596 2597 2598 2599 2600 2601 2602
2004-01-21  Michael Natterer  <mitch@gimp.org>

	* app/core/gimpdrawable-transform.c: use RINT() instead of ROUND()
	to calculate the coordinates of the transformed tiles to avoid
	off-by-one errors when affine-transforming, flipping and rotating
	drawables with negative offsets.
	Fixes the off-by-one part of bug #132089.

2603 2604 2605 2606 2607 2608
2004-01-21  Tor Lillqvist  <tml@iki.fi>

	* app/gui/themes.c (themes_list_themes_foreach): Fix undefined
	behaviour. Fixes crash in bringing up the Preferences dialog when
	compiled with Sun's compiler.

2609 2610 2611 2612 2613 2614 2615
2004-01-21  Michael Natterer  <mitch@gimp.org>

	* app/core/gimpdrawable-transform.c (gimp_drawable_transform_paste): 
	call gimp_drawable_invalidate_boundary() because the drawable's
	size may have changed. Fixes bug #132077. Removed call to
	floating_sel_invalidate() which is now redundant.

2616 2617 2618 2619 2620 2621 2622 2623 2624 2625 2626 2627 2628 2629 2630 2631 2632 2633
2004-01-21  Michael Natterer  <mitch@gimp.org>

	* app/gui/info-dialog.[ch]: renamed info_dialog_popdown() to
	info_dialog_hide() and info_dialog_popup() to info_dialog_present().
	Added info_dialog_show() which just shows the dialog without
	calling gtk_window_present().

	* app/gui/info-window.c
	* app/gui/view-commands.c
	* app/tools/gimptransformtool.c: changed accordingly.

	* app/tools/gimpcroptool.c
	* app/tools/gimpperspectivetool.c
	* app/tools/gimprotatetool.c
	* app/tools/gimpscaletool.c
	* app/tools/gimpsheartool.c: use info_dialog_show() so the dialog
	doesn't grab the focus away from the canvas. Fixes bug #132041.

2634 2635 2636 2637 2638 2639 2640 2641 2642 2643 2644 2645
2004-01-21  Simon Budig  <simon@gimp.org>

	* app/core/gimpscanconvert.c: removed the call to
	art_vpath_perturb, since it apparently is responsible for the
	artefacts described in bug #132036. I don't really understand
	why these artefacts were happening in the first place, because
	in theory art_vpath_perturb should not do any harm.
	
	Also properly close closed polygons.

	Hopefully fixes #132036, please test this.

2646 2647 2648 2649 2650 2651 2652 2653
2004-01-20  Sven Neumann  <sven@gimp.org>

	* tools/gimp-remote.c: added new command-line options --existing
	and --query. The former allows to get the old behaviour back and
	the latter might be useful one day.

	* docs/gimp-remote-1.3.1.in: document the new options.

2654 2655 2656 2657 2658 2659 2660 2661 2662 2663 2664 2665 2666 2667 2668 2669
2004-01-20  Michael Natterer  <mitch@gimp.org>

	* app/widgets/gimphelp-ids.h: added help IDs for the libgimp
	export and unit dialogs.

	* libgimp/gimpexport.c
	* libgimpwidgets/gimpunitmenu.c: replaced html links by the new
	help IDs.

	* plug-ins/*/*.c: replaced all html help links by help IDs. A
	plug-in's help ID is its procedure name with '_' relaced by '-'.

	(e.g. file_tiff_save's help ID is file-tiff-save)

	Did some random indentation and whitespace cleanup.

2670 2671 2672 2673 2674
2004-01-20  Sven Neumann  <sven@gimp.org>

	* tools/gimp-remote.c: when starting a new gimp, pass it the
	display gimp-remote is running on.

Sven Neumann's avatar