Now that the build target is rooted, we can fix the real issue, which is
a file being passed when a string is expected.

Fixes #772

Forgot to set this when simplifying.

Daniel Buch Hansen authored Jan 21, 2019 and Christian Hergert committed Jan 21, 2019

Fixes #771

Simone Piccardi authored Jan 21, 2019 and Christian Hergert committed Jan 21, 2019

When editing a nested snippet, the run-length of the parent can get out
of sync. This copies the edited sub-snippet content into the parent's
containing chunk so that editing can continue with proper run lengths.

Signed-off-by: Christian Hergert <chergert@redhat.com>

This can be a directory now, which breaks the normal Cargo.toml expectation
we had previously.

Fixes #770

Now that the master SDK has the new Adwaita theme, we can switch over to
the corresponding dark theme in Builder.

Based on new mockups.

Fixes #766

This is some incremental work to implement the buttons in main content
area instead of the header bar.

More work needs to be done, but this gets things started.

This simplifies our diff tracking by using the hunk callbacks instead of
the per-line callbacks. It's loosely based around what I discovered other
git gutters to be using.

This can be used to store marks about lines, so that we can keep that
state separated from other state in the change monitor.

This avoids a failure case when saving a buffer already in the state of
saving.

We might want to make this chain onto a previous task in the future, but
for now this fixes #768

We might want to open the file in another workbench. If we detect a
workbench with a closer match, use it.

This needs testing, but a cursory check of what button number to expect
would indicate that this should do the trick.

We try to discover the file from the filename using the resovle_file API
from the workbench. That is somewhat difficult because we don't have the
active CWD from the point when the line was printed. So we do a bit of
discovery in case we don't find it.

We will want to extend this handle some other filename variants such as
without line or columns. But this is a start.

This helper can be used to locate a file by a given path. It might need to
start scanning from the current build directory, or the source directory.

If it fails, it may search for the file within the root for a file matching
the filename.

This allows usage from a worker thread, which can be convenient to avoid
spawning a secondary worker thread.