Okay I think it should all be good to go now! I'm new to opensource so let me know if there's something I missed/need to fix! :)
Wyatt Turner (3e224af4) at 05 Apr 06:40
Added error log when failing to join room by ID
... and 2 more commits
Wyatt Turner (008cff4c) at 05 Apr 06:04
Added error log when failing to join room by ID
... and 1 more commit
Wyatt Turner (5fdc5769) at 05 Apr 05:51
Added error log when failing to join room by ID
... and 1 more commit
Wyatt Turner (64ddbe53) at 05 Apr 05:42
Added error log when failing to join room by ID
... and 1 more commit
I went ahead and pushed a change which captures the error from the match statement and prints it that way which should help.
Wyatt Turner (d896f36d) at 01 Apr 19:55
Added error log when failing to join room by ID
Wyatt Turner (9b9cbdc8) at 01 Apr 18:40
Remove clearing of "join_room_name" entry to avoid a race condition
Good catch! I believe I forgot to push the commit which included that which is a little embarrassing. I'll try to include that now.
This is my attempt at a bug fix for the issue #735.
The problem was that the UI entry "join_room_name" was being cleared before it was ever actually used in the function "join_to_room()" which was causing the malformed id since it was just an empty string.
My solution was to move the clearing of the entry to after that value is used in join_to_room() since this seemed like the simplest solution. Just note this would make it so that the UI is being updated from /fractal-gtk/src/ui/connect/join_room.rs to /fractal-gtk/src/appop/room.rs which might not be ideal but since the value was already being received directly from the UI element I thought this shouldn't be a problem.
Wyatt Turner (2a25d7da) at 31 Mar 06:20
Moved clearing of "join_room_name" entry