1. 27 Nov, 2018 1 commit
  2. 25 Nov, 2018 2 commits
  3. 22 Nov, 2018 2 commits
  4. 19 Nov, 2018 2 commits
    • Thomas Haller's avatar
      tests: simplify tests · bd585d68
      Thomas Haller authored
      - use cleanup attribute for freeing memory
      
      - construct strings like SRCDIR"/filename" directly, instead
        using g_strdup_printf().
      
      - add helper macros like _get_setting_vpn() to get the settings
        from the connections. This way, we assert at one place.
      
      - drop code comments that only serve to as visual delimiters for
        the code. The code itself should be structured well, making these
        comments redundant noise. If visual structuring would be necessary,
        a double-blank-line or a line filled with /***/ would be better.
        But here that is not necessary, because the tests are simple enough,
        in particular after getting rid of all the noise.
      bd585d68
    • cyrinux's avatar
      add ncp-disable support to disable cipher negotiation · add21332
      cyrinux authored
      [thaller@redhat.com: fix spelling for negotiation]
      
      GNOME/NetworkManager-openvpn!12
      add21332
  5. 11 Nov, 2018 2 commits
  6. 08 Nov, 2018 1 commit
    • Francesco Giudici's avatar
      properties: drop file extension check when importing a file · 8802a1f8
      Francesco Giudici authored
      We don't enforce any policy on the file name/extension when
      exporting a connection, but we do it when importing one.
      So, one could end up exporting a connection succesfully and
      not being able to import it back.
      Example:
        ~]$ nmcli connection export ovpn_test pippo.vpn
        ~]$ nmcli connection import file pippo.vpn  type openvpn
        Error: failed to import 'pippo.vpn': unknown OpenVPN file extension.
      
      Moreover, when importing, we enforce the user to specify the connection
      type (openvpn in this case).
      
      Drop the policy on the file name extension when importing openvpn
      connections.
      8802a1f8
  7. 28 Oct, 2018 1 commit
  8. 27 Oct, 2018 1 commit
  9. 24 Oct, 2018 2 commits
  10. 17 Oct, 2018 3 commits
  11. 15 Oct, 2018 1 commit
  12. 11 Oct, 2018 1 commit
  13. 02 Oct, 2018 3 commits
  14. 01 Oct, 2018 10 commits
  15. 20 Sep, 2018 1 commit
  16. 19 Sep, 2018 1 commit
  17. 28 Aug, 2018 1 commit
  18. 27 Aug, 2018 1 commit
  19. 21 Aug, 2018 1 commit
  20. 03 Aug, 2018 1 commit
  21. 24 Jul, 2018 1 commit
    • Thomas Haller's avatar
      properties: sanitize newlines ('\n') when exporting ovpn file · 79fe14bc
      Thomas Haller authored
      Openvpn's ovpn configuration files cannot contain newlines as values,
      because
      
      - the parser reads the ovpn file line by line, splitting lines are
        newlines. Hence, quotation spaning multiple lines is not supported
        to express '\n'.
      - special escape sequences like "\n" or "\012" are not supported
        either. Escape sequences are only for "\'", "\"", and verbatim
        spaces like "\ " (but not newline itself).
      
      Note that newlines can be part of a valid configuration, for example
      as part of filenames.
      
      Instead of breaking the line, still try to escape the newline
      with "\n".
      
      Previously, openvpn would fail with
      
          $ openvpn --config my.ovpn
          Options error: No closing single quotation (') in my.ovpn:1
      
      Now, the configuration file has no more such line breaks and openvpn
      issues a warning instead:
      
          $ openvpn --config my.ovpn
          Options warning: Bad backslash ('\') usage in my.ovpn:1: remember that backslashes are treated as shell-escapes and if you need to pass backslash characters as part of a Windows filename, you should use double backslashes such as "c:\\openvpn\\static.key"
      
      The point of this change is not that the new warning behavior is better
      than the previous error behavior (it's arguably worse). However, I think
      if we write an invalid file, it's better to have an invalid escape sequence,
      instead of a spurious line break.
      
      GNOME/NetworkManager-openvpn!5
      79fe14bc
  22. 22 Jul, 2018 1 commit