1. 09 Oct, 2018 2 commits
  2. 08 Oct, 2018 2 commits
  3. 07 Oct, 2018 1 commit
  4. 06 Oct, 2018 1 commit
  5. 05 Oct, 2018 1 commit
  6. 04 Oct, 2018 1 commit
    • Simon McVittie's avatar
      m4macros: Allow information from pkg-config to be overridden · 4bb16f48
      Simon McVittie authored
      By using PKG_CHECK_VAR, we declare $GLIB_COMPILE_SCHEMAS,
      $GLIB_GENMARSHAL, $GOBJECT_QUERY, $GLIB_MKENUMS and
      $GLIB_COMPILE_RESOURCES as Autoconf "precious variables" with AC_ARG_VAR,
      similar to $PKG_CONFIG and $CC, so that they can be put on a configure
      command line:
      
          ./configure GLIB_COMPILE_RESOURCES=my-glib-compile-resources
      
      If they are set to a non-empty value, PKG_CHECK_VAR will use that
      instead of auto-detecting from pkg-config, so that builders can
      override them, for example when cross-compiling.
      
      Similarly, use the standard PKG_CHECK_MODULES macro to get GLib's CFLAGS
      and LIBS.
      
      It's possible that most of the rest of each macro can also disappear,
      but for the moment I've given them the benefit of the doubt.
      
      This does result in printing "checking for GLIB" twice (once for
      PKG_CHECK_MODULES and once for GLib's custom checks), but if you're
      using Autotools, you probably don't have a strong objection to overly
      verbose output.
      Signed-off-by: Simon McVittie's avatarSimon McVittie <smcv@collabora.com>
      4bb16f48
  7. 03 Oct, 2018 2 commits
  8. 02 Oct, 2018 5 commits
  9. 01 Oct, 2018 4 commits
    • Philip Withnall's avatar
      gtask: Check an error hasn’t been returned when calling g_task_return*() · bea37709
      Philip Withnall authored
      These functions already check to see if a successful result has already
      been returned; expand them to also check to see if an error has been
      returned.
      
      We can’t just check GTask.result_set, as that’s actually an indicator
      for whether the GTask.result member is filled — when
      g_task_propagate_*() is called, it’s cleared again. We need a new state
      bit.
      Signed-off-by: Philip Withnall's avatarPhilip Withnall <withnall@endlessm.com>
      
      GNOME/glib#1525
      bea37709
    • Philip Withnall's avatar
      tests: Fix location of an unref in the GTask tests · 03232bd6
      Philip Withnall authored
      This method drops the last reference *it* owns to the GTask, but then
      continues to call methods on the GTask. This wasn’t resulting in
      failures because a ref in another thread kept the GTask alive, but
      that’s quite dodgy.
      Signed-off-by: Philip Withnall's avatarPhilip Withnall <withnall@endlessm.com>
      03232bd6
    • Philip Withnall's avatar
      Merge branch 'wjt/g_desktop_app_info_get_string_list' into 'master' · 846a6145
      Philip Withnall authored
      Add g_desktop_app_info_get_string_list(); fix g_key_file_free()
      
      See merge request GNOME/glib!339
      846a6145
    • Will Thompson's avatar
      gdesktopappinfo: add get_string_list() function · 5ca9eca6
      Will Thompson authored
      The X-Flatpak-RenamedFrom key is used in .desktop files to identify past
      names for the desktop file. It is defined to be a list of strings.
      However, there was previously no correct way to retrieve a list of
      strings from the GKeyFile wrapped by GDesktopAppInfo, short of
      re-parsing the file with GKeyFile.
      
      Note that doing something like:
      
          g_strsplit (g_desktop_app_info_get_string (...), ";", -1)
      
      is not correct: the raw value "a\;b;" represents the one-element list
      ["a;b"], but g_key_file_get_string() rejects the sequence "\;", and so
      g_desktop_app_info_get_string() returns NULL in this case. (Of course, a
      .desktop file with a semicolon in its name is a pathological case.)
      
      Add g_desktop_app_info_get_string_list(), a trivial wrapper around
      g_key_file_get_string_list(), similar to g_desktop_app_info_get_string()
      and co.
      
      The change from g_key_file_free() to g_key_file_unref() in the test is
      needed because g_key_file_free() clears the contents of the keyfile.
      This is fine for all the fields which are eagerly loaded and copied into
      GDesktopAppInfo, but not when we want to access arbitrary stuff from the
      keyfile.
      5ca9eca6
  10. 29 Sep, 2018 3 commits
  11. 28 Sep, 2018 5 commits
  12. 27 Sep, 2018 4 commits
  13. 26 Sep, 2018 5 commits
  14. 25 Sep, 2018 4 commits