- 09 Oct, 2018 2 commits
-
-
Ting-Wei Lan authored
Since we are unable to promote our FreeBSD runner to a shared runner, we can only enable it in GNOME group. This should avoid problems when submitting merge requests from forks.
-
Emmanuele Bassi authored
gdbusproxy: Document blocking guarantees of constructors Closes #734 See merge request GNOME/glib!380
-
- 08 Oct, 2018 2 commits
-
-
Philip Withnall authored
m4macros: Allow information from pkg-config to be overridden See merge request GNOME/glib!375
-
Philip Withnall authored
Signed-off-by:
Philip Withnall <withnall@endlessm.com> GNOME/glib#734
-
- 07 Oct, 2018 1 commit
-
-
Kjartan Maraas authored
-
- 06 Oct, 2018 1 commit
-
-
Philip Withnall authored
Ignore g_return_*if_fail() branches in lcov coverage report See merge request GNOME/glib!379
-
- 05 Oct, 2018 1 commit
-
-
Philip Withnall authored
While we can’t add markers to the macro implementations to cause lcov to ignore them automatically, we can change our lcov configuration to ignore all calls to them. See https://github.com/linux-test-project/lcov/issues/44. This causes all the un-takeable branches and un-reachable assertions to be ignored by our code coverage, which bumps our statistics: • Lines: 74.9% → 74.8% • Functions: 82.3% → 82.3% • Branches: 53.3% → 64.2% The rationale is that nobody should be testing programmer error handling, as g_return_*if_fail() are used to guard against — so it’s not reasonable to count missed branches like that in code coverage statistics. Signed-off-by:
Philip Withnall <withnall@endlessm.com>
-
- 04 Oct, 2018 1 commit
-
-
Simon McVittie authored
By using PKG_CHECK_VAR, we declare $GLIB_COMPILE_SCHEMAS, $GLIB_GENMARSHAL, $GOBJECT_QUERY, $GLIB_MKENUMS and $GLIB_COMPILE_RESOURCES as Autoconf "precious variables" with AC_ARG_VAR, similar to $PKG_CONFIG and $CC, so that they can be put on a configure command line: ./configure GLIB_COMPILE_RESOURCES=my-glib-compile-resources If they are set to a non-empty value, PKG_CHECK_VAR will use that instead of auto-detecting from pkg-config, so that builders can override them, for example when cross-compiling. Similarly, use the standard PKG_CHECK_MODULES macro to get GLib's CFLAGS and LIBS. It's possible that most of the rest of each macro can also disappear, but for the moment I've given them the benefit of the doubt. This does result in printing "checking for GLIB" twice (once for PKG_CHECK_MODULES and once for GLib's custom checks), but if you're using Autotools, you probably don't have a strong objection to overly verbose output. Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
- 03 Oct, 2018 2 commits
-
-
Philip Withnall authored
I’m fed up of trying to read these and having my head done in by mixed tabs and spaces. This introduces no functional changes. Signed-off-by:
Philip Withnall <withnall@endlessm.com>
-
Philip Withnall authored
This partially reverts commit bfc362cb. The FreeBSD CI runner still seems to be a bit flakey, and appears to be offline entirely at the moment. Signed-off-by:
Philip Withnall <withnall@endlessm.com> Reviewed-by: nobody
-
- 02 Oct, 2018 5 commits
-
-
Philip Withnall authored
gcharset: fix leaking g_get_language_names_with_category See merge request GNOME/glib!338
-
Philip Withnall authored
gtask: Check an error hasn’t been returned when calling g_task_return*() Closes #1525 See merge request GNOME/glib!368
-
Philip Withnall authored
There are a lot of gbooleans in the private GTask struct, which seems a bit wasteful. Use a bitfield to compress the struct a bit. This reduces the size of the struct from 216 bytes to 168 bytes on my 64-bit machine. One of the fields needs to remain separate, since it’s used from a TRACE() macro which calls typeof() on it. Signed-off-by:
Philip Withnall <withnall@endlessm.com>
-
Philip Withnall authored
These are based on an example test program provided by Will Thompson in issue #1525. Signed-off-by:
Philip Withnall <withnall@endlessm.com> GNOME/glib#1525
-
Philip Withnall authored
W32: gstat fixes for ucrt Closes #1452 See merge request GNOME/glib!257
-
- 01 Oct, 2018 4 commits
-
-
Philip Withnall authored
These functions already check to see if a successful result has already been returned; expand them to also check to see if an error has been returned. We can’t just check GTask.result_set, as that’s actually an indicator for whether the GTask.result member is filled — when g_task_propagate_*() is called, it’s cleared again. We need a new state bit. Signed-off-by:
Philip Withnall <withnall@endlessm.com> GNOME/glib#1525
-
Philip Withnall authored
This method drops the last reference *it* owns to the GTask, but then continues to call methods on the GTask. This wasn’t resulting in failures because a ref in another thread kept the GTask alive, but that’s quite dodgy. Signed-off-by:
Philip Withnall <withnall@endlessm.com>
-
Philip Withnall authored
Add g_desktop_app_info_get_string_list(); fix g_key_file_free() See merge request GNOME/glib!339
-
Will Thompson authored
The X-Flatpak-RenamedFrom key is used in .desktop files to identify past names for the desktop file. It is defined to be a list of strings. However, there was previously no correct way to retrieve a list of strings from the GKeyFile wrapped by GDesktopAppInfo, short of re-parsing the file with GKeyFile. Note that doing something like: g_strsplit (g_desktop_app_info_get_string (...), ";", -1) is not correct: the raw value "a\;b;" represents the one-element list ["a;b"], but g_key_file_get_string() rejects the sequence "\;", and so g_desktop_app_info_get_string() returns NULL in this case. (Of course, a .desktop file with a semicolon in its name is a pathological case.) Add g_desktop_app_info_get_string_list(), a trivial wrapper around g_key_file_get_string_list(), similar to g_desktop_app_info_get_string() and co. The change from g_key_file_free() to g_key_file_unref() in the test is needed because g_key_file_free() clears the contents of the keyfile. This is fine for all the fields which are eagerly loaded and copied into GDesktopAppInfo, but not when we want to access arbitrary stuff from the keyfile.
-
- 29 Sep, 2018 3 commits
-
-
Philip Withnall authored
Fix build failure on systems without POSIX spawn See merge request GNOME/glib!345
-
Philip Withnall authored
ci: Enable FreeBSD CI See merge request GNOME/glib!364
-
Ryan Schmidt authored
-
- 28 Sep, 2018 5 commits
-
-
Ting-Wei Lan authored
-
Xavier Claessens authored
Meson: Fix static linking of convenience libraries Closes #1536 See merge request GNOME/glib!357
-
Simon McVittie authored
This avoids the convenience library being treated as though it was an installed static library (objects not included in the dependent static library, and convenience library being listed in the pkg-config metadata), both of which would make static linking impossible. This is a workaround for meson not having https://github.com/mesonbuild/meson/pull/3939 merged yet. Fixes: GNOME/glib#1536Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Philip Withnall authored
Ci meson 0 48 See merge request GNOME/glib!347
-
Philip Withnall authored
Documentation tweaks for g_array_free See merge request GNOME/glib!348
-
- 27 Sep, 2018 4 commits
-
-
Xavier Claessens authored
-
Xavier Claessens authored
-
Xavier Claessens authored
Tests: Mark printf wrappers with G_GNUC_PRINTF See merge request GNOME/glib!363
-
Simon McVittie authored
If we tell clang that we're passing the arguments on to a compatible printf call, it can see that we're doing it right, and won't warn us about -Wformat-nonliteral. This follows up from commit abac67c0. Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
- 26 Sep, 2018 5 commits
-
-
Emmanuele Bassi authored
Autotools: Always run glib-genmarshal, even if cross-compiling Closes #1546 See merge request GNOME/glib!362
-
Simon McVittie authored
Autotools: Move libmount from Libs.private to Requires.private See merge request GNOME/glib!358
-
Xavier Claessens authored
Meson: appinfo tests are racy if run in parallel Closes #1514 See merge request GNOME/glib!356
-
Simon McVittie authored
glib-genmarshal is now written in Python rather than C, so we can always run it directly, even if we're cross-compiling for an architecture whose binaries we can't run. This matches the behaviour of the Meson build system. Fixes: GNOME/glib#1546 Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=908334Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
libmount depends on libblkid, so if we statically link a trivial executable to GIO, we need to pull in both libmount and libblkid. Linking with -lmount is not enough to achieve that, but recursing into mount.pc is. This makes the Autotools build a bit more like the Meson build, which already puts mount in Requires.private. Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
- 25 Sep, 2018 4 commits
-
-
Xavier Claessens authored
-
Xavier Claessens authored
Fix spelling mistakes detected by Debian's Lintian tool See merge request GNOME/glib!354
-
Xavier Claessens authored
Generate gtester-report from .in file Closes #1544 See merge request GNOME/glib!352
-
Simon McVittie authored
Meson: Do not run tests/refcount with --tap See merge request GNOME/glib!353
-