1. 18 Mar, 2015 1 commit
  2. 06 Feb, 2015 1 commit
  3. 05 Feb, 2015 1 commit
    • Benjamin Otte's avatar
      css: Add -gtk-dpi CSS property hack · 89f635fe
      Benjamin Otte authored
      This property is necessary to ensure widgets automatically update after
      the text scale factor is changed desktop-wide.
      And if I'm already doing a property like this, I can make it
      overridable. So now you can override the dpi per-widget with CSS like
      GtkSwitch {
        -gtk-dpi: 48;
      if you want to debug things.
      Long-term, we want to get rid of this property and insist on dpi being
      96 everywhere and people can change the font size to get larger fonts.
  4. 07 Jan, 2015 1 commit
  5. 03 Jul, 2013 1 commit
    • Alexander Larsson's avatar
      css: Add a scale argument to css-value compute vfunc · af2c40bd
      Alexander Larsson authored
      We need to be able to compute different GtkCssImage values
      depending on the scale, and we need this at compute time so that
      we don't need to read any images other than the scale in used (to
      e.g. calculate the image size). GtkStyleProviderPrivate is shared
      for all style contexts, so its not right.
  6. 01 Dec, 2012 2 commits
    • Benjamin Otte's avatar
      css: Add more features to font-size code · 0d9d5761
      Benjamin Otte authored
      We now support the keywords (like xx-small, medium, larger, smaller...)
      and I've changed the default value to be "medium".
      This required some shuffling of the "get default font size" code. But
      all is well now.
    • Benjamin Otte's avatar
      css: Move default font handling · 1dd3ee6b
      Benjamin Otte authored
      The default font is no longer handled like a custom style sheet that
      overrides everything, but as the initial value. This is the same
      behavior as in web browsers.
      And it allows the theme to actually use the 'font-family' and
      'font-size' properties. Of course, a well behaved theme will respect the
      setting as much as possible and for example use relative font sizes
      (which aren't yet supported, but will be soon).
  7. 25 Nov, 2012 1 commit
    • Benjamin Otte's avatar
      cssvalue: Add _gtk_css_initial_value_get() · f204473e
      Benjamin Otte authored
      ... so we don't bump a refcount whenever we get the initial singleton.
      We want to use this function instead of
      _gtk_css_style_property_get_initial_value() everywhere where we compute
      values, because some initial values may depend on settings soon.
  8. 28 Sep, 2012 1 commit
    • Benjamin Otte's avatar
      css: Huge refactoring to avoid computing wrong values · 1454ba15
      Benjamin Otte authored
      Here's the shortest description of the bug I can come up with:
      When computing values, we have 3 kinds of dependencies:
      (1) other properties ("currentColor" or em values)
      (2) inherited properties ("inherit")
      (3) generic things from the theme (@keyframes or @define-color)
      Previously, we passed the GtkStyleContext as an argument, because it
      provided these 3 things using:
      (1) _gtk_style_context_peek_property()
      (2) _gtk_style_context_peek_property(gtk_style_context_get_parent())
      (3) context->priv->cascade
      However, this makes it impossible to lookup values other than the ones
      accessible via _gtk_style_context_peek_property(). And this is exactly
      what we are doing in gtk_style_context_update_cache(). So when the cache
      updates encountered case (1), they were looking up the values from the
      wrong style data.
      So this large patch essentially does nothing but replace the
      context argument in all compute functions with new arguments for the 3
      cases above:
      (1) values
      (2) parent_values
      (3) provider
      We apparently have a lot of computing code.
  9. 03 Sep, 2012 1 commit
    • Benjamin Otte's avatar
      cssvalue: Pass property ID to transition function · e3fc081c
      Benjamin Otte authored
      This is to allow animating arrays properly. I'm not really thrilled
      about this solution (we leak propertys into the values again...), but
      it's the best I can come up with - I prefer it to having N different
      array types...
  10. 28 Aug, 2012 4 commits
    • Benjamin Otte's avatar
      css: Introduce dependencies for value computations · 0e2f35ed
      Benjamin Otte authored
      When values are computed, they might depend on various other values and
      we need to track this so we can update the values when those other
      values change. This is the first step in making that happen.
      This patch does not do any dependency tracking at all, instead it uses
    • Benjamin Otte's avatar
      css: Move computing of initial and inherit values · 9e7e65ca
      Benjamin Otte authored
      ... to the compute vfunc. Simplifies code quite a bit. But makes the
      code no longer a simple step-by-step implementation of the spec.
    • Benjamin Otte's avatar
      css: Pass property_id to compute function · 9b4ed662
      Benjamin Otte authored
      This is a reorganization of how value computing should be done.
      Previously the GtkCssStyleProperty.compute vfunc was supposed to take
      care of special cases when it needed those for computation. However,
      this proved to be very complicated in cases where values were nested and
      only the last value (of a common type) needed to be special cased.
      A common example for this was the fallback handling for unresolvable
      Now, we pass the property's ID along with all compute functions so we
      can do the special casing where it's necessary.
      Note that no actual changes happen in this commit. This will happen in
    • Benjamin Otte's avatar
      css: Introduce _gtk_css_value_compute() · 9b953829
      Benjamin Otte authored
      This commit is essentially a large reorganization. Instead of all value
      subtypes having their own compute function, there is the general
      _gtk_css_value_compute() function that then calls a vfunc on the
  11. 17 Apr, 2012 3 commits
    • Benjamin Otte's avatar
      cssvalue: Add _gtk_css_value_transition() · 1a9dfab8
      Benjamin Otte authored
      Returns a value that transitions between start and end or %NULL if the
      values cannot be transitioned.
      So far, all implementations but numbers and rgba return NULL.
    • Benjamin Otte's avatar
      cssvalue: Add _gtk_css_value_equal() · ffe50c3b
      Benjamin Otte authored
      For now, we return FALSE for all default css values, so this is not very
      I also think of this as an optimization equal, not a guaranteed equal,
      because we don't even have a notion of what "equal" means.
      For example, for background-repeat, "repeat, repeat" and "repeat"
      are functionally equivalent. But the cssvalue has no idea that it's used
      for background-repeat.
      As a more complicated example, "repeat, no-repeat" and "repeat" are
      equal to what one sees as long as there's only one image listed
      background-image-source. But once you start transition'ing to an image
      with 2 sources, it's different...
    • Benjamin Otte's avatar
      styleproperty: Make _gtk_style_property_parse_value() return a CssValue · 9b7640b8
      Benjamin Otte authored
      Also split out initial/inherit handling into a custom GtkCssValue class.