1. 07 Mar, 2004 8 commits
    • Jonathan Blandford's avatar
      actually use gtk_button_add. · afec1da0
      Jonathan Blandford authored
      Sun Mar  7 17:38:03 2004  Jonathan Blandford  <jrb@gnome.org>
      
              * gtk/gtkbutton.c (gtk_button_class_init): actually use
              gtk_button_add.
      
              * gtk/gtkfilechooserdefault.c (error_building_filename_dialog):
              use the uri, not the path, #136317
              (renderer_edited_cb): ditto
              (shortcuts_add_bookmark_from_path): ditto
              (remove_bookmark_button_clicked_cb): ditto
              (gtk_file_chooser_default_remove_shortcut): ditto
              (update_from_entry): ditto
              (up_folder_handler): ditto
      afec1da0
    • Jonathan Blandford's avatar
      set redraw_on_allocate, #135902. · 9e379cfd
      Jonathan Blandford authored
      Sun Mar  7 16:07:08 2004  Jonathan Blandford  <jrb@gnome.org>
      
              * gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_init): set
              redraw_on_allocate, #135902.
      
              * gtk/gtkfilesystemmodel.c (model_refilter_recurse): Patch from
              Damon Chaplin to set a node to be visible before emitting the
              inserted signal, #135555.
      9e379cfd
    • Matthias Clasen's avatar
      Don't use xthickness in the height calculation. · e2f66ec7
      Matthias Clasen authored
      Sun Mar  7 22:24:28 2004  Matthias Clasen  <maclas@gmx.de>
      
      	* gtk/gtkbutton.c (_gtk_button_paint): Don't use xthickness in the
      	height calculation.
      e2f66ec7
    • Jonathan Blandford's avatar
      stop activate from unselecting rows when pressed in multiple-selection · 58db7b1f
      Jonathan Blandford authored
      Sun Mar  7 14:34:04 2004  Jonathan Blandford  <jrb@gnome.org>
      
              * gtk/gtkfilechooserdefault.c (trap_activate_cb): stop activate
              from unselecting rows when pressed in multiple-selection mode.
      58db7b1f
    • Hans Breuer's avatar
      some more settings from system, also reflect some name changes done a · 985e3a24
      Hans Breuer authored
      2004-03-07  Hans Breuer  <hans@breuer.org>
      
      	* gdk/win32/gdkproperty-win32.c (gdk_screen_get_setting) :
      	some more settings from system, also reflect some name changes
      	done a while ago in the x11 backend
      
      	* gdk/win32/makefile.msc : build gdkspawn-win32.c
      
      	* gtk/gtkdnd.c : gtk_drag_source_[gs]et_target_list, added "Since: 2.4"
      
      	* gtk/makefile.msc.in : build gtkpathbar, link shell32.lib
      
      	* tests/makefile.msc : some more tests get build
      985e3a24
    • Jonathan Blandford's avatar
      if action is SELECT_FOLDER, then return the currentd folder if none is · eb258fe2
      Jonathan Blandford authored
      Sun Mar  7 03:03:57 2004  Jonathan Blandford  <jrb@gnome.org>
      
              * gtk/gtkfilechooserdefault.c
              (gtk_file_chooser_default_get_paths): if action is
              SELECT_FOLDER, then return the currentd folder if none is
              selected.
              (gtk_file_chooser_default_should_respond): Allow 'Ok' to be hit if
              no directory is selected in SELECT_FOLDER mode.
      eb258fe2
    • Jonathan Blandford's avatar
      remove unneeded elements. (tree_selection_changed): removed · 0b231feb
      Jonathan Blandford authored
      Sat Mar  6 23:31:18 2004  Jonathan Blandford  <jrb@gnome.org>
      
              * gtk/gtkfilechooserdefault.c (struct _GtkFileChooserDefault):
              remove unneeded elements.
              (tree_selection_changed): removed
              (tree_name_data_func): removed
              (gtk_file_chooser_default_finalize): don't unref dir model
              (create_folder_tree): removed
              (get_selection): no longer need to abstract away the selection
              function.
              (create_file_list): We now create a tree for all actions.
              (file_pane_create): Make one tree.
              (update_appearance) We really change the mode only, now.
      0b231feb
    • Matthias Clasen's avatar
      Do a size_request on the button and cell_view_frame, otherwise their style · 6d34fb26
      Matthias Clasen authored
      Sun Mar  7 02:38:00 2004  Matthias Clasen  <maclas@gmx.de>
      
      	* gtk/gtkcombobox.c (gtk_combo_box_size_request): Do a
      	size_request on the button and cell_view_frame, otherwise
      	their style will still be the default here in the initial
      	size_request. (#136301, Mark McLoughlin)
      6d34fb26
  2. 06 Mar, 2004 3 commits
  3. 05 Mar, 2004 14 commits
    • Tor Lillqvist's avatar
      Move check for native Win32 (mingw) a bit earlier. If Win32, disable · 11c87b6a
      Tor Lillqvist authored
      2004-03-05  Tor Lillqvist  <tml@iki.fi>
      
      	* configure.in: Move check for native Win32 (mingw) a bit
      	earlier. If Win32, disable static builds (as in GLib). Remove
      	unnecessary AC_LIBTOOL_WIN32_DLL.
      11c87b6a
    • Tor Lillqvist's avatar
      Add missing entries, thanks to J. Ali Harlow. · 72d622fc
      Tor Lillqvist authored
      2004-03-05  Tor Lillqvist  <tml@iki.fi>
      
      	* gdk/gdk.def: Add missing entries, thanks to J. Ali Harlow.
      
      	* gdk/win32/gdkcursor-win32.c (color_is_white): const-correctness.
      
      	(gdk_cursor_new_from_pixbuf): Copy of the non-Xcursor X11
      	implementation.
      
      	(gdk_display_supports_cursor_alpha,
      	gdk_display_supports_cursor_color): Dummy implementations.
      
      	(gdk_display_get_default_cursor_size,
      	gdk_display_get_maximal_cursor_size): Implement.
      
      	* gdk/win32/gdkdisplay-win32.c (gdk_display_get_default_group):
      	Dummy implementation.
      
      	* gdk/win32/gdkevents-win32.c (gdk_net_wm_supports): Dummy
      	implementation.
      
      	* gdk/win32/gdkfont-win32.c (gdk_font_get_display): Implement.
      
      	* gdk/win32/gdkinput-win32.c (gdk_input_motion_events): Remove,
      	not in API.
      
      	* gdk/win32/gdkwindow-win32.c (gdk_window_get_group): Dummy
      	implementation.
      72d622fc
    • Jonathan Blandford's avatar
      scroll to the new path. · 48bfdd51
      Jonathan Blandford authored
      Fri Mar  5 18:00:36 2004  Jonathan Blandford  <jrb@redhat.com>
      
              * gtk/gtkfilechooserdefault.c (new_folder_button_clicked): scroll
              to the new path.
      
              * gtk/gtktreeview.c (gtk_tree_view_adjustment_changed): Update the
              allocation when scrolling instead of cancelling editing.
      48bfdd51
    • Matthias Clasen's avatar
      doc updates. · 312f668e
      Matthias Clasen authored
      312f668e
    • Matthias Clasen's avatar
      Clarify the doc comment. (#118602) · 61fd5219
      Matthias Clasen authored
      Fri Mar  5 23:37:16 2004  Matthias Clasen  <maclas@gmx.de>
      
      	* gtk/gtktreeview.c (gtk_tree_view_set_reorderable): Clarify the
      	doc comment.  (#118602)
      61fd5219
    • Matthias Clasen's avatar
      Don't let the priv->image pointer dangle. (#136259, Padraig O'Briain) · 20cafaee
      Matthias Clasen authored
      Fri Mar  5 22:37:15 2004  Matthias Clasen  <maclas@gmx.de>
      
      	* gtk/gtkbutton.c (gtk_button_construct_child): Don't let
      	the priv->image pointer dangle.  (#136259, Padraig O'Briain)
      20cafaee
    • Federico Mena Quintero's avatar
      Add gboolean return values and GError arguments to ::set_current_folder() · 385bd6a5
      Federico Mena Quintero authored
      2004-03-05  Federico Mena Quintero  <federico@ximian.com>
      
      	* gtk/gtkfilechooserprivate.h (struct _GtkFileChooserIface): Add
      	gboolean return values and GError arguments to
      	::set_current_folder() and ::select_path().
      
      	* gtk/gtkfilechooser.c (gtk_file_chooser_set_current_folder):
      	Return a boolean value for success/failure.
      	(gtk_file_chooser_set_current_folder_uri): Likewise.
      	(gtk_file_chooser_select_filename): Likewise.
      	(gtk_file_chooser_select_uri): Likewise.
      	(gtk_file_chooser_set_filename): Likewise.
      	(gtk_file_chooser_set_uri): Likewise.
      	(_gtk_file_chooser_set_current_folder_path): Likewise, plus take
      	in a GError.
      	(_gtk_file_chooser_select_path): Likewise.
      
      	* gtk/gtkfilechooserutils.c (delegate_set_current_folder):
      	Likewise.
      	(delegate_select_path): Likewise.
      
      	* gtk/gtkfilechooserdefault.c
      	(gtk_file_chooser_default_select_path): Likewise.
      	(gtk_file_chooser_default_set_current_folder): Likewise.
      	(error_changing_folder_dialog): New helper function.
      	(change_folder_and_display_error): New helper function.
      	(switch_to_selected_folder): Use change_folder_and_display_error().
      	(tree_selection_changed): Likewise.
      	(shortcuts_activate_volume): Likewise.
      	(shortcuts_activate_item): Likewise.
      	(list_row_activated): Likewise.
      	(path_bar_clicked): Likewise.
      	(update_from_entry): Likewise.
      	(up_folder_handler): Likewise.
      	(home_folder_handler): Get the home path from the shortcuts model,
      	and use change_folder_and_display_error().
      
      	* tests/testfilechooser.c (set_current_folder): New helper
      	function; pops up a simple error dialog if necessary.
      	(set_filename): Likewise.
      	(set_folder_nonexistent_cb): Use set_current_folder().
      	(set_folder_existing_nonexistent_cb): Likewise.
      	(set_filename_nonexistent_cb): Use set_filename().
      	(set_filename_existing_nonexistent_cb): Likewise.
      385bd6a5
    • Owen Taylor's avatar
      Improve the docs (reported by Vitaly Tishkov, #74362) Add some comments to · c43e4377
      Owen Taylor authored
      Fri Mar  5 11:17:35 2004  Owen Taylor  <otaylor@redhat.com>
      
              * gtk/gtktreemodel.c (gtk_tree_row_reference_new_proxy):
              Improve the docs (reported by Vitaly Tishkov,
              #74362) Add some comments to the code about the
              row reference handling that are hopefully not entirely
              wrong.
      c43e4377
    • Michael Natterer's avatar
      s/object/widget/. Makes it compile again. · 800f0e61
      Michael Natterer authored
      2004-03-05  Michael Natterer  <mitch@gimp.org>
      
      	* gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_show_all):
      	s/object/widget/. Makes it compile again.
      800f0e61
    • Jonathan Blandford's avatar
      chain to the extra_widget. · 5d50d3d1
      Jonathan Blandford authored
      Fri Mar  5 03:37:14 2004  Jonathan Blandford  <jrb@gnome.org>
      
              * gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_show_all):
              chain to the extra_widget.
      5d50d3d1
    • Jonathan Blandford's avatar
      Patch from Damon Chaplin to free models when we're finalized, #134053 · 233b7b8b
      Jonathan Blandford authored
      Fri Mar  5 02:53:41 2004  Jonathan Blandford  <jrb@gnome.org>
      
              * gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_finalize):
              Patch from Damon Chaplin to free models when we're finalized,
              #134053
      233b7b8b
    • Alexander Larsson's avatar
      Document the fact that there might not be a volume for all paths. · 8a8798bd
      Alexander Larsson authored
      2004-03-05  Alexander Larsson  <alexl@redhat.com>
      
      	* gtk/gtkfilesystem.c (gtk_file_system_get_volume_for_path):
      	Document the fact that there might not be a volume for all
      	paths.
      
      	* gtk/gtkfilechooserdefault.c (shortcuts_add_current_folder):
      	Don't assume there is a volume for all paths.
      8a8798bd
    • Jonathan Blandford's avatar
      insert in the correct place instead of naïvely appending. · 8bb74888
      Jonathan Blandford authored
      Fri Mar  5 01:45:04 2004  Jonathan Blandford  <jrb@gnome.org>
      
              * gtk/gtkfilechooserdefault.c (shortcuts_append_paths): insert in
              the correct place instead of naïvely appending.
              (shortcuts_add_volumes): refilter the model
              (shortcuts_add_bookmarks): refilter the model
              (gtk_file_chooser_default_add_shortcut_folder): refilter the model
      8bb74888
    • Federico Mena Quintero's avatar
      New handler. Ask the GtkFileChooser widget if it wants to do something · d64c7c08
      Federico Mena Quintero authored
      2004-03-04  Federico Mena Quintero  <federico@ximian.com>
      
      	* gtk/gtkfilechooserdialog.c (response_cb):  New handler.  Ask the
      	GtkFileChooser widget if it wants to do something special rather
      	than letting us terminate the dialog.
      	(gtk_file_chooser_dialog_init): Connect to "response"; see the
      	comment in the sources to see why we don't override the method in
      	class_init.
      
      	* gtk/gtkfilechooserembed.h (struct _GtkFileChooserEmbedIface):
      	Added a ::should_respond() method.
      
      	* gtk/gtkfilechooserembed.c
      	(_gtk_file_chooser_embed_delegate_iface_init): Add a delegate for ::should_respond().
      	(delegate_should_respond): New delegate.
      	(_gtk_file_chooser_embed_should_respond): New function.
      
      	* gtk/gtkfilechooserdefault.c (set_list_model, create_file_list):
      	Use dashes in signal names rather than underscores.
      	(gtk_file_chooser_default_init): Hook up our ::should_respond() implementation.
      	(gtk_file_chooser_default_should_respond): Implement.  go into a
      	folder rather than responding if we are in File mode and the
      	selected file is a folder.
      	(get_selection): New helper function.
      	(add_bookmark_button_clicked_cb): Use get_selection().
      	(bookmarks_check_add_sensitivity): Likewise.
      	(gtk_file_chooser_default_get_paths): Likewise.
      	(check_save_entry): New helper function.
      	(gtk_file_chooser_default_get_paths): Use check_save_entry().
      	(selection_check): Renamed from selection_is_folders().  Now
      	checks whether the selection is empty, all files, all folders.
      	(bookmarks_check_add_sensitivity): Use selection_check().
      d64c7c08
  4. 04 Mar, 2004 6 commits
    • Matthias Clasen's avatar
      Connect to key_press_event and handle Alt-Down/Alt-Up to show or hide the · 1810dba3
      Matthias Clasen authored
      Fri Mar  5 00:05:59 2004  Matthias Clasen  <maclas@gmx.de>
      
      	* gtk/gtkcombobox.c (gtk_combo_box_list_setup):
      	* gtk/gtkcombobox.c (gtk_combo_box_menu_setup): Connect to
      	key_press_event and handle Alt-Down/Alt-Up to show or hide the
      	list popup. Also handle Down/Up/PageDown/PageUp/Home/End and
      	make them change the active item without popping up the list.
      	These keybindings are inherited from GtkCombo.
      
      Thu Mar  4 23:15:58 2004  Matthias Clasen  <maclas@gmx.de>
      
      	* gtk/gtkcombobox.c (gtk_combo_box_menu_position): Initially
      	select the active item when using optionmenu-like positioning.
      1810dba3
    • Owen Taylor's avatar
      Don't open/close the file, just check for existence with g_file_test(). · 1af39383
      Owen Taylor authored
      Thu Mar  4 16:54:30 2004  Owen Taylor  <otaylor@redhat.com>
      
              * gtk/gtkrc.c (gtk_rc_check_pixmap_dir): Don't
              open/close the file, just check for existence
              with g_file_test(). This is considerably cheaper,
              and lack-of-permissions for pixmap dirs is
              pathological.
      
      Wed Mar  3 17:53:21 2004  Owen Taylor  <otaylor@redhat.com>
      
              * gtk/gtksocket.c (gtk_socket_class_init): Overide
              show_all/hide_all to be gtk_widget_show/gtk_widget_hide,
              since we don't want to propagate to the in-process
              plug, if any. (#122949, Michael Meeks)
      1af39383
    • Jonathan Blandford's avatar
      show the 'New Folder' button in SAVE mode again. · b1ac4367
      Jonathan Blandford authored
      Thu Mar  4 15:20:55 2004  Jonathan Blandford  <jrb@gnome.org>
      
              * gtk/gtkfilechooserdefault.c (update_appearance): show the 'New
              Folder' button in SAVE mode again.
      b1ac4367
    • Matthias Clasen's avatar
      Increment the reference count of the style when copying the cached icon. · 897f3aac
      Matthias Clasen authored
      Thu Mar  4 21:53:46 2004  Matthias Clasen  <maclas@gmx.de>
      
      	* gtk/gtkiconfactory.c (copy_cache): Increment the reference
      	count of the style when copying the cached icon.  (#135890, Crispin
      	Flowerday)
      897f3aac
    • Matthias Clasen's avatar
      In list mode, set the background color of the cell view to the base color · f855ea2d
      Matthias Clasen authored
      Thu Mar  4 21:45:43 2004  Matthias Clasen  <maclas@gmx.de>
      
      	* gtk/gtkcombobox.c: In list mode, set the background color
      	of the cell view to the base color of the style, instead of
      	hardwiring white. (#136158)
      f855ea2d
    • Jonathan Blandford's avatar
      Modified patch from muppet <scott@asofyet.org> to keep child directories · 778d6904
      Jonathan Blandford authored
      Thu Mar  4 01:32:19 2004  Jonathan Blandford  <jrb@gnome.org>
      
              * gtk/gtkpathbar.c (gtk_path_bar_set_path): Modified patch from
              muppet <scott@asofyet.org> to keep child directories around if we
              change to a child.
      
              * gtk/gtkpathbar.c (_gtk_path_bar_set_home_icon): Start of
              icon-setting functions.  Not used yet.
              (_gtk_path_bar_set_root_icon): Ditto.
      778d6904
  5. 03 Mar, 2004 9 commits
    • Matthias Clasen's avatar
      Allow to select the last word in the buffer. (#135487, Paolo Borelli) · befe86f1
      Matthias Clasen authored
      Thu Mar  4 00:31:54 2004  Matthias Clasen  <maclas@gmx.de>
      
      	* gtk/gtktextview.c (extend_selection):
      	* gtk/gtktextview.c (gtk_text_view_move_cursor_internal): Allow
      	to select the last word in the buffer.  (#135487, Paolo Borelli)
      befe86f1
    • Matthias Clasen's avatar
      Doc update. · 576ce814
      Matthias Clasen authored
      576ce814
    • Owen Taylor's avatar
      Check whether widgets are viewable, not just if they are mapped. (#122912, · 2ddeb7cd
      Owen Taylor authored
      Wed Mar  3 17:30:18 2004  Owen Taylor  <otaylor@redhat.com>
      
              * gtk/gtkwindow.c (gtk_window_mnemonic_activate): Check
              whether widgets are viewable, not just if they are
              mapped. (#122912, reported by Tim Evans)
      2ddeb7cd
    • Matthias Clasen's avatar
      Move the actual implementation into a new · 19369fea
      Matthias Clasen authored
      Wed Mar  3 23:28:48 2004  Matthias Clasen  <maclas@gmx.de>
      
      	* gtk/gtkcombobox.c (gtk_combo_box_set_active): Move the actual
      	implementation into a new gtk_combo_box_set_active_internal()
      	function, which doesn't do the short-circuiting.
      	* gtk/gtkcombobox.c (gtk_combo_box_model_row_deleted): Use
      	set_active_internal() here, since the active item may change here,
      	although the index is unchanged.
      
      Wed Mar  3 23:26:49 2004  Matthias Clasen  <maclas@gmx.de>
      
      	* gtk/gtkcombobox.c (gtk_combo_box_menu_position): Reintroduce the
      	traditional option menu placement of the popup for regular combo
      	boxes. Grids and editable combo boxes use the combo-like placement
      	below the entry.  (#136021)
      	* gtk/gtkcombobox.c (gtk_combo_box_menu_button_press):
      	* gtk/gtkcombobox.c (gtk_combo_box_popup): Call gtk_menu_set_active()
      	before popping up the menu, to make the placement work.
      19369fea
    • Owen Taylor's avatar
      Special case scroll events so that they propagate up the widget heirarchy · 7a9bec28
      Owen Taylor authored
      Wed Mar  3 17:20:15 2004  Owen Taylor  <otaylor@redhat.com>
      
              * gtk/gtkmain.c (gtk_propagate_event): Special case
              scroll events so that they propagate up the widget
              heirarchy when received on insensitive widgets.
              (#101102, reported by Geoff Reedy)
      7a9bec28
    • Owen Taylor's avatar
      #109594, reported by Olivier Ripoll · 0d898ffc
      Owen Taylor authored
      Wed Mar  3 16:47:10 2004  Owen Taylor  <otaylor@redhat.com>
      
               #109594, reported by Olivier Ripoll
      
              * gtk/gtkentry.c (gtk_entry_size_request): Use max of
              width and digit width for gtk_entry_set_width_chars,
              and round up.
      
              * gtk/gtkcolorsel.c (gtk_color_selection_init): Set the
              width of the entry to 7 chars.
      0d898ffc
    • Owen Taylor's avatar
      Strip out the "export-dynamic" libtool option from library link lines. · d7681e7c
      Owen Taylor authored
      Wed Mar  3 16:00:10 2004  Owen Taylor  <otaylor@redhat.com>
      
              * configure.in: Strip out the "export-dynamic" libtool
              option from library link lines. (#124687, James Henstridge)
      d7681e7c
    • Jonathan Blandford's avatar
      Don't activate the combo if we're in the midst of changing folders. · e47f7d58
      Jonathan Blandford authored
      Wed Mar  3 16:06:03 2004  Jonathan Blandford  <jrb@gnome.org>
      
              * gtk/gtkfilechooserdefault.c (save_folder_combo_changed_cb):
              Don't activate the combo if we're in the midst of changing
              folders.
      e47f7d58
    • Mark McLoughlin's avatar
      don't try and store pointers in ints. Fixes 64-bit build. · 81ea4248
      Mark McLoughlin authored
      2004-03-03  Mark McLoughlin  <mark@skynet.ie>
      
              * tests/testsocket_common.c: (print_hello): don't try and store
              pointers in ints. Fixes 64-bit build.
      81ea4248