1. 18 Oct, 2000 4 commits
    • Havoc Pennington's avatar
      Some updates · 7a4c6893
      Havoc Pennington authored
      2000-10-18  Havoc Pennington  <hp@redhat.com>
      
      	* gtk/gtk-sections.txt: Some updates
      
      	* gdk/gdk-sections.txt: remove GdkPixbufAlphaMode
      
      	* gdk-pixbuf/gdk-pixbuf-sections.txt: Add new API, remove
      	GdkPixbufClass/GdkAnimationClass since those are private
      
      	* gdk-pixbuf/Makefile.am (IGNORE_HFILES): ignore more headers
      
      2000-10-18  Havoc Pennington  <hp@redhat.com>
      
      	* gtk/gtktextiter.c (gtk_text_iter_forward_to_newline): Fix a bug
      	where any number of empty lines would get skipped
      
      	* gtk/gtktextiter.h: Remove padding from GtkTextIter; live on the
      	edge.
      
      	* gtk/gtktextiter.c (gtk_text_iter_make_surreal): enhance the
      	warning about invalid iterators (explain more thoroughly)
      	(gtk_text_iter_in_region): rename gtk_text_iter_in_range
      
      	* gtk/gtktextview.c (FOCUS_EDGE_WIDTH): Make focus rectangle less
      	big
      
      	* demos/*.c: Add error handling
      
      	* gtk/gtktextbuffer.c: don't modify const iterators
      
      	* gtk/gdk-pixbuf-loader.c: Add full error handling here
      
      	* gtk/gtkimage.c (gtk_image_set_from_file): ignore errors
      	on file load
      
      	* gtk/gtkiconfactory.c: Update to reflect addition of error
      	handling to gdk-pixbuf loaders
      
      2000-10-16  Havoc Pennington  <hp@redhat.com>
      
      	* gdk-pixbuf-io.c (gdk_pixbuf_get_module)
      	(gdk_pixbuf_get_named_module) (gdk_pixbuf_load_module):
      	add error reporting here also
      
      	* make-inline-pixbuf.c (main): use GError
      
      	* io-xpm.c: include unistd.h
      
      	* gdk-pixbuf-util.c: include string.h
      
      	* io-*.c: add error reporting
      
      	* gdk-pixbuf-animation.c (gdk_pixbuf_animation_new_from_file): add
      	error reporting
      
      	* gdk-pixbuf-io.c (gdk_pixbuf_new_from_file): Add error reporting
      
      	* gdk-pixbuf-io.h: Add GError** to load_increment and load
      	methods
      
      	* gdk-pixbuf-io.c (gdk_pixbuf_save) (gdk_pixbuf_savev): return
      	a G_FILE_ERROR if we fail to write or close the file.
      
      	* gdk-pixbuf.h: remove GDK_PIXBUF_ERROR_IO, instead we'll use
      	G_FILE_ERROR_*. Rename enum to GdkPixbufError, properly following
      	the GError naming rules. Add GError** to load functions.
      7a4c6893
    • Owen Taylor's avatar
      cvsignore updates · 3f908d03
      Owen Taylor authored
      3f908d03
    • Owen Taylor's avatar
      remove generated files · a1a44c99
      Owen Taylor authored
      a1a44c99
    • Owen Taylor's avatar
      1bb41ea9
  2. 09 Oct, 2000 1 commit
    • Havoc Pennington's avatar
      contrib subdir · 518f32d9
      Havoc Pennington authored
      2000-10-06  Havoc Pennington  <hp@redhat.com>
      
      	* Makefile.am (SRC_SUBDIRS): contrib subdir
      
      	* gdk/gdkpixbuf.h: Move GdkPixbufAlphaMode to gdk-pixbuf library,
      	so it can be used in Xlib version
      
      	* demos/testpixbuf.c (update_timeout): error checking from 1.0
      	tree
      
      	* gtk/gdk-pixbuf-loader.c (gdk_pixbuf_loader_get_pixbuf): Sync
      	change from 1.0 tree that returns first frame of animation
      	if the loaded file is an animation.
      
              * contrib: add new directory to hold stuff that comes with GTK+
      	but isn't really part of GTK+ (for now, gdk-pixbuf-xlib)
      
      	* configure.in: add contrib/*
      
      2000-10-06  Havoc Pennington  <hp@redhat.com>
      
      	* gdk-pixbuf.h: add GdkPixbufAlphaMode
      
      2000-10-06  Havoc Pennington  <hp@redhat.com>
      
              This entry is a summary of the merged-in changes from 1.0.
      	Relevant original ChangeLog entries are spliced in after
      	this entry; the files they refer to are from the 1.0
      	gdk-pixbuf sources.
      
      	* pixops/pixops.c (pixops_composite_nearest): sync a small fix
      	from 1.0
      
      	* io-xpm.c (xpm_seek_string): add fscanf error check from 1.0
      	Add progressive loader from 1.0
      
      	* io-tiff.c (gdk_pixbuf__tiff_image_begin_load): mem leak fixes
      	from 1.0 tree
      
      	* io-pnm.c: new version from 1.0 tree
      
      	* io-jpeg.c (gdk_pixbuf__jpeg_image_load): sync from 1.0, use
      	malloc not g_malloc
      
      	* io-gif.c (lzw_read_byte): sync from 1.0, change a g_error to
      	g_warning
      	(gif_get_next_step): return 0 here, sync from 1.0
      
      	* gdk-pixbuf-util.c: sync email address change for Cody
      	Russell
      
      2000-09-11  Jeffrey Stedfast  <fejj@helixcode.com>
      
      	* gdk-pixbuf/io-pnm.c: Pretty much totally rewrote again because
      	last nights code was still "broken". Should now properly handle
      	all error conditions gracefully.
      
      2000-09-10  Jeffrey Stedfast  <fejj@helixcode.com>
      
      	* gdk-pixbuf/io-pnm.c: Rewrote.
      
      2000-09-09  Federico Mena Quintero  <federico@helixcode.com>
      
      	* gdk-pixbuf/pixops/pixops.c (pixops_composite_nearest): Compute
      	the correct dest offset.
      
      2000-08-25  Federico Mena Quintero  <federico@helixcode.com>
      
      	* gdk-pixbuf/io-xpm.c: #include <unistd.h>
      
      2000-08-05  Larry Ewing  <lewing@helixcode.com>
      
      	* gdk-pixbuf/io-tiff.c: stop leaking context->tempname.
      
      	* gdk-pixbuf/io-xpm.c: same as above.
      
      2000-07-26  Michael Meeks  <michael@helixcode.com>
      
      	* gdk-pixbuf/io-jpeg.c (gdk_pixbuf__jpeg_image_load): make
      	g_malloc a malloc.
      
      2000-07-21  Larry Ewing  <lewing@helixcode.com>
      
      	* gdk-pixbuf/io-xpm.c: add a fake progressive loader so that
      	xpm at least supports the progressive interface like the one in
      	io-tiff.c. This should be reimplemented as an actual progressive
      	loader.
      
      2000-07-19  Jonathan Blandford  <jrb@redhat.com>
      
      	* demo/pixbuf-demo.c (update_timeout): changed scaling level to
      	make it look better.
      	* gdk-pixbuf/testpixbuf.c (update_timeout): Patch from michael
      	meeks to handle errors better.
      518f32d9
  3. 04 Oct, 2000 1 commit
    • Havoc Pennington's avatar
      Fix copyrights · 502e5a88
      Havoc Pennington authored
      2000-10-04  Havoc Pennington  <hp@redhat.com>
      
      	* gtk/gtkstock.h, gtk/gtkstock.c, gtk/gtkiconfactory.h,
      	gtk/gtkiconfactory.c: Fix copyrights
      
      	* demos/testpixbuf.c: add inline pixbuf test
      502e5a88
  4. 25 Sep, 2000 1 commit
    • Havoc Pennington's avatar
      Draw the focus, and leave space to do so. · 9bec105a
      Havoc Pennington authored
      2000-09-25  Havoc Pennington  <hp@redhat.com>
      
      	* gtk/gtktextview.c: Draw the focus, and leave space to do so.
      
      	* gtk/gtktexttypes.c: Remove Latin1 conversion stuff
      
      	* gtk/gtktextbtree.c (gtk_text_btree_node_remove_data):
      	Fix a bug when removing node data, we didn't properly
      	re-splice the linked list after removing the data.
      
      	* gtk/gtktextview.c (gtk_text_view_key_press_event): Pass through
      	GDK_Tab as literal tab, Ctrl-Tab to tab to focus widget
      
      	* gtk/gtktextbuffer.c (selection_received): fix g_convert usage
      
      	* gtk/gtktextlayout.c (set_para_values): Set tab array
      	for the layout from the GtkTextTag.
      
      	* gtk/gtktexttypes.h: delete tab and search cruft,
      	remove g_convert() in favor of GLib version
      
      	* gtk/gtktexttypes.c: remove tab implementation from here,
      	move to Pango
      
      	* gtk/gtktexttag.h, gtk/gtktexttag.c: Implement
      	tab stuff using new PangoTabArray from Pango
      
      	* gtk/gtktexttag.c (gtk_text_attributes_fill_from_tags): Remove
      	unused border_width stuff
      9bec105a
  5. 14 Sep, 2000 1 commit
    • Owen Taylor's avatar
      Updates for new functions · 42e44b9f
      Owen Taylor authored
      Thu Sep 14 12:38:33 2000  Owen Taylor  <otaylor@redhat.com>
      
              * docs/reference/gdk/: Updates for new functions
      
      	* docs/reference/gdk/tmpl/gtkclipboard.sgml
      	docs/reference/gdk/tmpl/gtkselection.sgml: Updates
      	and new information.
      42e44b9f
  6. 07 Sep, 2000 2 commits
  7. 21 Jun, 2000 1 commit
    • Owen Taylor's avatar
      Removed mistakenly added generated sgml · 39440b43
      Owen Taylor authored
      Wed Jun 21 12:50:58 2000  Owen Taylor  <otaylor@redhat.com>
      
      	* docs/es/: Removed mistakenly added generated sgml
      
      	* docs/{gdk.texi,gtk.texi,gdk.sgml} macros.texi texinfo.tex:
      	Remove outdated info files.
      
      	* docs/gtk_tut* docs/package_tutorial.sh docs/tutorial:
      	Moved tutorial files into subdir
      
      	* docs/gtkfaq.sgml docs/faq/gtkfaq.sgml: Move FAQ into
      	subdir.
      
      	* docs/man/gtk_button.pod: Remove. (contents will be
      	integrated into gtk-reference button page.)
      
      	* configure.in docs/Makefile.am docs/tutorial/Makefile.am
      	docs/faq/Makefile.am: Adjust for new organization
      39440b43
  8. 05 Jun, 2000 3 commits
  9. 28 May, 2000 2 commits
    • Owen Taylor's avatar
      Fix typo · 15434db6
      Owen Taylor authored
      Sun May 28 12:16:01 2000  Owen Taylor  <otaylor@redhat.com>
      
      	* gtk/tmpl/gtkaspectframe.sgml: Fix typo
      15434db6
    • Damon Chaplin's avatar
      typo. · 8cd73f2f
      Damon Chaplin authored
      2000-05-28  Damon Chaplin  <damon@helixcode.com>
      
              * gdk/tmpl/event_structs.sgml: typo.
      8cd73f2f
  10. 22 May, 2000 1 commit
  11. 22 Apr, 2000 1 commit
  12. 13 Apr, 2000 1 commit
    • Federico Mena Quintero's avatar
      Your eyes are bloodshot. · 37ac7d59
      Federico Mena Quintero authored
      
      
      Your eyes are bloodshot.
      
      Your mouth starts to foam.
      
      Your hands are shaking.
      
      You know your need your fix.
      
      NEED MORE ABSTRACTION!
      
      2000-04-12  Federico Mena Quintero  <federico@helixcode.com>
      
      	This comes from an excellent idea by Tim Janik (timj@gtk.org) to
      	hook to the last unref operation.
      
      	* gdk-pixbuf/gdk-pixbuf.c (gdk_pixbuf_set_last_unref_handler): New
      	function to set the last unref handler for a pixbuf.
      	(gdk_pixbuf_finalize): New function to actually finalize a pixbuf.
      	It calls the pixbuf's destroy notification function and frees the
      	GdkPixbuf structure itself.
      	(gdk_pixbuf_unref): Use the last unref function of the pixbuf if
      	available.
      
      	* gdk-pixbuf/gdk-pixbuf-private.h (struct _GdkPixbuf): New fields
      	for the last unref handler and its user data.
      
      	* gdk-pixbuf/gdk-pixbuf-data.c (gdk_pixbuf_new_from_data): Use
      	g_new0() to allocate the pixbuf.
      
      	* gdk-pixbuf/gdk-pixbuf-loader.c (gdk_pixbuf_loader_class_init):
      	Fixed the call to gtk_signal_new() for the "frame_done" signal; it
      	was not specifying the `frame' argument.
      
      	* gdk-pixbuf/gdk-pixbuf-animation.c
      	(gdk_pixbuf_animation_get_width): Fixed docstring.
      	(gdk_pixbuf_animation_get_height): Likewise.
      	(gdk_pixbuf_animation_get_num_frames): Likewise.
      	(gdk_pixbuf_animation_get_frames): Likewise.
      
      	* doc/gdk-pixbuf-sections.txt: Updated with the new functions and
      	types.
      
      	* doc/tmpl/gdk-pixbuf.sgml: Added the description for GdkColorspace.
      
      	* doc/tmpl/scaling.sgml: Added the description for GdkInterpType.
      
      	* doc/tmpl/refcounting.sgml: Updated with the information about
      	the last unref handler.
      
      	* doc/tmpl/*.sgml: Markup tweaks.
      
      	* gdk-pixbuf/Makefile.am (libgnomecanvaspixbuf_la_LDFLAGS): Sigh,
      	update the libtool version number for libgnomecanvaspixbuf as
      	well.
      	(libpixbufloader_*_la_LDFLAGS): The loaders need to be versioned
      	as well, or the old ones won't work with the new stuff.  Also,
      	renamed the modules as follows.
      
      	* gdk-pixbuf/gdk-pixbuf-io.c (gdk_pixbuf_load_module): Now the
      	modules are called "libpixbufloader-<format>.so" instead of
      	"libpixbuf-<format>.so".  They needed renaming so that the new
      	loaders won't overwrite the old ones; even with the versioning
      	stuff, the new .so symlink to the .so.1.0.0 would overwrite the
      	old real .so file.
      37ac7d59
  13. 09 Apr, 2000 1 commit
  14. 14 Mar, 2000 2 commits
  15. 07 Mar, 2000 1 commit
  16. 29 Feb, 2000 1 commit
  17. 28 Feb, 2000 3 commits
    • Damon Chaplin's avatar
      new menu item sections and minor update to notebook section from Nicolas · 160e3574
      Damon Chaplin authored
      2000-02-28  Damon Chaplin  <damon@helixcode.com>
      
              * gtk/tmpl/gtkradiomenuitem.sgml:
              * gtk/tmpl/gtkmenuitem.sgml:
              * gtk/tmpl/gtknotebook.sgml: new menu item sections and minor update to
              notebook section from Nicolas GEORGE <nicolas.george@ens.fr>.
      
      2000-02-18  Damon Chaplin  <damon@helixcode.com>
      
              * gtk/tmpl/gtktooltips.sgml: patch from
              David Benson <daveb@idealab.com> to note that gtk_tooltips_set_colors()
              does not work.
      
      2000-02-09  Damon Chaplin  <damon@helixcode.com>
      
              * gdk/tmpl/input_methods.sgml: minor fix.
      160e3574
    • Damon Chaplin's avatar
      added a note about no-window widgets. · e809560d
      Damon Chaplin authored
      2000-06-14  Damon Chaplin  <damon@helixcode.com>
      
      	* gtk/tmpl/gtktooltips.sgml: added a note about no-window widgets.
      e809560d
    • Damon Chaplin's avatar
      new menu item sections and minor update to notebook section from Nicolas · a629fd7f
      Damon Chaplin authored
      2000-02-28  Damon Chaplin  <damon@helixcode.com>
      
              * gtk/tmpl/gtkradiomenuitem.sgml:
              * gtk/tmpl/gtkmenuitem.sgml:
              * gtk/tmpl/gtknotebook.sgml: new menu item sections and minor update to
              notebook section from Nicolas GEORGE <nicolas.george@ens.fr>.
      
      2000-02-18  Damon Chaplin  <damon@helixcode.com>
      
              * gtk/tmpl/gtktooltips.sgml: patch from
              David Benson <daveb@idealab.com> to note that gtk_tooltips_set_colors()
              does not work.
      
      2000-02-09  Damon Chaplin  <damon@helixcode.com>
      
              * gdk/tmpl/input_methods.sgml: minor fix.
      a629fd7f
  18. 22 Feb, 2000 1 commit
  19. 02 Feb, 2000 1 commit
    • Damon Chaplin's avatar
      rearranged a bit. · 4caf4dc7
      Damon Chaplin authored
      2000-02-03  Damon Chaplin  <damon@karuna.freeserve.co.uk>
      
      	* gdk/gdk-sections.txt: rearranged a bit.
      
      	* gdk/tmpl/event_structs.sgml: updated.
      
      	* gtk/gtk-sections.txt: added INCLUDE tag for Private Info section.
      
      	* gdk/tmpl/color_contexts.sgml: added note saying it is deprecated.
      	* gdk/tmpl/dnd.sgml: added note saying read the GTK+ DnD docs.
      4caf4dc7
  20. 01 Feb, 2000 2 commits
    • Damon Chaplin's avatar
      ran make templates. · 50ab749f
      Damon Chaplin authored
      2000-02-02  Damon Chaplin  <damon@karuna.freeserve.co.uk>
      
              * gdk/tmpl/*.sgml: ran make templates.
      
              * gdk/gdk-docs.sgml: rearranged sections.
      
              * gdk/tmpl/events.sgml: documented.
      
              * gdk/tmpl/general.sgml: documented.
      
              * gdk/tmpl/rgb.sgml: fixed a few '@' -> '#'.
      
              * gdk/gdk-sections.txt: rearranged a few bits, including moving
              GdkWChar and related functions from the input method section to the
              font section, and GdkCapStyle etc. from Drawing Primitives to GCs.
      
              * gdk/tmpl/images.sgml: documented.
      
              * gdk/tmpl/drawing.sgml: updated.
      
              * gdk/tmpl/regions.sgml: updated.
      
              * gdk/tmpl/input_contexts.sgml: documented.
      
              * gdk/tmpl/input_methods.sgml: documented.
      
              * gdk/tmpl/selections.sgml: changed xref to a link since Jade says
              a xref to a RefEntry is not supported.
      50ab749f
    • Federico Mena Quintero's avatar
      gnome_init() does not call gdk_rgb_init(), so don't mention that it does · d2014471
      Federico Mena Quintero authored
      2000-02-01  Federico Mena Quintero  <federico@helixcode.com>
      
      	* doc/tmpl/rendering.sgml: gnome_init() does not call
      	gdk_rgb_init(), so don't mention that it does in the
      	documentation.  Thanks to Alexander Kruuse <kruuse@home.se> for
      	pointing this out.
      d2014471
  21. 22 Jan, 2000 1 commit
    • Federico Mena Quintero's avatar
      Removed the x_set and y_set arguments. Now they are always on and start · 72ee1f0c
      Federico Mena Quintero authored
      2000-01-22  Federico Mena Quintero  <federico@helixcode.com>
      
      	* gdk-pixbuf/gnome-canvas-pixbuf.c (PixbufPrivate): Removed the
      	x_set and y_set arguments.  Now they are always on and start with
      	defaults of 0.0 in units.
      	(gnome_canvas_pixbuf_class_init): Likewise.
      	(gnome_canvas_pixbuf_set_arg): Likewise.
      	(gnome_canvas_pixbuf_get_arg): Likewise.
      	(compute_viewport_affine): Likewise; always use the priv->x and
      	priv->y fields.
      
      	* doc/tmpl/gnome-canvas-pixbuf.sgml: Modified to reflect the
      	removal of the x_set/y_set arguments.
      72ee1f0c
  22. 21 Jan, 2000 1 commit
    • Federico Mena Quintero's avatar
      Return the same pixbuf as the input parameter. · bb8a5637
      Federico Mena Quintero authored
      2000-01-21  Federico Mena Quintero  <federico@helixcode.com>
      
      	* gdk-pixbuf/gdk-pixbuf.c (gdk_pixbuf_ref): Return the same pixbuf
      	as the input parameter.
      
      	* gdk-pixbuf/gdk-pixbuf-animation.c (gdk_pixbuf_animation_ref):
      	Return the same animation as the input parameter.
      bb8a5637
  23. 19 Jan, 2000 1 commit
    • Damon Chaplin's avatar
      Started. · 5d9b2ed6
      Damon Chaplin authored
      	* gtk/tmpl/gtkscrollbar.sgml: Started.
      5d9b2ed6
  24. 17 Jan, 2000 1 commit
    • Federico Mena Quintero's avatar
      Removed the broken --enable-canvas-pixbuf option. Added the stuff · 4f0f7330
      Federico Mena Quintero authored
      2000-01-16  Federico Mena Quintero  <federico@helixcode.com>
      
      	* configure.in: Removed the broken --enable-canvas-pixbuf option.
      	Added the stuff necessary to substitute the variables in
      	gnomecanvaspixbufConf.sh.in.
      
      	* gnomecanvaspixbufConf.sh.in: New gnome-config handler for the
      	tiny gnomecanvaspixbuf library.
      
      	* Makefile.am: Build gnomecanvaspixbufConf.sh.
      
      	* gdk-pixbuf/Makefile.am: Create a libgnomecanvaspixbuf and only
      	build it if gdk-pixbuf is being built outside of gnome-libs.
      
      	* doc/gdk-pixbuf-sections.txt: Added gdk_pixbuf_render_pixmap_and_mask().
      
      	* gdk-pixbuf/gdk-pixbuf-render.c
      	(gdk_pixbuf_render_pixmap_and_mask): Renamed from
      	gdk_pixbuf_render_pixmap().  Do not create the mask if it is not
      	needed, and do not use a clipping mask when rendering the pixmap.
      	Tweaked documentation a little.
      
      	* HACKING: New file with hacking policies for the gdk-pixbuf
      	module.
      
      	* doc/Makefile.am (tmpl_sources): Added missing backslash.
      
      	* doc/Makefile.am: Use gnomecanvaspixbuf in gnome-config when
      	scanning for docstrings.
      
      	* gdk-pixbuf/gdk-pixbuf-util.c (gdk_pixbuf_copy_area): Made sanity
      	checks more stringent.  Removed "gint" abominations.  Made
      	documentation consistent with the rest of the functions.
      
      	* doc/gdk-pixbuf-sections.txt: Added gdk_pixbuf_copy_area() to the
      	utilities section.
      4f0f7330
  25. 08 Jan, 2000 1 commit
  26. 07 Jan, 2000 2 commits
    • Jonathan Blandford's avatar
      Added progressive animation loading. Added progressive animation loading. · 84c85a1a
      Jonathan Blandford authored
      2000-01-07  Jonathan Blandford  <jrb@redhat.com>
      
      	* gdk-pixbuf/gdk-pixbuf-io.c: Added progressive animation loading.
      	* gdk-pixbuf/gdk-pixbuf-io.h: Added progressive animation loading.
      	* gdk-pixbuf/gdk-pixbuf-loader.c: Added progressive animation
      	loading.
      	* gdk-pixbuf/gdk-pixbuf-loader.h: Added progressive animation
      	loading.
      	* gdk-pixbuf/io-gif.c (image_load_increment): I think the
      	ref-counting mess is finally fixed.  Added progressive animation
      	loading.
      
      I think progressive animation loading all works now.  It's all
      documented too, if anyone wants to play with it.
      84c85a1a
    • Jonathan Blandford's avatar
      much longer long description added. · 0e86d280
      Jonathan Blandford authored
      2000-01-07  Jonathan Blandford  <jrb@redhat.com>
      
      	* doc/tmpl/gdk-pixbuf-loader.sgml: much longer long description
      	added.
      0e86d280
  27. 06 Jan, 2000 1 commit
    • Owen Taylor's avatar
      Added scaling functions into gtk-doc framework. · 65de04cd
      Owen Taylor authored
      2000-01-05  Owen Taylor  <otaylor@redhat.com>
      
      	* doc/Makefile.am doc/gdk-pixbuf-sections.txt
      	  doc/gdk-pixbuf.sgml doc/tmpl/scaling.sgml:
      	Added scaling functions into gtk-doc framework.
      
      	* gdk-pixbuf/gdk-pixbuf-scale.c: Documentation fixes.
      
      	* gdk-pixbuf/testpixbuf-scale.c (expose_cb): Simplify a bit.
      
      	* gdk-pixbuf/pixops/pixops.c (pixops_composite_color): Return
      	immediately if scale_x or scale_y is 0.
      65de04cd
  28. 05 Jan, 2000 1 commit