Small optimization

0d04bd7f · Matthias Clasen · d828e504 · 0d04bd7f · 0d04bd7f · 0d04bd7f
Commit 0d04bd7f authored Mar 26, 2006 by Matthias Clasen
Hide whitespace changes
Inline Side-by-side

Showing with 11 additions and 8 deletions

ChangeLog ChangeLog +5 -0

ChangeLog.pre-2-10 ChangeLog.pre-2-10 +5 -0

gtk/gtkcellrenderertext.c gtk/gtkcellrenderertext.c +1 -8

No files found.
--- a/ChangeLog
+++ b/ChangeLog
+2006-03-26  Matthias Clasen  <mclasen@redhat.com>
+
+	* gtk/gtkcellrenderertext.c (gtk_cell_render_text_get_property):
+	Avoid an unnecessary strdup.  (#336013)
+
 2006-03-24  Matthias Clasen  <mclasen@redhat.com>

 	* gtk/gtktextview.c (gtk_text_view_value_changed): Don't call

--- a/ChangeLog.pre-2-10
+++ b/ChangeLog.pre-2-10
+2006-03-26  Matthias Clasen  <mclasen@redhat.com>
+
+	* gtk/gtkcellrenderertext.c (gtk_cell_render_text_get_property):
+	Avoid an unnecessary strdup.  (#336013)
+
 2006-03-24  Matthias Clasen  <mclasen@redhat.com>

 	* gtk/gtktextview.c (gtk_text_view_value_changed): Don't call

--- a/gtk/gtkcellrenderertext.c
+++ b/gtk/gtkcellrenderertext.c
@@ -689,14 +689,7 @@ gtk_cell_renderer_text_get_property (GObject        *object,
      break;

    case PROP_FONT:
-      {
-        /* FIXME GValue imposes a totally gratuitous string copy
-         * here, we could just hand off string ownership
-         */
-        gchar *str = pango_font_description_to_string (celltext->font);
-        g_value_set_string (value, str);
-        g_free (str);
-      }
+        g_value_take_string (value, pango_font_description_to_string (celltext->font);
      break;
      
    case PROP_FONT_DESC: