Skip to content

Use a single suggested words list for Editor

Victor Marequested to merge
vic-ma/crosswords:single-list into master

Related to #263 (closed).

This MR removes the two suggested words lists and replaces them with a single suggested words list that switches between across and down, based on the cursor's direction.

Sidebar jumping bug

This MR does not aim to fix #263 (closed). However:

  • This MR does naturally reduce the jumpiness by a lot.
  • This MR makes the job of fixing the jumpiness easier.

Bottom panel changing width

With this MR, changing the cells on the grid can cause the sidebar to jump. This is because the grid composition and clue size distribution stats can vary a lot in the amount of width they require, based on the grid.

The jumping can be fixed by giving the sidebar an adequate width-request. But if we do that, I think it's better to do it in !230 (closed).

But I think the variable width of the bottom panel is itself a problem, regardless of the sidebar. Even on master, when you change the grid, it can cause the window to increase or decrease dramatically in size, causing a "jumpy" feeling.

Grid composition stat

Currently, the grid composition stat looks like this:

Grid Composition: 1 normal cells, 1 block cells, 1 null cells

I think we should split it into three seperate statistics, like this:

Normal cells: 1
Block cells:  1
Null cells:   1

I think that also makes it more readable. I think it would also be useful to add a percentage-of-grid stat, like this:

Normal cells: 1 (17%)
Block cells:  2 (33%)
Null cells:   3 (50%)

Clue size distribution stat

It might also make sense to restrict the clue size distribution stat's width, by scaling down the size of each block, until the longest line of blocks is small enough.

Before:

Clue length 4: █ █ █ █ █ █ █ █ █ █ █ █ █ █ █ █ █ █ █ █  (20)
Clue length 6: █ █ █ █                                  (4)

After:

Clue length 4: ▌▌▌▌▌▌▌▌▌▌ (20)
Clue length 6: ▌▌         (4)

Block symmetry selector

With this MR, the block symmetry selector looks a little weird, because Block placement gets split into two lines, and Half Rotation appears in the middle of the two lines, and is also truncated to Half Rot....

Maybe a good change would be to change Block placement to just Blocks. The idea of "block symmetry" is implied by the Crossword Symmetry heading.

This MR

Screencast_From_2025-06-25_22-08-03

Bottom panel behaviour on master

Screencast_From_2025-06-25_23-12-16

Merge request reports