Skip to content

Add width-request to editor sidebar styling

Description

This is a possible fix for #263 (closed).

Essentially, it reverts the behaviour back to what it was before, where the sidebar has a minimum width of 500.

The only difference from before is that I'm adding the width-request property to the ancestor sidebar widget, rather than the individual clue list widgets. @Txnmxy I think that's what you were hinting at in your commit message?

However, the jumping sidebar problem still exists for Extra Large crosswords (like it always did). So I'm not sure if this is the right solution. Maybe the proper solution would be to figure out what the maximum width of the sidebar is, based on the dimensions of the grid, and then dynamically set the minimum width of the sidebar, using set_size_request?

In any case, this solution is far simpler and is at least a good temporary fix. It only breaks for Extra Large crosswords.

Related Issues

Fixes #263 (closed).

Visual Diff (if any)

This video shows:

  1. The current upstream behaviour.
  2. The behaviour with this MR applied (and how it's still broken for Extra Large).
  3. The behaviour of the public release Flatpak.

demo

Merge request reports

Loading