Commit 7c74b48b authored by Carlos Garnacho's avatar Carlos Garnacho

libtracker-miner: Do not insert partial/empty sparql on error

The check for these errors was done specifically so we could still
insert (even if incomplete) data on tracker-extract failures, when
we used to communicate with it directly from tracker-miner-fs.

Nowadays, tracker-extract is a TrackerDecorator, and tracker-miner-fs
should most likely receive only errors here on ENOENT and other errors
that affect the file and its info as a whole. In these situations
we end up with a task with a completely empty sparql string, which
doesn't help much here.
parent acbb1d95
......@@ -1419,11 +1419,6 @@ item_add_or_update_continue (TrackerMinerFS *fs,
g_message ("Could not process '%s': %s", uri, error->message);
fs->priv->total_files_notified_error++;
if (!g_error_matches (error, G_IO_ERROR, G_IO_ERROR_NOT_FOUND) &&
!g_error_matches (error, G_IO_ERROR, G_IO_ERROR_CANCELLED)) {
sparql_task = tracker_sparql_task_new_with_sparql (file, ctxt->builder);
}
} else {
if (ctxt->urn) {
gboolean attribute_update_only;
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment