code review fixes

Status Job ID Name Coverage
  Test
failed #723670
flatpak
flatpak

01:00:01

 
Name Stage Failure
failed
flatpak Test The script exceeded the maximum execution time set for the job
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -DFLATPAK_BINDIR=\"/app/bin\" -DFLATPAK_SYSTEMDIR=\"/var/lib/flatpak\" -DFLATPAK_CONFIGDIR=\"/var/run/host/etc/flatpak\" -DFLATPAK_BASEDIR=\"/app/share/flatpak\" -DFLATPAK_TRIGGERDIR=\"/app/share/flatpak/triggers\" -DSYSTEM_FONTS_DIR=\"/usr/share/fonts\" -DSYSTEM_HELPER_USER=\"flatpak\" -DSYSTEM_FONT_CACHE_DIRS=\"/var/cache/fontconfig:/usr/lib/fontconfig/cache\" -DG_LOG_DOMAIN=\"flatpak\" -I./libglnx -I./common -I./common -include config.h -DHELPER=\"/app/libexec/flatpak-bwrap\" -DDBUSPROXY=\"/app/libexec/flatpak-dbus-proxy\" -pipe -Wall -Werror=empty-body -Werror=strict-prototypes -Werror=missing-prototypes -Werror=implicit-function-declaration -Werror=format=2 -Werror=format-security -Werror=format-nonliteral -Werror=pointer-arith -Werror=init-self -Werror=missing-declarations -Werror=return-type -Werror=overflow -Werror=int-conversion -Werror=incompatible-pointer-types -Werror=misleading-indentation -Werror=missing-include-dirs -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/gio-unix-2.0 -pthread -I/app/include/ostree-1 -I/usr/include/gio-unix-2.0 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -pthread -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/libsoup-2.4 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -pthread -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/libxml2 -I/app/include/json-glib-1.0 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -pthread -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/libappstream-glib -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/gdk-pixbuf-2.0 -pthread -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/uuid -DFLATPAK_COMPILATION -I./app -I./app -DLOCALEDIR=\"/app/share/locale\" -O2 -g -pipe -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -MT app/libflatpak_app_la-parse-datetime.lo -MD -MP -MF app/.deps/libflatpak_app_la-parse-datetime.Tpo -c app/parse-datetime.c  -fPIC -DPIC -o app/.libs/libflatpak_app_la-parse-datetime.o
mv -f app/.deps/libflatpak_app_la-flatpak-table-printer.Tpo app/.deps/libflatpak_app_la-flatpak-table-printer.Plo
mv -f app/.deps/libflatpak_app_la-flatpak-builtins-utils.Tpo app/.deps/libflatpak_app_la-flatpak-builtins-utils.Plo
mv -f app/.deps/libflatpak_app_la-parse-datetime.Tpo app/.deps/libflatpak_app_la-parse-datetime.Plo
/bin/sh ./libtool --tag=CC --mode=link gcc -pipe -Wall -Werror=empty-body -Werror=strict-prototypes -Werror=missing-prototypes -Werror=implicit-function-declaration -Werror=format=2 -Werror=format-security -Werror=format-nonliteral -Werror=pointer-arith -Werror=init-self -Werror=missing-declarations -Werror=return-type -Werror=overflow -Werror=int-conversion -Werror=incompatible-pointer-types -Werror=misleading-indentation -Werror=missing-include-dirs -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/gio-unix-2.0 -pthread "-I./libglnx" -std=gnu99 -fvisibility=hidden -O2 -g -pipe -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -avoid-version -Bsymbolic-functions -export-symbols-regex "^glnx_" -no-undefined -export-dynamic -L/app/lib -Wl,-z,relro,-z,now -Wl,--as-needed -o libglnx.la libglnx/la-glnx-backports.lo libglnx/la-glnx-local-alloc.lo libglnx/la-glnx-errors.lo libglnx/la-glnx-console.lo libglnx/la-glnx-dirfd.lo libglnx/la-glnx-fdio.lo libglnx/la-glnx-lockfile.lo libglnx/la-glnx-xattrs.lo libglnx/la-glnx-shutil.lo -lgio-2.0 -lgobject-2.0 -lglib-2.0
Running after_script
Uploading artifacts for failed job
Pulling docker image gitlab/gitlab-runner-helper:x86_64-4c96e5ad ...
ERROR: Job failed: execution took longer than 1h0m0s seconds