Commit 615b8087 authored by Christian Hergert's avatar Christian Hergert
Browse files

pipeline: don't pass cancellable to pty creation

Creating a PTY with a cancellable will fail due to lower levels complaining
about socket initialization with cancellables. This works around it by
ensuring we don't propagate the cancellable to vte_pty_new_sync().
parent 35120ca3
......@@ -1053,11 +1053,15 @@ ide_build_pipeline_initable_init (GInitable *initable,
g_assert (IDE_IS_BUILD_PIPELINE (self));
g_assert (IDE_IS_CONFIGURATION (self->configuration));
g_assert (!cancellable || G_IS_CANCELLABLE (cancellable));
/* Create a PTY for subprocess launchers */
self->pty = vte_pty_new_sync (VTE_PTY_DEFAULT, cancellable, error);
/*
* Create a PTY for subprocess launchers. PTY initialization does not
* support cancellation, so do not pass @cancellable along to it.
*/
self->pty = vte_pty_new_sync (VTE_PTY_DEFAULT, NULL, error);
if (self->pty == NULL)
return FALSE;
IDE_RETURN (FALSE);
g_signal_connect_object (self->configuration,
"notify::ready",
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment