Mike Gilbert (f4feed74) at 14 May 04:31
Bug: https://bugs.gentoo.org/906254 Fixes: 4cd0ec66
Mike Gilbert (f4feed74) at 13 May 16:21
Compile nm-sstp-pppd-mppe.c when !WITH_PPP_MPPE_KEYS
Mike Gilbert (b31e07db) at 23 Apr 15:28
Fixes an error when running tests in a sandbox on Gentoo Linux.
Mike Gilbert (b31e07db) at 23 Apr 00:25
testapi: remove leading slash from "/missing.xml"
Mike Gilbert (efdd5338) at 21 Apr 12:50
Mike Gilbert (04ba6f96) at 20 Jan 19:23
Remove duplicate entry for 'da' from help/LINGUAS
... and 1 more commit
I think you meant to write GNU_SKIP_RETURNCODE
here, instead of a literal 77
.
Thanks!
This should be running
g_test_skip("fr_FR.UTF-8 locale not available");
in the test itself instead.
I'm happy to update my patch to call g_test_skip() instead.
To do that, we would need to either call setlocale() within the test function, or pass in its return value in somehow. What's your preference?
I have dropped the change that checks the environment variable. You can merge the original change when you find a suitable solution to your CI problem.
Mike Gilbert (6f0503b1) at 23 Aug 15:29
or somebody writes a piece of code (Python preferred) to parse the output of
meson test
and check that no tests were skipped.
This seems like an overly complicated solution to me.
I'm happy to reverse the logic if that's what @hadess would prefer.
I pushed another commit that changes the logic so that the test will only be skipped if ALLOW_TEST_SKIPS is set in the environment.
This variable would be unset in the CI environment, resulting in the previous behavior (failure) if the locale us unavailable. On Gentoo, we can set it to allow the test to be skipped.