It is annotated as such upstream, so presumably just needs a regen? The annotation was added relatively late in the cycle.
I can not reproduce this with F39 or F40. There seems to be something different going on. Your issue might be in:
Especially if it's a gvfs issue, try rebooting your system to see if it persists.
In either case, nothing to do with us, we just tell gtk to open a filedialog for us and give us the files.
This must bei an issue with your desktop portal implementation. Which one do you use for file choosers? It works fine for me with xdg-desktop-portal-gnome.
Fina Wilke (2375cbeb) at 25 Mar 18:25
Cherry-pick of !236, this should apply cleanly to main as well.
Fina Wilke (2375cbeb) at 25 Mar 18:25
CI: Try to fix builds on non-nightly
You might be right. My problem is mostly with trying to fetch the app via gio::Application::default()
, as this has a runtime panic if we are accidentally not on the gtk thread.
Regarding global state in general: What I would ultimately like is for all detail views to have a direct 1:1 connection to a backup config, and not rely on storing the active config somewhere in a global. This removes the current config check being fallible, but arguably requires us to have one instance of the detail view each time the view is pushed.
Cherry-pick of !236, this should apply cleanly to main as well.
Fina Wilke (2375cbeb) at 25 Mar 18:13
CI: Try to fix builds on non-nightly
Fina Wilke (9094946c) at 25 Mar 18:13
CI: Try to fix builds on non-nightly
Fina Wilke (9094946c) at 25 Mar 18:02
CI: Try to fix builds on non-nightly
Fina Wilke (816217be) at 25 Mar 18:01
CI: Try to fix builds on non-nightly
Fina Wilke (df4eeb4f) at 25 Mar 17:57
Revert "Revert "config/pattern: Move to storing fnmatch as string""
Now that 0.8 is out we can land this, right?
done
Fina Wilke (543e8c49) at 25 Mar 17:56
Revert "Revert "config/pattern: Move to storing fnmatch as string""
... and 128 more commits
Thanks. While we do want to change archives view soon-ish (probably not for 0.8), we might still be needing something like this even then so this seems useful either way.