Daiki Ueno (da31c5bc) at 28 Mar 06:29
This turns the -Dgcrypt
build time option into a tri-state option,
which enables user to choose which cryptographic library to link with.
It currently supports libgcrypt (libgcrypt
) and GnuTLS (gnutls
);
for the latter, a couple of legacy algorithms are disabled, namely
RIPEMD160 and PBES1-DES-SHA1 though it will be added in GnuTLS 3.8.5
for compatibility.
Daiki Ueno (da31c5bc) at 28 Mar 06:29
.gitlab-ci.yml: Exercise both libgcrypt and gnutls crypto backends
... and 2 more commits
Thank you for the review!
Daiki Ueno (da31c5bc) at 28 Mar 06:12
.gitlab-ci.yml: Exercise both libgcrypt and gnutls crypto backends
... and 3 more commits
Thanks; fixed.
Daiki Ueno (5e9f9643) at 28 Mar 06:11
.gitlab-ci.yml: Exercise both libgcrypt and gnutls crypto backends
... and 1 more commit
Daiki Ueno (06a3468d) at 28 Mar 01:32
.gitlab-ci.yml: Exercise both libgcrypt and gnutls crypto backends
... and 1 more commit
Good catch, fixed.
Daiki Ueno (21df8963) at 26 Mar 12:02
.gitlab-ci.yml: Exercise both libgcrypt and gnutls crypto backends
... and 1 more commit
Daiki Ueno (1e18cdb4) at 26 Mar 05:40
.gitlab-ci.yml: Exercise both libgcrypt and gnutls crypto backends
... and 1 more commit
I managed to split gcr/gcr-parser.c
into backend specific files (gcr/gcr-parser-libgcrypt.c
and gcr/gcr-parser-gnutls.c
).
Daiki Ueno (8df477a4) at 26 Mar 02:39
.gitlab-ci.yml: Exercise both libgcrypt and gnutls crypto backends
... and 1 more commit
I haven't thought about it; if that works, that is certainly great, as we don't need to invest in a new development :-).
Do you see all PKCS#11 attributes defined in trust-assertions are stored along certificates under ~/.config/pkcs11/certs
in a .p11-kit format?
LGTM!
Some indentation mismatch here. Also, it might be a little more explicit if you call g_variant_ref_sink
on variant
before calling gkd_secret_property_parse_fields
so this code assumes the ownership (and gkd_secret_property_parse_fields
doesn't).
Sure, split it as a separate function.
Added err
label to consolidate the error handling.
Merged into the switch block.