Commit a95c2500 authored by Christian Hergert's avatar Christian Hergert

suggestions: handle popup/down transitions more reliably

When we are transitioning from visible to non-visible, we have a number
of operations in play (animating, then hiding, etc). We need to do more
than just check for mapped before we short-circuit.

Fixes #49
parent a703bace
......@@ -823,7 +823,8 @@ dzl_suggestion_popover_popup (DzlSuggestionPopover *self)
return;
}
if (gtk_widget_get_mapped (GTK_WIDGET (self)))
if (gtk_widget_get_mapped (GTK_WIDGET (self)) &&
gtk_revealer_get_reveal_child (self->revealer))
return;
if (self->relative_to != NULL)
......@@ -964,8 +965,10 @@ dzl_suggestion_popover_items_changed (DzlSuggestionPopover *self,
DZL_EXIT;
}
if (gtk_widget_get_mapped (GTK_WIDGET (self)))
return;
if (gtk_widget_get_mapped (GTK_WIDGET (self)) &&
gtk_revealer_get_child_revealed (self->revealer) &&
gtk_revealer_get_reveal_child (self->revealer))
DZL_EXIT;
/*
* If we are currently animating in the initial view of the popover,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment