Sounds good to me. You might as well want to check for other commented out code. You can probably use a regex search for that.
Sorry, but I'm not in a position to review it. Emmanuele takes care of that.
I guess so, but don't forget to test if that'll indeed work
Thanks! I'll look into that.
Can you elaborate? I don't quite understand what you mean.
Maksym Hazevych (07b3412a) at 05 Feb 12:19
Maksym Hazevych (cbe2b33d) at 05 Feb 12:18
IMHO I'd forward the glitch issue to GTK for further investigation. As for the start-up speed — on my video recording it is being opened for about fifth time in a row, so this shouldn't be synchronization's fault. IMHO, 10-15 seconds is a bit much for an app to load, but I understand this might be out of your control. In the end, Matrix seems to be slow by itself.
Thanks for a nonetheless great app, I'd say it's already better then the official client, a few nitpicks aside.
Can confirm that both the long loading times and glitches are still present on in Fractal 6 from Flathub on Fedora 39 with proprietary Nvidia drivers (the desktop runs on integrated GPU though, so I doubt it's important)
Maksym Hazevych (07b3412a) at 05 Jan 01:25
beginners/components: Update images, add a new one
... and 2 more commits
This MR updates code templates, indents code according to these templates, fixes critical C error, updates the accompanying text, and includes updated images in both light and dark variants.
This is cherry-picked form !135 and updated, and can be merged right away. As with every one of these MRs, I've tested each step in the tutorial in each language — it works (now).
Maksym Hazevych (6acdac83) at 05 Jan 01:17
getting_started/opening_files: Group async instructions to related ...
... and 32 more commits
Maksym Hazevych (56c6797f) at 04 Jan 20:47
getting_started/content_view: Fix Vala code block
... and 5 more commits
Maksym Hazevych (cbe2b33d) at 04 Jan 20:46
getting_started: Update text to reflect actual strings
... and 1 more commit
Rebased
Maksym Hazevych (422b17e9) at 04 Jan 19:54
online-accounts: Use provider name in removal toast
... and 102 more commits
Maksym Hazevych (3bdb4a77) at 04 Jan 19:45
online-accounts: Use provider name in removal toast
... and 3 more commits