1. 30 Jul, 2019 3 commits
    • Daniel Garcia Moreno's avatar
      texture-cache: Remove also scaled keys from the cache · 8299368b
      Daniel Garcia Moreno authored
      We're storing in the texture cache images and scaled images appending
      the scaling factor to the key. When a file changes the cache key
      corresponding to that file is removed, but not the keys for the scaled
      ones so that images in the cache are never reloaded.
      
      This patch removes all keys from the cache related to the file that
      changes, including those with the scaling factor.
      
      A new hash table was added to keep track of the cached files scales, so
      for a file stored with the key "KEY" we store in the new cache the
      scales of this file that we've in the cache:
      
       * KEY -> [1.000000, 2.000000, ...]
      
      When the KEY is removed from the cache, we can look now in this new hash
      table and for each scale we also remove the key "KEY1.000000",
      "KEY2.000000", etc.
      
      GNOME/gnome-shell!567
      8299368b
    • Niels De Graef's avatar
      Ensure G_PARAM_STATIC_STRINGS for all properties · 28ab1f4a
      Niels De Graef authored
      In `st`, we can do this by using `ST_PARAM_*`. In the other code files,
      just use `G_PARAM_STATIC_STRINGS` directly.
      
      This is just a minor convenience to prevent a few unnecessary string
      copies.
      
      !646
      28ab1f4a
    • Niels De Graef's avatar
      d3601142
  2. 29 Jul, 2019 5 commits
  3. 28 Jul, 2019 8 commits
  4. 27 Jul, 2019 1 commit
  5. 26 Jul, 2019 1 commit
  6. 25 Jul, 2019 4 commits
  7. 24 Jul, 2019 6 commits
  8. 23 Jul, 2019 12 commits
    • Florian Müllner's avatar
      ci: Add eslint job to review stage · 3b5d13a0
      Florian Müllner authored
      We have now reduced the number of eslint errors enough to add it to
      the CI pipeline. There are still plenty of errors left though, so we
      cannot simply run eslint and fail on any errors. So instead, run it
      through a fancy script that:
      
       - generates an eslint report using the "regular" configuration
       - generates an eslint report using the "legacy" configuration
       - creates a combined report with errors common to both configurations
      
      When the pipeline is running for a branch or tag, the final report is
      printed out and the job succeeds (we know there are errors left);
      when the pipelne is running for a merge request, we fail if any errors
      are reported for the lines modified/added by the MR.
      
      !627
      3b5d13a0
    • Florian Müllner's avatar
      ci: Merge 'source_check' stage into 'review' · ed37ba1d
      Florian Müllner authored
      GNOME apps use 'review' for the CI stage that generates and exports a
      flatpak bundle after a successful build, so they need some other name
      for anything that is checked before building; that's how we ended up
      with the somewhat awkward 'source_check' stage (inherited from Polari).
      
      But since the commit log check added a 'review' stage that runs pre-build,
      use that for all checks that are performed before the build stage.
      
      !627
      ed37ba1d
    • Florian Müllner's avatar
      ci: Include git in extension-ci image · 8ea6fd19
      Florian Müllner authored
      It's useful for anything that does not want to limit itself to the
      checked out branch, like comparing source and target branch.
      
      !627
      8ea6fd19
    • Florian Müllner's avatar
      perf: Shut up another eslint error · 93a461f3
      Florian Müllner authored
      The functions here are asynchronous to handle control back to the
      mainloop while waiting for an action to complete, not to run operations
      in parallel. That is, the race condition the rule is protecting against
      isn't an issue here, so disable the error.
      
      !627
      93a461f3
    • Florian Müllner's avatar
      perf: Shut up an eslint error · fda7c9b0
      Florian Müllner authored
      The while(true) loop is intentional here and not a bug, so disable
      the corresponding eslint rule.
      
      !627
      fda7c9b0
    • Florian Müllner's avatar
      style: Disable camelcase rule for GObject properties · 1e13f32c
      Florian Müllner authored
      For GObject properties, we follow the convention of all-lowercase,
      dash-separated names. Those translate to underscores in getters/setters,
      so exempt them from the newly added "camelcase" rule.
      
      !627
      1e13f32c
    • Florian Müllner's avatar
      cleanup: Mark globals used from other modules as exported · e3575595
      Florian Müllner authored
      eslint cannot figure out that those symbols are used from other modules
      via imports, so they trigger unused-variable errors. To fix, explicitly
      mark those symbols as exported.
      
      GNOME/gnome-shell!627
      e3575595
    • Florian Müllner's avatar
      cleanup: Mark unused (but useful) variables as ignored · 71759a07
      Florian Müllner authored
      While we aren't using those destructured variables, they are still useful
      to document the meaning of those elements. We don't want eslint to keep
      warning about them though, so mark them accordingly.
      
      !627
      71759a07
    • Florian Müllner's avatar
      cleanup: Remove some unhelpful unused variables in destructuring · 11b116cb
      Florian Müllner authored
      We aren't using them, and they don't add much in terms of clarity,
      so drop them to fix a couple of eslint errors.
      
      !627
      11b116cb
    • Florian Müllner's avatar
      cleanup: Mark unused arguments as unused · 2f97a1a5
      Florian Müllner authored
      This will stop eslint from warning about them, while keeping their
      self-documenting benefit.
      
      !627
      2f97a1a5
    • Florian Müllner's avatar
      cleanup: Remove some unhelpful unused arguments · 79cf3a6d
      Florian Müllner authored
      Those unused arguments aren't bugs - unbeknownst to eslint, they all
      correspond to valid signal parameters - but they don't contribute
      anything to clarity, so just remove them anyway.
      
      !627
      79cf3a6d
    • Florian Müllner's avatar
      lint: Allow marking variables/arguments as unused · 0257de1b
      Florian Müllner authored
      Unused variables or arguments can indicate bugs, but they can also
      help document the code, in particular in case of signal handlers
      and destructuring.
      
      Account for this by keeping the error, but set up patterns that allow
      us to opt out of if for individual variables/arguments. For arguments
      we pick a '_' prefix, while for variables we go with a suffix instead,
      to not accidentally exempt private module-scope variables.
      
      !627
      0257de1b