1. 21 Apr, 2009 1 commit
  2. 20 Apr, 2009 2 commits
  3. 19 Apr, 2009 2 commits
  4. 17 Apr, 2009 4 commits
  5. 15 Apr, 2009 1 commit
    • Jonathan Matthew's avatar
      Use callback methods on the window/pane object, rather than just the text · d588f055
      Jonathan Matthew authored
      2009-04-15  Jonathan Matthew  <jonathan@d14n.org>
      
      	* plugins/lyrics/lyrics/__init__.py:
      	Use callback methods on the window/pane object, rather than just the
      	text buffer.  Previously, if the window was destroyed while the search
      	was in progress, the text buffer was kept alive by the reference in
      	the callback.  gail expects the text buffer to be destroyed along with
      	the text view widget, and crashes if it isn't.  Fixes #473757
      	properly.
      
      svn path=/trunk/; revision=6293
      d588f055
  6. 14 Apr, 2009 1 commit
  7. 12 Apr, 2009 8 commits
    • Jorge Gonzalez Gonzalez's avatar
      Updated Spanish translation · e8f22366
      Jorge Gonzalez Gonzalez authored
      svn path=/trunk/; revision=6291
      e8f22366
    • Gabor Kelemen's avatar
      Translation updated. · 8eb712a0
      Gabor Kelemen authored
      2009-04-12  Gabor Kelemen  <kelemeng@gnome.hu>
      
      	* hu.po: Translation updated.
      	
      
      svn path=/trunk/; revision=6290
      8eb712a0
    • Jonathan Matthew's avatar
      Read the initial track submission handshake URL from gconf key · 9f5baf15
      Jonathan Matthew authored
      2009-04-12  Jonathan Matthew  <jonathan@d14n.org>
      
      	* data/rhythmbox.schemas:
      	* lib/rb-preferences.h:
      	* plugins/audioscrobbler/rb-audioscrobbler.c:
      	(rb_audioscrobbler_do_handshake):
      	Read the initial track submission handshake URL from gconf key
      	/apps/rhythmbox/audioscrobbler/scrobbler_url, allowing
      	it to be redirected to other services such as libre.fm without having
      	to modify /etc/hosts.
      
      svn path=/trunk/; revision=6289
      9f5baf15
    • Christophe Fergeau's avatar
      patch by: Sebastian Dransfeld <sebastid@tango.flipp.net> · ecf430c3
      Christophe Fergeau authored
      2009-04-12  Christophe Fergeau  <cfergeau@mandriva.com>
      
       	patch by: Sebastian Dransfeld <sebastid@tango.flipp.net>
      
      	* plugins/ipod/rb-ipod-source.c: write album sort information if
      	it's available, fixes the other part of bug #577753.
      
      svn path=/trunk/; revision=6288
      ecf430c3
    • Christophe Fergeau's avatar
      patch by: Sebastian Dransfeld <sebastid@tango.flipp.net> · 082185cb
      Christophe Fergeau authored
      2009-04-12  Christophe Fergeau  <cfergeau@mandriva.com>
      
      	patch by: Sebastian Dransfeld <sebastid@tango.flipp.net>
      
      	* backends/gstreamer/rb-encoder-gst.c:
      	* metadata/rb-metadata-common.c:
      	* metadata/rb-metadata-gst.c:
      	* metadata/rb-metadata.h:
      	* rhythmdb/rhythmdb-private.h:
      	* rhythmdb/rhythmdb-tree.c:
      	* rhythmdb/rhythmdb.c:
      	* rhythmdb/rhythmdb.h: read album sort tag from gstreamer and store
      	it in rhythmbox database. Fixes part of bug #577753.
      
      svn path=/trunk/; revision=6287
      082185cb
    • Christophe Fergeau's avatar
      patch by: Robert Ancell <robert.ancell@gmail.com> · 0cc4382d
      Christophe Fergeau authored
      2009-04-12  Christophe Fergeau  <cfergeau@mandriva.com>
      
      	patch by: Robert Ancell  <robert.ancell@gmail.com>
      
      	* plugins/ipod/rb-ipod-source.c: try harder to build a unique
      	filename when writing to the iPod by adding a random suffix to
      	filenames when we have to truncate them. Fixes bug #570600.
      
      svn path=/trunk/; revision=6286
      0cc4382d
    • Jonathan Matthew's avatar
      Fix the stupid way the stat list mutex was being handled. · fab85ef8
      Jonathan Matthew authored
      2009-04-12  Jonathan Matthew  <jonathan@d14n.org>
      
      	* rhythmdb/rhythmdb.c: (process_added_entries_cb),
      	(rhythmdb_add_to_stat_list), (rhythmdb_add_uri_with_types):
      	Fix the stupid way the stat list mutex was being handled.
      
      svn path=/trunk/; revision=6285
      fab85ef8
    • Jonathan Matthew's avatar
      Ignore podcast items with no URI or a URI without a valid scheme. Fixes · 8fcef661
      Jonathan Matthew authored
      2009-04-12  Jonathan Matthew  <jonathan@d14n.org>
      
      	* podcast/rb-podcast-parse.c: (entry_parsed):
      	Ignore podcast items with no URI or a URI without a valid scheme.
      	Fixes #578398.
      
      svn path=/trunk/; revision=6284
      8fcef661
  8. 11 Apr, 2009 1 commit
    • Bastien Nocera's avatar
      Add rb_gvolume_get_udi utility function to get a UDI from a GVolume, even · a3b07dc4
      Bastien Nocera authored
      2009-04-11  Bastien Nocera  <hadess@hadess.net>
      
      	* lib/Makefile.am:
      	* lib/rb-util.c (rb_gvolume_get_udi):
      	* lib/rb-util.h: Add rb_gvolume_get_udi utility function to
      	get a UDI from a GVolume, even if the gvfs volume monitor doesn't
      	use HAL, or export the UDI information (eg. the DeviceKit-disks
      	gvfs monitor)
      	* plugins/generic-player/rb-generic-player-source.c
      	(get_hal_udi_for_player):
      	* plugins/generic-player/rb-nokia770-source.c (volume_is_nokia770),
      	(rb_nokia770_is_mount_player):
      	* plugins/generic-player/rb-psp-source.c (volume_is_psp),
      	(rb_psp_is_mount_player):
      	* plugins/ipod/rb-ipod-helpers.c (volume_is_ipod),
      	(rb_ipod_helpers_is_ipod): Use rb_gvolume_get_udi() to get the UDI
      	of the devices
      
      	(Closes: #578514)
      
      
      svn path=/trunk/; revision=6283
      a3b07dc4
  9. 10 Apr, 2009 1 commit
  10. 09 Apr, 2009 3 commits
  11. 07 Apr, 2009 3 commits
    • Jonathan Matthew's avatar
      Clear the source ID for the post-resize handler before returning from it, · 30b471ff
      Jonathan Matthew authored
      2009-04-07  Jonathan Matthew  <jonathan@d14n.org>
      
      	* plugins/artdisplay/artdisplay/__init__.py:
      	Clear the source ID for the post-resize handler before returning from
      	it, so we correctly regenerate the source pixbuf when the cover art
      	widget is resized.  Fixes #426164.
      
      svn path=/trunk/; revision=6278
      30b471ff
    • Jonathan Matthew's avatar
      Require libmusicbrainz3 3.0.2 for per-track artist information. · 6a9e739e
      Jonathan Matthew authored
      2009-04-07  Jonathan Matthew  <jonathan@d14n.org>
      
      	* configure.ac:
      	Require libmusicbrainz3 3.0.2 for per-track artist information.
      
      	* plugins/audiocd/sj-metadata-musicbrainz3.c:
      	(make_album_from_release), (mb_list_albums):
      	Update from sound-juicer, including fixes for #576574 and #575820.
      
      svn path=/trunk/; revision=6277
      6a9e739e
    • Jonathan Matthew's avatar
      patch by: Paul Bellamy <paul.a.bellamy@gmail.com> · e3918703
      Jonathan Matthew authored
      2009-04-07  Jonathan Matthew  <jonathan@d14n.org>
      
      	patch by:  Paul Bellamy  <paul.a.bellamy@gmail.com>
      
      	* rhythmdb/rhythmdb.c: (rhythmdb_entry_is_lossless):
      	* rhythmdb/rhythmdb.h:
      	Add a function to determine if an entry represents a lossless encoded
      	stream.  This currently just checks that the bitrate field is 0 and
      	the media type is 'audio/x-flac'.  More media types and other checks
      	can be added later.
      
      	* rhythmdb/rhythmdb-query-model.c:
      	(rhythmdb_query_model_bitrate_sort_func):
      	* rhythmdb/rhythmdb-query-model.h:
      	Add a query model sort function for bitrate comparisons, sorting
      	lossless encodings as being of higher quality than anything with a
      	bitrate.  Not exactly correct, but it's the best we can do.
      
      	* widgets/rb-entry-view.c: (rb_entry_view_quality_cell_data_func),
      	(rb_entry_view_append_column):
      	* widgets/rb-song-info.c: (rb_song_info_update_bitrate):
      	Display "Lossless" for lossless encodings in the 'quality' column in
      	track lists and the same field in the song info dialog.
      
      	Fixes #337438.
      
      svn path=/trunk/; revision=6276
      e3918703
  12. 06 Apr, 2009 3 commits
    • Jonathan Matthew's avatar
      Update from sound-juicer, including fix for #578060. · f3f04bb8
      Jonathan Matthew authored
      2009-04-06  Jonathan Matthew  <jonathan@d14n.org>
      
      	* plugins/audiocd/sj-metadata.c: (sj_metadata_helper_scan_date),
      	(sj_metadata_helper_check_media):
      	Update from sound-juicer, including fix for #578060.
      
      svn path=/trunk/; revision=6275
      f3f04bb8
    • Jonathan Matthew's avatar
      Catch parser exceptions and sort of pretend we can keep going, though all · 0732162b
      Jonathan Matthew authored
      2009-04-06  Jonathan Matthew  <jonathan@d14n.org>
      
      	* plugins/magnatune/magnatune/MagnatuneSource.py:
      	Catch parser exceptions and sort of pretend we can keep going, though
      	all that will show up in the track list will be what we parsed before
      	the error.  Fixes #574465.
      
      	Replace a couple of strange characters that appear in the XML with
      	best guesses as to what they're supposed to be.  This lets us parse
      	the current catalog file successfully.
      
      svn path=/trunk/; revision=6274
      0732162b
    • Jonathan Matthew's avatar
      Remove the bus watch before trying to start the sink. If we're not doing · 05847527
      Jonathan Matthew authored
      2009-04-06  Jonathan Matthew  <jonathan@d14n.org>
      
      	* backends/gstreamer/rb-player-gst-xfade.c: (add_bus_watch),
      	(start_sink_locked), (start_sink), (create_sink):
      	Remove the bus watch before trying to start the sink.  If we're not
      	doing this from the main thread, the main thread could process the
      	messages before the loop in start_sink_locked could, so it'd just sit
      	there waiting.  Fixes #577840.
      
      svn path=/trunk/; revision=6273
      05847527
  13. 05 Apr, 2009 2 commits
  14. 03 Apr, 2009 1 commit
    • Jonathan Matthew's avatar
      Ensure all combo boxes always have an item selected. · 1af910ee
      Jonathan Matthew authored
      2009-04-03  Jonathan Matthew  <jonathan@d14n.org>
      
      	* widgets/rb-query-creator-properties.c:
      	(create_time_unit_option_menu):
      	* widgets/rb-query-creator.c: (rb_query_creator_constructor),
      	(setup_sort_option_menu):
      	Ensure all combo boxes always have an item selected.
      
      svn path=/trunk/; revision=6270
      1af910ee
  15. 02 Apr, 2009 1 commit
    • Jonathan Matthew's avatar
      Finish implementing saving of cover art. · fe314bf9
      Jonathan Matthew authored
      2009-04-02  Jonathan Matthew  <jonathan@d14n.org>
      
      	* plugins/artdisplay/artdisplay/LocalCoverArtSearchGIO.py:
      	Finish implementing saving of cover art.
      
      svn path=/trunk/; revision=6269
      fe314bf9
  16. 31 Mar, 2009 2 commits
  17. 30 Mar, 2009 4 commits
    • Jonathan Matthew's avatar
      Use correct printf format for the image size. · 6785ea23
      Jonathan Matthew authored
      2009-03-31  Jonathan Matthew  <jonathan@d14n.org>
      
      	* plugins/mtpdevice/rb-mtp-source.c: (artwork_notify_cb):
      	Use correct printf format for the image size.
      
      svn path=/trunk/; revision=6266
      6785ea23
    • Jonathan Matthew's avatar
      add EggSMClient files. · c8c99a92
      Jonathan Matthew authored
      2009-03-31  Jonathan Matthew  <jonathan@d14n.org>
      
      	* POTFILES.in:  add EggSMClient files.
      
      svn path=/trunk/; revision=6265
      c8c99a92
    • Jonathan Matthew's avatar
      Create album objects on the device when transferring songs, and delete · 8f96aef6
      Jonathan Matthew authored
      2009-03-30  Jonathan Matthew  <jonathan@d14n.org>
      
      	* plugins/mtpdevice/rb-mtp-source.c: (rb_mtp_source_init),
      	(rb_mtp_source_constructor), (rb_mtp_source_finalize),
      	(load_mtp_db_idle_cb), (add_track_to_album),
      	(remove_track_from_album), (impl_delete), (transfer_track),
      	(impl_track_added), (artwork_notify_cb):
      	Create album objects on the device when transferring songs, and delete
      	them when the last song is removed.  If all of the existing albums
      	have zero tracks, try to rebuild the albums when reading the song
      	list.  This helps with some odd devices that forget all album contents
      	when they restart.
      
      	If the device supports the JPEG file type, request album art when
      	transferring songs, and send it to the device as a 'representative
      	sample' of the album.
      
      svn path=/trunk/; revision=6264
      8f96aef6
    • Sandeep Shedmake's avatar
      Added 'mr' · 75a8ffa4
      Sandeep Shedmake authored
      svn path=/trunk/; revision=6263
      75a8ffa4