Total size label is stuck if the request fails
Steps to reproduce
- Open the app
- Find an episode that returns 404 when trying to download it and the RSS length is Null
- Click download
Reproducible in:
- Flatpak unstable: yes
- Other: Everything <= 0.4.5
Current behavior
A background callback is triggered that monitors total_bytes
field of the Progress
struct (Yes the whole design sucks).
But the request fails and the callback has no indication of it, not even shoud_cancel
is set. Thus it keeps polling forever the struct field and the size is never updated.
Screencast_09-04-2018_04_13_10_PM
Expected behavior
Upon failure, labels are hidden appropriatly
Additional information
The underneath implementation is already terrible and probably the worst part of the app, I am sorry.