Verified Commit 24058f95 authored by Jordan Petridis's avatar Jordan Petridis 🌱

h-gtk: Write doc comment for aboutdialog.

parent a8d47e9a
Pipeline #13436 failed with stages
in 36 minutes and 23 seconds
......@@ -32,6 +32,7 @@ pub struct Header {
impl Default for Header {
fn default() -> Header {
let builder = gtk::Builder::new_from_resource("/org/gnome/Hammond/gtk/headerbar.ui");
let menus = gtk::Builder::new_from_resource("/org/gnome/Hammond/gtk/menus.ui");
let header = builder.get_object("headerbar").unwrap();
let add_toggle = builder.get_object("add_toggle").unwrap();
......@@ -42,7 +43,6 @@ impl Default for Header {
let update_label = builder.get_object("update_label").unwrap();
let update_spinner = builder.get_object("update_spinner").unwrap();
let menu_button = builder.get_object("menu_button").unwrap();
let menus = gtk::Builder::new_from_resource("/org/gnome/Hammond/gtk/menus.ui");
let app_menu = menus.get_object("menu").unwrap();
Header {
......
......@@ -3,6 +3,7 @@ use gtk::prelude::*;
// Totally copied it from fractal.
// https://gitlab.gnome.org/danigm/fractal/blob/503e311e22b9d7540089d735b92af8e8f93560c5/fractal-gtk/src/app.rs#L1883-1912
/// Given a `window` create and attach an `gtk::AboutDialog` to it.
  • a or an? looks a little bit odd as an

  • well I think(not a native English speaker) it depends on how you read it.

    If you read gtk::AboutDialog I guess it should be a, but if you read AboutDialog then I think it should an.

    Initially I had written just AboutDialog but then Added gtk:: for clearance.

    In any case feel free to propose any changes that might improve the project no matter how small/big they are.

  • yes without the gtk:: an does make sense

Please register or sign in to reply
pub fn about_dialog(window: &gtk::Window) {
// Feel free to add yourself if you contribured.
let authors = &[
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment