GitLab

Fix for Issue-213: Authenicated podcast using email address for username not working (skeptoid.com/premium.xml)

The url.username automatically url encodes the user name which does not work for this podcast feed.
The fix was to replace the %40 in the username back to an @ symbol.

Add changes to the CHANGELOG for 0.4.9

See merge request !181

Get rid of clippy errors

See merge request !182

Copy cache across filesystems

Closes #127

See merge request !180

Fixes #127

Update README

See merge request !179

The file org.gnome.Podcasts.json has been renamed.
The command using this file in the README no longer works.
The file name provided in the README has been updated.

Its trivial to patch the devel manifest to use the normal
app id and build profile.

Refresh cached cover art

Closes #144

See merge request !176

The hash of the image uri was previously stored as an integer in the db.
This has been changed to avoid casting in the hashing function.
The hash value, a u64, is now stored as 8 u8 values in a binary blob.
These 8 values are stored in a Vec<u8> instead of an array for the db.
Conversion functions have been added as required.

Furthermore, a bug involving hashing the image uri has been fixed.
Previously, the hashing function was erroneously hashing the Option.
Now, the hashing function only hashes the String value, as expected.

This commit removes some test assertions for side effects.
These checked the title, description, and a couple other fields.
These were removed due to distracting from the main intent of the tests.

Additionally, any direct hash calculations have been evaluated manually.
This separates the unit tests from the hashing implementation.
This follows best practices making the unit tests DAMP.

The two new getters are only used for tests.
It makes sense to annotate them as such.
The #[cfg(test)] replaces the previous #[allow(dead_code)] annotation.

One of the existing getters had an unnecessary #[allow(dead_code)].
This has also been removed to keep things tidy.

The truncate_db function has been made public to improve this test case.
This is not yet working and there will need to be more cases.
The source id is not found which causes the test to crash.

This commit also removes the logging from these update functions.
It might be worth refactoring these tests.
They could compare against the actual image uri hash values.

This makes the function extremely easy to test.
Additionally, the default valid duration is now a static constant.

The method has also been renamed to is_cached_image_valid.

This commit adds another cache validation parameter.
Previously, support for time-based caching was added.
This may not retrieve updated images very quickly for the user.
Thus, the image's URI is checked for changes.
A hash value of the image's URI is updated when it is downloaded.
When feeds are updated, the image URI is checked against this hash.
If the hash has changed the image is downloaded and the hash updated.

The hash function uses Rust's standard hasher.
This produces a 64-bit unsigned integer.
The caveat is that sqlite doesn't support unsigned integer values.
To get around this, the hash function converts this to a signed integer.
I should probably double check the corner cases of the cast done here.

Tests still need to be added for this functionality.
The changelog will also need to be updated in a subsequent commit.