Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • Highscore Highscore
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 131
    • Issues 131
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • World
  • HighscoreHighscore
  • Merge requests
  • !5

Refactor thumbnails

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Adrien Plazas requested to merge aplazas/highscore:icon-refactor into main Jun 25, 2021
  • Overview 4
  • Commits 4
  • Pipelines 1
  • Changes 6

This refactors how thumbnails are cached to make their cache directory name more relevant. This also draws the icons at the same size as the covers, and make icon ojects return a pixbuf as we don't need GIcon anymore. This makes hand is a first step in making game-embedded icons and externaly provided covers be handled the same way.

This also fixes some thumbnail sizing issues that were caused by differences in how covers and icons were treated.

Edited Jun 25, 2021 by Adrien Plazas
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: icon-refactor